[9] RFR: 8043387: java/time/test/java/util/TestFormatter.java failed.

2016-06-10 Thread Naoto Sato
Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8043387 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8043387/webrev.00/ The issue only is reproducible when the underlying OS's default time zone is "GMT+XX:XX". In that case, the

Re: RFR 8139507: WARNING: Could not open/create prefs root node Software\JavaSoft\Prefs

2016-06-10 Thread Jan Lahoda
Hi Alan, Thanks for the comment, an answer is inlined. On 10.6.2016 12:20, Alan Bateman wrote: On 08/06/2016 18:39, Jan Lahoda wrote: Hello, When starting JShell on Windows, one may see a message like this: ?vn 08, 2016 6:46:35 ODP. java.util.prefs.WindowsPreferences WARNING: Could not ope

Re: RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over 101 access

2016-06-10 Thread Daniel Fuchs
Hi Ramanand, Looks good to me now. best regards, -- daniel On 10/06/16 14:47, Ramanand Patil wrote: Hi Daniel and Bernd, Thank you for your reviews. Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8153955/webrev.02/ Bernd, Considering the information that "if the FileHandler

RE: RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over 101 access

2016-06-10 Thread Ramanand Patil
Hi Daniel and Bernd, Thank you for your reviews. Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8153955/webrev.02/ Bernd, Considering the information that "if the FileHandler tries to open the filename and finds the file is currently in use by another process it will increment t

Re: RFR:JDK-8066806:java.time.format.DateTimeFormatter cannot parse an offset with single digit hour

2016-06-10 Thread Stephen Colebourne
The test test_strict_offset_adjacentValidPattern_parse should also check that the hour of day was parsed to 12. I don't think there are any tests of the lenient behaviour? thanks Stephen On 10 June 2016 at 12:17, nadeesh tv wrote: > Hi, > > Please see the updated webrev > http://cr.openjdk.java

Re: RFR:JDK-8066806:java.time.format.DateTimeFormatter cannot parse an offset with single digit hour

2016-06-10 Thread nadeesh tv
Hi, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8066806/webrev.08/ Thanks and Regards, Nadeesh On 6/9/2016 4:29 PM, nadeesh tv wrote: Hi Stephen, On 6/9/2016 4:19 PM, Stephen Colebourne wrote: "absHours / 10 > 0" would be simpler as "absHours >= 10" Around line 3595 we have

Re: RFR 8139507: WARNING: Could not open/create prefs root node Software\JavaSoft\Prefs

2016-06-10 Thread Alan Bateman
On 08/06/2016 18:39, Jan Lahoda wrote: Hello, When starting JShell on Windows, one may see a message like this: ?vn 08, 2016 6:46:35 ODP. java.util.prefs.WindowsPreferences WARNING: Could not open/create prefs root node Software\JavaSoft\Prefs at root 0 x8002. Windows RegCreateKeyEx(...)