Hi Patrick,
looks good for me. Thanks!
Best regards,
Andrej Golovnin
Hi Roger,
src/java.base/share/classes/java/io/ObjectInputStream.java
259 private static class Logging {
The class can be final.
1265 ? Logger.Level.DEBUG
There is one space too much before "Logger".
2611 /** total bytes read from the stream */
2612
On 08/09/2016 20:52, Henry Jen wrote:
Hi,
Please review a trivial fix for bug 8042148 at following URL:
Webrev: http://cr.openjdk.java.net/~henryjen/jdk9/8042148/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8042148
The ordering/re-wording looks okay, just surprised to see -Xcomp add
On 9/09/2016 1:05 PM, Henry Jen wrote:
According to David in the comments, -Xusealtsigs is no longer an option, is it?
We have deprecated a number of flags:
// -Xoss, -Xsqnopause, -Xoptimize, -Xboundthreads, -Xusealtsigs
so they are ignored. But we still allow the user to specify them - and
Hi Max,
On 9/09/2016 3:40 AM, Max Schulze wrote:
Hello,
I am trying to implement my own virtual machine and making use of the
rt.jar .
Difficult, because rt.jar is not a stand-alone implementation that can
be mixed-and-matched with arbitrary VMs. The initialization sequence is
very intricat
According to David in the comments, -Xusealtsigs is no longer an option, is it?
Cheers,
Henry
On September 8, 2016 at 3:27:21 PM, Kumar Srinivasan
(kumar.x.sriniva...@oracle.com) wrote:
> Hi Henry,
>
> Looks a lot nicer with the alpha ordering, but it seems to be missing
> -Xusealtsigs use alte
Is it just a matter of an extra step, new File(path).getName()?
Masayoshi
On 9/9/2016 12:00 AM, Naoto Sato wrote:
Well, actually I tried this approach first, then found out that the
data files are also used by the GenerateBreakIteratorData build tool
which has some implicit assumption of the
Hi Henry,
Looks a lot nicer with the alpha ordering, but it seems to be missing
-Xusealtsigs use alternative signals instead of SIGUSR1 and SIGUSR2 for
JVM internal signals
Kumar
On 9/8/2016 12:52 PM, Henry Jen wrote:
Hi,
Please review a trivial fix for bug 8042148 at following URL:
Webrev
On 09/09/2016 01:02 AM, Mandy Chung wrote:
> Spec bug: missing @throws NPE if the specified name is null in the relevant
> getPackage methods:
> ClassLoader.getDefinedPackage, ClassLoader::getPackage, Package::getPackage
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165346
+1
> On Sep 8, 2016, at 6:02 PM, Mandy Chung wrote:
>
> Spec bug: missing @throws NPE if the specified name is null in the relevant
> getPackage methods:
> ClassLoader.getDefinedPackage, ClassLoader::getPackage, Package::getPackage
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk9/webr
Spec bug: missing @throws NPE if the specified name is null in the relevant
getPackage methods:
ClassLoader.getDefinedPackage, ClassLoader::getPackage, Package::getPackage
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165346/webrev.00/index.html
Mandy
On 09/09/2016 12:18 AM, Paul Sandoz wrote:
> diff -r 10d8bdeabfa5
> src/java.base/share/classes/java/lang/invoke/VarHandle.java
> --- a/src/java.base/share/classes/java/lang/invoke/VarHandle.java Thu Sep
> 08 09:59:54 2016 -0700
> +++ b/src/java.base/share/classes/java/lang/invoke/VarHandle.j
+1
On Sep 8, 2016, at 2:18 PM, Paul Sandoz wrote:
> Hi,
>
> Please review this simple fix to remove a straggling reference to a
> previously removed method.
>
> Thanks,
> Paul.
>
> diff -r 10d8bdeabfa5
> src/java.base/share/classes/java/lang/invoke/VarHandle.java
> --- a/src/java.base/share
Hi Sean,
I'm going to push the fix to get a valid link in the table, but I don't
oppose if someone else files a follow-up bug to change the spec and
remove the row if that is appropriate course of action.
Thanks,
-Joe
On 9/8/2016 12:55 PM, Sean Mullan wrote:
Actually, I don't really think
Hi,
Please review this simple fix to remove a straggling reference to a previously
removed method.
Thanks,
Paul.
diff -r 10d8bdeabfa5 src/java.base/share/classes/java/lang/invoke/VarHandle.java
--- a/src/java.base/share/classes/java/lang/invoke/VarHandle.java Thu Sep
08 09:59:54 2016 -07
I tried to include all the feedback here:
http://cr.openjdk.java.net/~reinhapa/reviews/8161230/webrev.04
-Patrick
On 08.09.2016 20:09, Paul Sandoz wrote:
>> On 8 Sep 2016, at 08:20, Patrick Reinhart wrote:
>>> And one more thing. Because we have now only one method to get a
>>> stream I think t
On 09/08/2016 11:31 PM, Paul Sandoz wrote:
>> On 8 Sep 2016, at 12:37, Claes Redestad wrote:
On 09/08/2016 09:21 PM, Paul Sandoz wrote:
Did you consider replacing the if block with an assert? presumably if
it is non-zero it is an internal error?
>>>
>>> The original check was to gua
On 08/09/2016 20:38, Mandy Chung wrote:
:
Yes everything counts.
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165634/webrev.01/
Looks good.
-Alan
> On 8 Sep 2016, at 12:37, Claes Redestad wrote:
>
>>
>>> On 09/08/2016 09:21 PM, Paul Sandoz wrote:
>>> Did you consider replacing the if block with an assert? presumably if
>>> it is non-zero it is an internal error?
>>
>> The original check was to guard against Unsafe.allocateUnitializedArr
Hi Stefan,
It's great to know you've found the solution! Hopefully this is indeed
the last issue for you with JDK 9 :-)
I've checked in a fix for the redirect failure [1] into the dev repo. It
would probably be included in the next week's build (b136). Please let
me know if this doesn't work
Actually, I don't really think this permission target belongs in
RuntimePermission since it is specific to Oracle's Java Plugin. I would
be in favor of removing it and only documenting it in the deployment guides.
--Sean
On 09/08/2016 02:17 PM, Lance Andersen wrote:
all good Joe
On Sep 8, 20
Hi,
Please review a trivial fix for bug 8042148 at following URL:
Webrev: http://cr.openjdk.java.net/~henryjen/jdk9/8042148/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8042148
The fix added options asked for as discussed in the bug comments, and sort
those options in alphabetical orde
Hi,
On 2016-09-08 20:56, Aleksey Shipilev wrote:
Hi,
On 09/08/2016 08:03 PM, Claes Redestad wrote:
Webrev: http://cr.openjdk.java.net/~redestad/8165492/webrev.01/
It is a bit sad that we have to bust the doors with internal APIs, and
not use the public API, thus robbing ourselves of the oppo
> On Sep 8, 2016, at 10:59 AM, Alan Bateman wrote:
>
>
>
> On 08/09/2016 14:23, harold seigel wrote:
>> Hi,
>>
>> Please review this fix for JDK-8165634. The fix changes the --add-modules
>> option from being a 'last one wins' option to a cumulative one. With this
>> change, if multiple -
Please review updates to the Serialization filtering API and implementation:
- The ObjectInputFilter pattern based filters support matching on
module names as well as package and class names.
- Rename of system property and java.security property for
configurable filters. (jdk.serialFilter)
Hi,
On 09/08/2016 08:03 PM, Claes Redestad wrote:
> Webrev: http://cr.openjdk.java.net/~redestad/8165492/webrev.01/
It is a bit sad that we have to bust the doors with internal APIs, and
not use the public API, thus robbing ourselves of the opportunity to
optimize the public API for a wide range
Hi Patrick,
>> 1362 * Returns a stream that loads the resources with the given name.
>> 1375 * The loading of resources will occur when the returned stream
>> is
>> 1376 * evaluated. If the loading of resources results in an
>> {@code IOException}
>> In reality however, no resourc
Hi,
Quick observation before diving in further.
IIUC you are essentially adding a dummy index parameter to
StringConcatHelper.newString, which should always be zero, and that helps
compress LFs for the MH combinator:
341 static String newString(byte[] buf, int index, byte coder) {
342
all good Joe
> On Sep 8, 2016, at 2:16 PM, joe darcy wrote:
>
> Hello,
>
> Please review the patch below to address
>
>JDK-8039854: Broken link in java.lang.RuntimePermission
>
> Two broken links are replaced by a live link to the deployment guide.
>
> Thanks,
>
> -Joe
>
>
> --- a/src/
Hello,
Please review the patch below to address
JDK-8039854: Broken link in java.lang.RuntimePermission
Two broken links are replaced by a live link to the deployment guide.
Thanks,
-Joe
--- a/src/java.base/share/classes/java/lang/RuntimePermission.java Thu
Sep 08 16:16:44 2016 +0100
+
> On 8 Sep 2016, at 08:20, Patrick Reinhart wrote:
>> And one more thing. Because we have now only one method to get a
>> stream I think the constant RESOURCE_CHARACTERISTICS should be defined
>> inside the #resources()-method. It is not needed to define it as a
>> static final field.
>
> The re
On 08/09/2016 14:23, harold seigel wrote:
Hi,
Please review this fix for JDK-8165634. The fix changes the
--add-modules option from being a 'last one wins' option to a
cumulative one. With this change, if multiple --add-modules options
are specified, the VM accumulates all the options' va
Hello,
I am trying to implement my own virtual machine and making use of the
rt.jar .
I am following the language and vm specification and currently have not
come across formalities that require implementation/prefill of
java.lang.System*props.
When the IntegerCache is being initialized, it ca
On 9/8/16, 10:12 AM, Lois Foltan wrote:
On 9/8/2016 9:23 AM, harold seigel wrote:
Hi,
Please review this fix for JDK-8165634. The fix changes the
--add-modules option from being a 'last one wins' option to a
cumulative one. With this change, if multiple --add-modules options
are specifi
True, and it looks like there's a little gap between the normalizer tool
and jcheck that I didn't know. The importance is that the source files
shall not contain tabs, carriage returns, or trailing spaces. But as we
found out in this case, the normalizer has an extra rule that is, there
shall b
On 9/8/2016 9:23 AM, harold seigel wrote:
Hi,
Please review this fix for JDK-8165634. The fix changes the
--add-modules option from being a 'last one wins' option to a
cumulative one. With this change, if multiple --add-modules options
are specified, the VM accumulates all the options' val
Hi,
StringConcatFactory$MethodHandleInlineCopyStrategy was made the default
strategy in 9+120, which brought with it a number of startup
regressions due to heavy use of MethodHandles when running the
bootstrap method for each String concatenation. In exchange it allows
for better peak performance
+1
Naoto
On 9/7/16 7:22 AM, Sergei Kovalev wrote:
Fixed. Please find new version here:
http://cr.openjdk.java.net/~skovalev/8165592/webrev.01/
07.09.16 16:13, Alexandre (Shura) Iline wrote:
"Copyright (c) 2007,2016 Oracle”
Should be
"Copyright (c) 2007, 2016, Oracle”
Otherwise good.
Shur
hi Harold,
The changes look fine. I have a couple of questions though:
#1 Would the "test/runtime/modules/ModuleOptionsTest.java” be more robust if we
included a case with a non-error return value that takes more than one module?
Ex: “java --add-modules=java.base
--add-modules=jdk.internal.ref
Hi Tim,
Thanks for your reply. It's good to know at least the known use cases from
IBM have indeed been discussed.
On Thu, Sep 8, 2016 at 9:01 AM, Tim Ellison wrote:
> On 07/09/16 23:45, Krystal Mok wrote:
> > I see that on the JBS page, your most recent comment says it's been
> decided
> > tha
On 07/09/16 23:45, Krystal Mok wrote:
> I see that on the JBS page, your most recent comment says it's been decided
> that for JDK9 it's okay to deprecate and forRemoval=true, while also
> mentioning the uses of this class in IBM's implementation.
>
> Does that mean IBM has agreed on the deprecati
> On Sep 8, 2016, at 12:16 AM, Andrej Golovnin
> wrote:
>
> Hi all,
>
> Maybe I'm wrong but I think the JavaDocs for the new method need more
> love. The JavaDocs mention at multiple places that resources are
> loaded, e.g.:
>
> 1362 * Returns a stream that loads the resources with the g
Updated the webrev wrt the latter comment:
http://cr.openjdk.java.net/~naoto/8165605/webrev.02/
Naoto
On 9/7/16 6:37 PM, Mandy Chung wrote:
On Sep 7, 2016, at 6:29 PM, Naoto Sato wrote:
Hi Mandy,
Although avoiding the hardcoded pathname is good, it is specific to the
BreakIterator implem
On 2016-09-08 09:16, Andrej Golovnin wrote:
Hi all,
Maybe I'm wrong but I think the JavaDocs for the new method need more
love. The JavaDocs mention at multiple places that resources are
loaded, e.g.:
1362 * Returns a stream that loads the resources with the given
name.
1375 * The
Well, actually I tried this approach first, then found out that the data
files are also used by the GenerateBreakIteratorData build tool which
has some implicit assumption of the value being the file name w/o path.
So I ended up with the fix.
Naoto
On 9/8/16 5:46 AM, Alan Bateman wrote:
On
> On Sep 7, 2016, at 11:52 PM, Alan Bateman wrote:
>
> On 08/09/2016 03:53, David Holmes wrote:
>
>> Despite code to contrary, I don't think the system classloader has "ever"
>> been allowed to be null. If it can't be constructed then the whole
>> initialization process will fail with an exce
So jdeps can recursively identify all dependencies given a list of the
jars that my application is made of. Assume my main application jar is
app.jar and it depends (per gradle or maven dependencies resolution) on
following libraries like so:
app.jar > a.jar, b.jar
a.jar --> x.jar, y.jar, z.ja
Hi,
Please review this fix for JDK-8165634. The fix changes the
--add-modules option from being a 'last one wins' option to a cumulative
one. With this change, if multiple --add-modules options are specified,
the VM accumulates all the options' values, instead of ignoring all but
the last o
On 08/09/2016 03:51, Masayoshi Okutsu wrote:
I thought Mandy suggested that the dictionary names in a
ResourceBundle contain path names rather than base names, something
like this:
In BreakIteratorInfo_th.java:
{"WordDictionary", "thai_dict"},
to
{"WordDictionary", "
Looks good to me, Ramanand!
With kind regards,
Ivan
On 08.09.2016 12:21, Ramanand Patil wrote:
Gentle reminder...
Please review this trivial change.
Regards,
Ramanand.
-Original Message-
From: Ramanand Patil
Sent: Wednesday, August 31, 2016 3:02 PM
To: core-libs-dev@openjdk.java.net
Gentle reminder...
Please review this trivial change.
Regards,
Ramanand.
-Original Message-
From: Ramanand Patil
Sent: Wednesday, August 31, 2016 3:02 PM
To: core-libs-dev@openjdk.java.net
Subject: RFR: 8160951, 8160958: "Test
javax/xml/bind/marshal/8134111/UnmarshalTest.java should be
Hi all,
Maybe I'm wrong but I think the JavaDocs for the new method need more
love. The JavaDocs mention at multiple places that resources are
loaded, e.g.:
1362 * Returns a stream that loads the resources with the given name.
1375 * The loading of resources will occur when the return
On 07/09/2016 21:52, Stuart Marks wrote:
Hi all,
Please review this small patch to deprecate java.lang.Compiler for
removal.
Looks good, often confusing to see it in the javadoc.
-Alan
The normalizer tool will remove any extra LFs, only leave one. But it may be an
internal tool, so I think it's not a rule.
Thanks
Frank
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Subject: RE: RFR JDK-8165617: Cleanup whitespace in jaxp/test
>
> Hi
54 matches
Mail list logo
