Re: RFR: jsr166 jdk9 integration wave 12

2016-10-19 Thread Martin Buchholz
On Wed, Oct 19, 2016 at 4:40 PM, Jonathan Bluett-Duncan < jbluettdun...@gmail.com> wrote: > Hi Martin, > > By collections infrastructure, do you mean something like the collection > testers in guava-testlib? > > If so, I agree that JUnit 5's dynamic tests look promising for > implementing such an

RFR 8168127: FilePermissionCollection merges incorrectly

2016-10-19 Thread Wang Weijun
Please review the code change at http://cr.openjdk.java.net/~weijun/8168127/webrev.00/ Two changes: 1. npath2 is considered in equals and hashCode of FilePermission, so 2 objects with different npath2 can be added to a map and different entries. 2. special name for newPermUsingAltPath and

Re: RFR: jsr166 jdk9 integration wave 12

2016-10-19 Thread Martin Buchholz
On Wed, Oct 19, 2016 at 3:44 PM, Paul Sandoz wrote: > > On 18 Oct 2016, at 13:58, Martin Buchholz wrote: > > Latest webrev defers potential new methods: > >/* TODO: public */ private void trimToSize() > > Sorry to push back, i know it’s a hassle,

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

2016-10-19 Thread Steve Drach
>> On Oct 19, 2016, at 5:05 PM, Steve Drach wrote: >> issue: https://bugs.openjdk.java.net/browse/JDK-8164805 webrev: http://cr.openjdk.java.net/~sdrach/8164805/webrev.00/ >>> >>> Issue a warning is good in the case public classes are added in a concealed >>>

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 5:22 PM, Steve Drach wrote: > >> 76 private String files(Path start) throws IOException { >> Perhaps return Stream. That can replace the unnecessary concat in a >> String and then later split to pass to javac. > > Is this better? > >

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 5:05 PM, Steve Drach wrote: > >>> issue: https://bugs.openjdk.java.net/browse/JDK-8164805 >>> webrev: http://cr.openjdk.java.net/~sdrach/8164805/webrev.00/ >> >> Issue a warning is good in the case public classes are added in a concealed >>

Re: Review Request: JDK-8167057 jdeps to list the modules and internal APIs to help find @modules for tests

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 4:22 PM, Alexandre (Shura) Iline > wrote: > > Mandy, > > I have a question around line 228 of > src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java: > 224 new Option(false, "--list-deps", "--list-reduced-deps") { > 225

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

2016-10-19 Thread Steve Drach
> 76 private String files(Path start) throws IOException { > Perhaps return Stream. That can replace the unnecessary concat in a > String and then later split to pass to javac. Is this better? private void javac(Path source, Path destination) throws IOException { Stream prefix

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

2016-10-19 Thread Steve Drach
>> issue: https://bugs.openjdk.java.net/browse/JDK-8164805 >> webrev: http://cr.openjdk.java.net/~sdrach/8164805/webrev.00/ > > Issue a warning is good in the case public classes are added in a concealed > package. Some comments: > > Main.java > > addExtendedModuleAttributes does not seem to

Re: RFR: jsr166 jdk9 integration wave 12

2016-10-19 Thread Jonathan Bluett-Duncan
Hi Martin, By collections infrastructure, do you mean something like the collection testers in guava-testlib? If so, I agree that JUnit 5's dynamic tests look promising for implementing such an infrastructure. I admit I don't have all the context here, but would using guava-testlib in the

Re: [9] RfR: 8165271: Fix use of reflection to gain access to private fields

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 3:50 PM, David DeHaven wrote: > > > Please review the new patch version: > http://cr.openjdk.java.net/~ddehaven/8165271/jdk.1/ > Looks okay but I think the new interface should be named “JavaNetURLClassLoaderAccess” (matching “URLClassLoader")

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 11:34 AM, Steve Drach wrote: > > issue: https://bugs.openjdk.java.net/browse/JDK-8164805 > webrev: http://cr.openjdk.java.net/~sdrach/8164805/webrev.00/ Issue a warning is good in the case public classes are added in a concealed package. Some

Re: Review Request: JDK-8167057 jdeps to list the modules and internal APIs to help find @modules for tests

2016-10-19 Thread Alexandre (Shura) Iline
Mandy, I have a question around line 228 of src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java: 224 new Option(false, "--list-deps", "--list-reduced-deps") { 225 void process(JdepsTask task, String opt, String arg) { 226

Re: [9] RfR: 8165271: Fix use of reflection to gain access to private fields

2016-10-19 Thread David DeHaven
Please review the new patch version: http://cr.openjdk.java.net/~ddehaven/8165271/jdk.1/ This was updated for the recent changes due to JDK-8168073. Note that the patch is against jdk9-client but I can apply and push to 9-dev. Test runs with both client and jake were successful. -DrD- > On

Re: RFR: jsr166 jdk9 integration wave 12

2016-10-19 Thread Paul Sandoz
> On 18 Oct 2016, at 13:58, Martin Buchholz wrote: > > Latest webrev defers potential new methods: >/* TODO: public */ private void trimToSize() Sorry to push back, i know it’s a hassle, but i think such features should be retained in a separate proposed patch. Paul.

Re: RFR: jsr166 jdk9 integration wave 12

2016-10-19 Thread Martin Buchholz
These tests are maintained outside of openjdk and have only recently been made available within openjdk. There may be a future where all the consumers of these tests are willing to accept a good test framework. Junit 5 dynamic tests look promising

Review Request: JDK-8167057 jdeps to list the modules and internal APIs to help find @modules for tests

2016-10-19 Thread Mandy Chung
Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167057/webrev.00/ This patch enhances jdeps to print the dependences in the format : $MODULE[/$PACKAGE]. This is intended for analyzing the regression tests we develop and add make it easy to add the proper @modules. Mandy

Re: RFR (JAXP): 8167179: Make XSL generated namespace prefixes local to transformation process

2016-10-19 Thread Joe Wang
Hi Aleksej, The change looks good. Thanks, Joe On 10/19/16, 7:19 AM, Aleks Efimov wrote: Hi, Please help to review the JDK9 fix for JDK-8167179 [1]: http://cr.openjdk.java.net/~aefimov/8167179/9/00/: The fix changes how the xsl:element namespace prefix values are generated during the

Re: JDK 9 org.omg.CORBA.ORBSingletonClass loading will not use context class loader

2016-10-19 Thread Tom Hood
I haven't tried JDK 9 yet. I was assuming the 7u55 change in JDK 9 would impact our application the same way. I hope to try it next week as I'm currently stuck testing on windows XP which limits me to 1.7 or earlier. So maybe Approach #3 will be: "It should just work" [*I think I'm required to

RFR 9: 8164908: ReflectionFactory support for IIOP and custom serialization

2016-10-19 Thread Roger Riggs
The support in sun.reflect.ReflectionFactory for custom serialization, such as IIOP input and output streams, is being expanded beyond the necessary constructor of a serializable class to include access to the private methods readObject, writeObject, readResolve, writeReplace, etc. The IIOP

Re: RFR: jsr166 jdk9 integration wave 12

2016-10-19 Thread Stuart Marks
On 10/18/16 11:00 AM, Martin Buchholz wrote: There's already a certain amount of mixing, e.g. stream tests sometimes test j.u.c. and Queue tests sometimes test all the Queue implementations. Unlike non-test code, some redundancy and divergence of testing frameworks and styles is fine. I still

RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

2016-10-19 Thread Steve Drach
Hi, Please review the following changeset. This fix allows jar tool to add a new public class in a versioned directory in a modular multi-release jar file if the class is in a concealed package. When this event takes place, a warning message is emitted saying that placing this jar on a class

RFR (JAXP): 8167179: Make XSL generated namespace prefixes local to transformation process

2016-10-19 Thread Aleks Efimov
Hi, Please help to review the JDK9 fix for JDK-8167179 [1]: http://cr.openjdk.java.net/~aefimov/8167179/9/00/: The fix changes how the xsl:element namespace prefix values are generated during the transformation process. JDK9 build that includes this fix was tested with JDK XML related

Re: RFR 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown

2016-10-19 Thread Sundararajan Athijegannathan
Hi Alan, Thanks for your review. Yes, spec. change is being tracked. I'll remove that whitespace after doc comment of getProgram method and push it. PS. Updated webrev for the record: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.01/ Thanks, -Sundar On 19/10/16, 12:42 PM, Alan

Re: JDK 9 org.omg.CORBA.ORBSingletonClass loading will not use context class loader

2016-10-19 Thread Alan Bateman
On 19/10/2016 03:28, Tom Hood wrote: It's unclear if there really is an interop issue. The application will launch with 7u55 if I don't set the ORBSingletonClass property, although that isn't how visibroker 5.2.1 was intended to run, so not setting it worries me. Our application does call

Re: RFR 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown

2016-10-19 Thread Alan Bateman
On 19/10/2016 06:06, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8071588 jdk webrev: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8071588/nashorn/webrev.00/ This looks okay

Re: RFR 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown

2016-10-19 Thread Hannes Wallnöfer
+1 Hannes > Am 19.10.2016 um 07:06 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8071588 > > jdk webrev: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.00/ > > nashorn webrev: >

Re: RFR: 8163984: Fix license and copyright headers in jdk9 under test/lib

2016-10-19 Thread Stanislav Smirnov
David, thank you Best regards, Stanislav Smirnov > On 19 Oct 2016, at 04:27, David Holmes wrote: > > Hi Stanislav, > > On 19/10/2016 1:06 AM, Stanislav Smirnov wrote: >> Hi, >> >> I'm still looking for volunteers to review > > This is trivial. Reviewed. I will