RE: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

Hi Frank, to me this looks fine. Maybe a small cosmetical thing: Around lines 212 and 240 you could remove the additional empty lines to have one blank line between methods as in the rest of the file. Note that I'm not a reviewer. Best regards Christoph From: Frank Yuan [mailto:frank.y...@ora

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Thanks, Frank. we run scheduled jtreg tests for jdk every night so we should have encountered issues if there were some. But langtools could be interesting, I don't think those run automatically for OpenJDK in our environment. Best regards Christoph > -Original Message- > From: Frank Y

Re: RFR[9] JDK-8158916: ProblemList.txt update for com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java

Hi Daniel, I'll push the below patch: diff -r 5cd2aa3f3e9b test/ProblemList.txt --- a/test/ProblemList.txt Tue Nov 22 10:45:48 2016 -0800 +++ b/test/ProblemList.txt Tue Nov 22 21:34:47 2016 -0800 @@ -305,6 +305,6 @@ # jdk_other -com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java 8141370 li

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Christoph and Volker I have been launching jdk and langtools tests with the new jtreg, will update to you once I get the result. Hope jaxp test is special because most of tests should control the Security Manager setting inside the test methods. Thanks Frank > -Original Message- >

Re: RFR 8170248, Problem list javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java

Excuse me, On 2016/11/23 13:15, Felix Yang wrote: Hi, this test fails frequently on Linux platforms. I suggest to exclude it until JDK-8169737 is fixed. Thanks, Felix Corrected diff: diff -r 67d3235a317f test/ProblemList.txt --- a/test/ProblemList.txt Wed Nov 23 10:12:01 2016 +

RFR 8170248, Problem list javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java

Hi, this test fails frequently on Linux platforms. I suggest to exclude it until JDK-8169737 is fixed. Thanks, Felix diff -r 67d3235a317f test/ProblemList.txt --- a/test/ProblemList.txt Wed Nov 23 10:12:01 2016 +0800 +++ b/test/ProblemList.txt Tue Nov 22 20:44:56 2016 -0800 @@

RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

Hi All Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/? Bug: https://bugs.openjdk.java.net/browse/JDK-8170192 This patch is fully same as Daniel provided except a few lines of additional cleaning, thanks to Daniel for providing the patch! Thanks Frank

Re: RFR 8170249/9, Problem list jdk/jshell/ToolFormatTest.java and jdk/jshell/ReplaceTest.java until 8170216 is fixed

+1 Thanks, -Joe On 11/22/2016 7:38 PM, Felix Yang wrote: Hi there, please review the change to problem following tests on Soalris Sparcv9. They have been observed to be failing quite frequently on Solaris Sparcv9 Thanks, Felix diff -r 318dd5fce0ee test/ProblemList.txt --- a/test/Pr

RFR 8170249/9, Problem list jdk/jshell/ToolFormatTest.java and jdk/jshell/ReplaceTest.java until 8170216 is fixed

Hi there, please review the change to problem following tests on Soalris Sparcv9. They have been observed to be failing quite frequently on Solaris Sparcv9 Thanks, Felix diff -r 318dd5fce0ee test/ProblemList.txt --- a/test/ProblemList.txt Tue Nov 22 16:31:03 2016 -0800 +++ b/test/P

Re: RFR 8169808 Stream returning methods should specify if they are late binding

PriorityBlockingQueue has a late-binding-style, snapshot spliterator that does not report IMMUTABLE. It *is* immutable ... after the first access! Should we add IMMUTABLE?

Re: RFR 8169808 Stream returning methods should specify if they are late binding

On Tue, Nov 22, 2016 at 4:24 PM, Martin Buchholz wrote: > > > On Mon, Nov 21, 2016 at 1:06 PM, Paul Sandoz > wrote: > >> >> See the SpliteratorLateBindingFailFastTest. That could be refactored out >> as it’s conflating two concepts and is too collection/map focused. > > I took a look at that tes

Re: RFR 8169808 Stream returning methods should specify if they are late binding

On Mon, Nov 21, 2016 at 1:06 PM, Paul Sandoz wrote: > > See the SpliteratorLateBindingFailFastTest. That could be refactored out > as it’s conflating two concepts and is too collection/map focused. > Here's my own attempt, for the pending jsr166 integration: --- src/test/tck/Collection8Test.ja

Re: RFR 9: 8169416: SSLSessionImpl finalize overhead

Looks fine to me. Thanks, Xuelei > On 23 Nov 2016, at 5:41 AM, Roger Riggs wrote: > > Adding security-dev... > > Please review this change to remove an ineffective finalizer for SSLSessions. > The finalizer removes bindings from the SSLSession of a table that is also > freed when the SSLSessio

Re: RFR 8169808 Stream returning methods should specify if they are late binding

> On 22 Nov 2016, at 15:14, Martin Buchholz wrote: > > Hmmm I've finally read the Spliterator spec. I now accept that > late-binding by definition does not apply to CONCURRENT sources. Iteration > is in any case a little weird for concurrent collections, but I think the > fundamental pr

Re: RFR 8169808 Stream returning methods should specify if they are late binding

Hmmm I've finally read the Spliterator spec. I now accept that late-binding by definition does not apply to CONCURRENT sources. Iteration is in any case a little weird for concurrent collections, but I think the fundamental principle, beyond the weak consistency guarantees, is to always retur

Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

Hi Christoph, That looks good to me. Best, Joe On 11/22/16, 1:26 PM, Langer, Christoph wrote: Hi Joe, as my jtreg issues are solved now, I'm finalizing the patches. For this one I've updated the test method: http://cr.openjdk.java.net/~clanger/webrevs/8169772.2/

Re: RFR 9: 8169416: SSLSessionImpl finalize overhead

Hi Roger, I think this looks OK. Brian On Nov 22, 2016, at 1:23 PM, Roger Riggs wrote: > Please review this change to remove an ineffective finalizer for SSLSessions. > The finalizer removes bindings from the SSLSession of a table that is also > freed when the SSLSession is being freed. There

Re: RFR 9: 8169416: SSLSessionImpl finalize overhead

Adding security-dev... Please review this change to remove an ineffective finalizer for SSLSessions. The finalizer removes bindings from the SSLSession of a table that is also freed when the SSLSession is being freed. There is no point in removing them explicitly. It only delays freeing memory

RE: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

Hi Joe, as my jtreg issues are solved now, I'm finalizing the patches. For this one I've updated the test method: http://cr.openjdk.java.net/~clanger/webrevs/8169772.2/ Could you please quickly check if my new test method "testBug8169772()" looks as you want it? I've added some more detailed c

RFR 9: 8169416: SSLSessionImpl finalize overhead

Please review this change to remove an ineffective finalizer for SSLSessions. The finalizer removes bindings from the SSLSession of a table that is also freed when the SSLSession is being freed. There is no point in removing them explicitly. It only delays freeing memory and increases the overhe

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Thanks a lot Volker and Daniel for the big support to analyze and fix this. It seems to me that the proposed fix (http://cr.openjdk.java.net/~dfuchs/webrev_8170192/webrev.00/ ) looks like the best that can be done at the moment. I agree that it would be nicer if jtreg would leave the jtreg lib

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

On Tue, Nov 22, 2016 at 8:08 PM, Joe Wang wrote: > Daniel, you're awesome! This could have potentially been a frustration to > anyone with a newer testng, as Christoph and Volker have experienced. This > issue really needs to be fixed immediately :-) > And Oracle should try to use the same tools

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Daniel, thanks for your patch! I've meanwhile tried to better understand the root cause of the problem. I don't think that the invocation order of the data provider the listener have changed. If you look at the the two version 6.9.5 and 6.9.13 of testng, the org.testng.TestRunner.run() method

Re: RFR 8169808 Stream returning methods should specify if they are late binding

Hi Tagir, Yes, it applies to all implementations. I think the risk of incompatibility is low for 9. Based on analysis on grepcode most CharSequence implementations don’t override the stream returning methods, those few that do defer to some other sequence. Paul. > On 21 Nov 2016, at 19:44, Ta

Re: RFR: 8169631: [JAXP] XALAN: transformation of XML via namespace-unaware SAX input yields a different result than namespace-unaware DOM input

Hi Christoph, Once you're able to run all tests, feel free to push the changeset. Frank has fixed the Smoke test. Thanks, Joe On 11/18/16, 3:37 PM, Joe Wang wrote: Hi Christoph, Thanks for explaining the customer's dilemma with regard to their legacy process. The testcase I sent you was

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Daniel, you're awesome! This could have potentially been a frustration to anyone with a newer testng, as Christoph and Volker have experienced. This issue really needs to be fixed immediately :-) Joe On 11/22/16, 7:58 AM, Daniel Fuchs wrote: On 22/11/16 14:51, Langer, Christoph wrote: In tha

Re: 8072784: Better spliterator implementation for BitSet.stream()

> On 21 Nov 2016, at 20:00, Tagir Valeev wrote: > > Hello! > >> Hi Tagir, >> >> In the original issue i was pondering using SIZED for smaller bit sets and >> non-SIZED for larger bit sets, since we stride over the longs themselves >> when calculating the size (should be intrinsic to count th

Re: [9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

+1 > On Nov 22, 2016, at 8:51 AM, Denis Kononenko > wrote: > > > Hi, > > Could someone please review this small fix. > > Recently several failing test cases were delivered into jdk9-dev by my > mistake (https://bugs.openjdk.java.net/browse/JDK-8167240). I've just renamed > these test case

Re: [9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

Hi, Looks OK to me. —Andrey > On 22 Nov 2016, at 15:51, Denis Kononenko wrote: > > > Hi, > > Could someone please review this small fix. > > Recently several failing test cases were delivered into jdk9-dev by my > mistake (https://bugs.openjdk.java.net/browse/JDK-8167240). I've just rename

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Christoph, I have logged https://bugs.openjdk.java.net/browse/JDK-8170192 best regards, -- daniel On 22/11/16 14:47, Daniel Fuchs wrote: On 22/11/16 14:43, Langer, Christoph wrote: But, as for fixing with the new testng, will you look into this? Shall I open a bug?

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

On 22/11/16 14:51, Langer, Christoph wrote: In that case, if we can't change testng, maybe the jaxp SecurityManager can allow testng to access the declared members without granting this to the testee code? That's what I was prototyping. The patch below seem to fix the issue - but it's a bit u

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

In that case, if we can't change testng, maybe the jaxp SecurityManager can allow testng to access the declared members without granting this to the testee code? > -Original Message- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Sent: Dienstag, 22. November 2016 15:47 > To: Lan

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Daniel, yes - that looks like what we observe, see Volker's mail. It seems to work with testing 6.9.5 but not with 6.9.10 or 6.9.11. So for my jaxp testing I can use 6.9.5, I'm so happy :) But, as for fixing with the new testng, will you look into this? Shall I open a bug? Thanks Christoph

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

On 22/11/16 14:43, Langer, Christoph wrote: But, as for fixing with the new testng, will you look into this? Shall I open a bug? I am unsure on how to fix this actually. The new testng must attempt to load the data provider after having invoked the listener, while the old testng probably did

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Volker, Our emails crossed each others :-) On 22/11/16 14:31, Volker Simonis wrote: @Daniel: can I please kindly ask you to retry your tests with https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/artifact/jtreg-4.2-b03.tar.gz and make sure you are really using that version

Re: RFR JDK-8170170 Problem list ExternalEditorTest.java on all platforms

Hello, Yes, given the failures seen on non-windows platforms too, this test is failing often enough to be universally problem listed. Thanks, -Joe On 11/22/2016 1:03 AM, Frank Yuan wrote: Hi All This is a problem list update in langtools repo: diff -r f4b6b78a1200 test/ProblemList.t

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

On Tue, Nov 22, 2016 at 2:31 PM, Daniel Fuchs wrote: > On 22/11/16 13:01, Langer, Christoph wrote: >> >> Hi, >> >> we are running jtreg with something like -jdk:> directory>/images/jdk. So would that be the exploded version or not? > > > Yes - that's the image. Hmm... The failures I see with the e

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi, The issue seems to be caused by changes in testng - but maybe that needs to be fixed in the JAXP test base. I could reproduce the issue by running the jaxp tests, after unsetting JT_HOME and running with https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/artifact/jtreg-4.2

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

On 22/11/16 13:31, Daniel Fuchs wrote: On 22/11/16 13:01, Langer, Christoph wrote: Hi, we are running jtreg with something like -jdk:/images/jdk. So would that be the exploded version or not? Yes - that's the image. Hmm... The failures I see with the exploded build are different than what you

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

On 22/11/16 13:01, Langer, Christoph wrote: Hi, we are running jtreg with something like -jdk:/images/jdk. So would that be the exploded version or not? Yes - that's the image. Hmm... The failures I see with the exploded build are different than what you have anyway. FWIW: I think all test

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi, we are running jtreg with something like -jdk:/images/jdk. So would that be the exploded version or not? FWIW: I think all test that fail don't have void test methods but the test methods expect input parameters and hence a tag @Test(dataProvider = "...") exists. Can it be that we are usin

[9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

Hi, Could someone please review this small fix. Recently several failing test cases were delivered into jdk9-dev by my mistake (https://bugs.openjdk.java.net/browse/JDK-8167240). I've just renamed these test cases to temporarily avoid their execution. They should be renamed back when approp

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi guys, Are you running the tests with the exploded jdk or with the image? I'm seeing failures with the exploded jdk. That could explain the difference with permission checks. best regards, -- daniel On 22/11/16 12:32, Daniel Fuchs wrote: Hi Volker, On 22/11/16 12:25, Chris Hegarty wrote

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Volker, On 22/11/16 12:25, Chris Hegarty wrote: Volker, Just to add, jtreg has support in its tags to start the test VM with a security manager and a specified policy. In the case of the test failure you are seeing, the built-in jtreg support is not being used. Instead, the test is executing

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Volker, Just to add, jtreg has support in its tags to start the test VM with a security manager and a specified policy. In the case of the test failure you are seeing, the built-in jtreg support is not being used. Instead, the test is executing with a test-specific system property that is being u

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Daniel, thanks for your support - this problem really drives us crazy! What version of jtreg are you using? If you are using a central one which was configured and build by Oracle, could you please also try with the one from https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Daniel, I checked your suggestion with the paths and moved my jtreg to a local disk - but nothing changed. I don't see any policy that is being manipulated. I found out, by adding some debug printing code, that inside jtreg, the addGrantEntry() method is not called at all... Is some policy

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Christoph, Is there anything funny with the place jtreg is installed? like: - path contains whitespaces - path is accessible through links or mount points... It seems clear that the issue here is that testng classes are missing some permissions, so I was wondering whether that could be ca

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Yes, please find it here: http://cr.openjdk.java.net/~clanger/jtreg/XSLTFunctionsTest.jtr > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Dienstag, 22. November 2016 11:03 > To: Langer, Christoph > Cc: core-libs-dev@openjdk.java.net; code-tools-...@o

Re: JDK 9 RFR of JDK-8170158: Remove ClassLoader/platformClassLoader/DefinePlatformClass.java from ProblemList

Looks good Amy! best regards, -- daniel On 22/11/16 03:26, Amy Lu wrote: Please review the patch to bring back java/lang/ClassLoader/platformClassLoader/DefinePlatformClass.java It's clear now that the reported failure was caused by machine wrong time setting. bug: https://bugs.openjdk.java.

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

> On 22 Nov 2016, at 09:43, Langer, Christoph wrote: > > Hi Chris, > > thanks for this hint. However, we've already seen this change and rebuilt > jtreg with the latest jtreg repo. But it doesn't change a thing. > > Also, the download from > https://adopt-openjdk.ci.cloudbees.com/job/jtreg/l

RE: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Chris, thanks for this hint. However, we've already seen this change and rebuilt jtreg with the latest jtreg repo. But it doesn't change a thing. Also, the download from https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/artifact/ where I would suppose latest jtreg sources

RFR: JDK-8075577: java.time does not support HOST provider

Hi, Please review fix for JDK-8075577. Bug : https://bugs.openjdk.java.net/browse/JDK-8075577 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.01/ Fix is to introduce new private spi "sun.text.spi.JavaTimeDateTimePatternProvider.java" to retrieve LocaleProvider specific Date/Ti

Re: RFR of JDK-8153543: java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java fails intermittently

> On 22 Nov 2016, at 02:50, Hamlin Li wrote: > > Would you please review the patch for below bug? > > bug: https://bugs.openjdk.java.net/browse/JDK-8153543 > webrev: http://cr.openjdk.java.net/~mli/8153543/webrev.00/ Looks fine Hamlin. -Chris. > Root cause: between "TestLibrary.getUnusedRand

Re: Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi Christoph, Can you please ensure that your build of jtreg contains the fix for 7901792 [1]. 7901792 grants /lib/testng.jar all permissions. -Chris. [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7901792 > On 22 Nov 2016, at 08:38, Langer, Christoph wrote: > > Hi, > > I'm currently str

RFR JDK-8170170 Problem list ExternalEditorTest.java on all platforms

Hi All This is a problem list update in langtools repo: diff -r f4b6b78a1200 test/ProblemList.txt --- a/test/ProblemList.txt Mon Nov 21 12:28:56 2016 -0800 +++ b/test/ProblemList.txt Tue Nov 22 16:34:24 2016 +0800 @@ -38,7 +38,7 @@ jdk/jshell/EditorPadTest.java

Issues running JAXP jtreg tests ("java.lang.RuntimePermission" "accessDeclaredMembers")

Hi, I'm currently struggling while running jtreg tests for the jaxp depot. There are several tests that fail with the same symptom. I always get exceptions like: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "accessDeclaredMembers") at java.base/jav