Re: RFR: JDK-8172432,jar cleanup/update for module and mrm jar

On 1/10/17, 9:14 PM, Mandy Chung wrote: I agree that you can depend on the validation done by ModuleDescriptor::read as long as the jar tool reports the error message gracefully (probably catch InvalidModuleDescriptorException and output the error). It’d be good to add a comment to describe

Re: RFR: JDK-8172432,jar cleanup/update for module and mrm jar

> On Jan 10, 2017, at 5:03 PM, Xueming Shen wrote: > Hi Mandy, > > I spent some time today for JDK-8171830. > > http://cr.openjdk.java.net/~sherman/8172432/webrev2/src/jdk.jartool/share/classes/sun/tools/jar/Main.java.sdiff.html > >

Re: RFR: 8166365: Small immutable collections should provide optimized implementations when possible

On 1/10/17 3:50 AM, Claes Redestad wrote: please review this change to improve startup/warmup characteristics and performance of the immutable collection factories: Bug: https://bugs.openjdk.java.net/browse/JDK-8166365 Webrev: http://cr.openjdk.java.net/~redestad/8166365/webrev.01/ While filed

Re: jdk.internal.reflect.ReflectionFactory and SecurityManager

I am concerned it’s getting too late to twiddle with the security setting so i took the plunge and wrapped the privateLookupIn calls in doPrivileged blocks. It’s ugly but avoids the circularity (JPRT core/hotspot testing has not failed). http://cr.openjdk.java.net/~psandoz/jdk9/8160710-thread-to

Re: RFR: JDK-8172432,jar cleanup/update for module and mrm jar

On 1/9/17, 3:46 PM, Mandy Chung wrote: On Jan 9, 2017, at 10:21 AM, Xueming Shen > wrote: Hi, Please review the following proposed changes for jar tool issue: https://bugs.openjdk.java.net/browse/JDK-8172432 webrev: http://cr.openjdk.java.net/~sherman/8172432/

[9] RFR: 8171139: Simplify ResourceBundle.CacheKey and ClassLoader may not be needed

Hello, Please review the changes to the subject issue: https://bugs.openjdk.java.net/browse/JDK-8171139 The changes are located at: http://cr.openjdk.java.net/~naoto/8171139/webrev.00/ The changeset is the same as the one in the mail thread [1] contributed by Peter Levart, plus additional cle

Re: RFR (JAXP) 8171243 : CatalogManager.catalogResolver throws FileSystemNotFoundException with jar

On 1/9/2017 2:17 PM, Roger Riggs wrote: Hi Joe, a few comments: CatalogManager: - line 58: "will /return /as no mapping is found"; Or is it describing the behavior of the CatalogResolver (which is throw a CatalogException)? (possible more than 1 place) While waiting for spec approva

Re: RFR(s): 8171958: Several tests from java/time/test/java/time/format requiring jdk.localedata for execution

Looks good to me. Naoto On 1/10/17 2:26 AM, Sergei Kovalev wrote: Hi Naoto, Thank you for review. I looked throw sources mode carefully and found some inconsistency you mentioned. I cleaned out all possible dependencies on jdk.localedata. Probably previously the cases passed because they doing

Re: JDK 9 RFR of 8153250: java.io.File does not handle Windows paths of the form "D:" (no path) correctly

Hi Brian, Looks good. Roger On 1/9/2017 8:09 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8153250 Patch: http://cr.openjdk.java.net/~bpb/8153250/webrev.00/ On Windows only, when resolving a child path against a parent, do n

Re: RFR 8075884, new tests to check runtime usage with Multi-Release jars

> On 10 Jan 2017, at 08:36, Felix Yang wrote: > > Hi Paul, > thanks for the comments. Please review the updated patch. About JJS > testing, I’m not really aware of Nashorn codes but just help to implement the > designed one. Andrey may comment more. In my opinion, it looks to be a > reas

Re: RFR: 8166365: Small immutable collections should provide optimized implementations when possible

Hi, Cleary i should be more careful reviewing while eating my breakfast. > On 10 Jan 2017, at 09:00, Claes Redestad wrote: > > Hi Paul, > > On 2017-01-10 17:32, Paul Sandoz wrote: >> Hi, >> >> ImmutableCollections >> — >> >> Did you forget or intentionally omit overriding the hashCode for L

Re: RFR: 8166365: Small immutable collections should provide optimized implementations when possible

Hi Paul, On 2017-01-10 17:32, Paul Sandoz wrote: Hi, ImmutableCollections — Did you forget or intentionally omit overriding the hashCode for List2 and ListN? Intentionally omitted: since List2 and ListN have O(1) get performance, the Iterator provided by AbstractList seems good enough for n

Re: RFR: JDK-8172432,jar cleanup/update for module and mrm jar

> On 10 Jan 2017, at 08:25, Xueming Shen wrote: > > On 1/9/17, 5:39 PM, Mandy Chung wrote: >>> On Jan 9, 2017, at 5:28 PM, Xueming Shen >>> wrote: >>> >>> >>> http://cr.openjdk.java.net/~sherman/8172432/webrev/ >>> >>> >>> the method has been updated as Paul suggested, to only take the roo

Re: RFR: JDK-8172432,jar cleanup/update for module and mrm jar

> On Jan 10, 2017, at 12:25 AM, Xueming Shen wrote: > > On 1/9/17, 5:39 PM, Mandy Chung wrote: >> >>> On Jan 9, 2017, at 5:28 PM, Xueming Shen >>> wrote: >>> >>> http://cr.openjdk.java.net/~sherman/8172432/webrev/ >>>

Re: RFR: JDK-8172432,jar cleanup/update for module and mrm jar

> On 10 Jan 2017, at 00:25, Xueming Shen wrote: > > On 1/9/17, 5:39 PM, Mandy Chung wrote: >> >>> On Jan 9, 2017, at 5:28 PM, Xueming Shen >>> wrote: >>> >>> http://cr.openjdk.java.net/~sherman/8172432/webrev/ >>>

Re: RFR 8075884, new tests to check runtime usage with Multi-Release jars

Hi Paul, thanks for the comments. Please review the updated patch. About JJS testing, I’m not really aware of Nashorn codes but just help to implement the designed one. Andrey may comment more. In my opinion, it looks to be a reasonable use case from functional aspect. Webrev: http://cr.op

Re: RFR: 8166365: Small immutable collections should provide optimized implementations when possible

Hi, ImmutableCollections — Did you forget or intentionally omit overriding the hashCode for List2 and ListN? 481 @Override 482 public int hashCode() { 483 int h = 0; 484 for (E e : elements) { 485 if (e != null) { 486

Re: jdk.internal.reflect.ReflectionFactory and SecurityManager

On 09/01/2017 19:09, Paul Sandoz wrote: On 9 Jan 2017, at 05:36, Alan Bateman wrote: On 05/01/2017 19:01, Paul Sandoz wrote: Hi, I encountered some circularity issues with security manager and VarHandles, specifically when attempting to use the new MethodHandles.privateLookupIn, so say T

Re: RFR (JAXP) 8146271: File system contention in debug print via XPathFactory.newInstance

Hi Aleks, Sorry for not responding but what I tried to say is that with your code you are still creating a instance of Supplier which could be avoided by changing the code to use a BiFunction Take "src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/ObjectFactory.java" as a example

RFR: 8166365: Small immutable collections should provide optimized implementations when possible

Hi, please review this change to improve startup/warmup characteristics and performance of the immutable collection factories: Bug: https://bugs.openjdk.java.net/browse/JDK-8166365 Webrev: http://cr.openjdk.java.net/~redestad/8166365/webrev.01/ While filed as an RFE, and a more thorough examina

Re: RFR(s): 8171958: Several tests from java/time/test/java/time/format requiring jdk.localedata for execution

Hi Naoto, Thank you for review. I looked throw sources mode carefully and found some inconsistency you mentioned. I cleaned out all possible dependencies on jdk.localedata. Probably previously the cases passed because they doing only number formatting. However I agree that it meaningful to co

Re: [9] RFR: 8159058: SAXParseException when sending soap message

Hi Lance, Thank you for the review. Correct, standalone team did a testing of this fix on their side. I also executed all JAXWS/B related tests from JCK9 runtime/devtools suites - no related issues were detected. Best Regards, Aleksej On 09/01/17 20:23, Lance Andersen wrote: Hi Aleks, The

Re: RFR: JDK-8172432,jar cleanup/update for module and mrm jar

On 1/9/17, 5:39 PM, Mandy Chung wrote: On Jan 9, 2017, at 5:28 PM, Xueming Shen wrote: http://cr.openjdk.java.net/~sherman/8172432/webrev/ the method has been updated as Paul suggested, to only take the root module-info.class and correct versioned meta-inf/versions/n/module-info.class Does