Re: RFR: JDK-8049375 - Extend how the org.omg.CORBA.ORB handles the search for orb.properties

On 06/02/2017 21:20, Mark Sheppard wrote: Hi, please oblige and review the following changes to the corba component http://cr.openjdk.java.net/~msheppar/8049375/corba/webrev/ http://cr.openjdk.java.net/~msheppar/8049375/test/webrev/ which address the issue https://bugs.openjdk.java.net/bro

Re: ByteBuffer to CharBuffer

Looping in nio-dev which, as Pavel noted, is the apt forum for this topic. Jonas’s response is correct. The concept of “view buffer” is specified by [1]. In particular the statement "A view buffer is simply another buffer whose content is backed by the byte buffer." at least to my interpretati

Re: RFR: JDK-8049375 - Extend how the org.omg.CORBA.ORB handles the search for orb.properties

Hi Mark, The change and test looks reasonable. I might consider removing the “TODO” comments from your test cases prior to pushing. Maybe it is not needed, but should the test also be run with a SecurityManager or did you feel that was not needed? HTH Best Lance > On Feb 6, 2017, at 4:20 PM,

RFR: JDK-8049375 - Extend how the org.omg.CORBA.ORB handles the search for orb.properties

Hi, please oblige and review the following changes to the corba component http://cr.openjdk.java.net/~msheppar/8049375/corba/webrev/ http://cr.openjdk.java.net/~msheppar/8049375/test/webrev/ which address the issue https://bugs.openjdk.java.net/browse/JDK-8049375 the JDK9 rt image has chang

Re: RFR JDK-8173777: Merge javac -Xmodule into javac--patch-module

On 06/02/2017 18:41, Jan Lahoda wrote: I've updated the jdk repository webrev to wrap long lines: http://cr.openjdk.java.net/~jlahoda/8173777/jdk.01/ Jan This looks okay to me. -Alan

Re: RFR 8169313: SecurityException, java.xml.ws not granted NetPermission("getProxySelector")

Looks okay. We would need more tests to exercise the code paths triggering permission checks and it’d be appropriate to add in the test suites of the upstream projects. Mandy > On Feb 6, 2017, at 10:55 AM, Lance Andersen wrote: > > Hi all, > > Attached is the change to address 8169313 > >

Re: RFR 8169313: SecurityException, java.xml.ws not granted NetPermission("getProxySelector")

Hi Lance, Looks good to me (not a reviewer). It's good to have it as default policy. Best Regards, Aleksej On 06/02/17 21:55, Lance Andersen wrote: Hi all, Attached is the change to address 8169313 hg diff diff -r 19aaaf6ee13e src/java.base/share/lib/security/default.policy --- a/src/ja

RFR 8169313: SecurityException, java.xml.ws not granted NetPermission("getProxySelector")

Hi all, Attached is the change to address 8169313 hg diff diff -r 19aaaf6ee13e src/java.base/share/lib/security/default.policy --- a/src/java.base/share/lib/security/default.policy Sat Feb 04 14:04:28 2017 -0500 +++ b/src/java.base/share/lib/security/default.policy Mon Feb 06 12:07:39

Re: RFR JDK-8173777: Merge javac -Xmodule into javac--patch-module

I've updated the jdk repository webrev to wrap long lines: http://cr.openjdk.java.net/~jlahoda/8173777/jdk.01/ Jan On 6.2.2017 16:53, Jan Lahoda wrote: Hi, I'd like to ask for a review of a patch that merges the -Xmodule: functionality into --patch-module. After this patch, the input source fi

Re: RFR: 8173943: Change error reporting of LauncherHelper to include actual Error class name

+1 Kumar On 2/5/2017 11:14 AM, Ramanand Patil wrote: Hi all, Please review the following trivial bug fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8173943 Webrev: http://cr.openjdk.java.net/~rpatil/8173943/webrev.00/ LinkageError message added by - https://bugs.openjdk.java.net/browse/JD

RFR JDK-8173777: Merge javac -Xmodule into javac--patch-module

Hi, I'd like to ask for a review of a patch that merges the -Xmodule: functionality into --patch-module. After this patch, the input source files are matched against modules patched with --patch-module, and are compiled as-if they were part of the module they are patching. (In the multi-modul

Re: ByteBuffer to CharBuffer

From what I can tell, asCharBuffer behaves exactly like the other as*Buffer methods, meaning every char in the CharBuffer is represented by two bytes in the original ByteBuffer (big- or little-endian depending on ByteOrder of the ByteBuffer). This means bb.asCharBuffer().get() behaves like bb.g

Re: ByteBuffer to CharBuffer

Hi Jay, 1. I don't know if you've forgotten to attach the patch you mentioned or it has been stripped by the mail list. In any case, if it's not too big, please inline it in your next email. 2. A more appropriate place for this discussion would be another list: nio-dev at openjdk dot java d

ByteBuffer to CharBuffer

java.nio.ByteBuffer provides a method asCharBuffer() which returns a "view" of the ByteBuffer as a character buffer. It however does not take any arguments. And there is no mention in the Javadocs as to how it converts from bytes to chars. 1. There should be a method ByteBuffer.asCharBuffer(CharSe

Re: RFR: 8173943: Change error reporting of LauncherHelper to include actual Error class name

On 06/02/2017 03:22, Ramanand Patil wrote: : 2. After Fixing JDK-8167063: Error: Unable to load main class pkgB.ClassB from module mod.b superclass access check failed: class pkgB.ClassB (in module mod.b) cannot access class pkgA.ClassA (in module mod.a) because module mod.a does not export

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

(cc'ing jigsaw-dev as that is where the jimage tool is maintained). On 06/02/2017 10:27, Denis Kononenko wrote: Hi, Could someone please review this very small fix. The class JImageTask (src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java) has references to an info message by 'err.c

[9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, Could someone please review this very small fix. The class JImageTask (src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java) has references to an info message by 'err.cannot.create.dir' key. Unfortunately the corresponding resource file (src/jdk.jlink/share/classes/jdk/tools/jima

RE: Ping: [JAXP] RFR: 8173602: TESTBUG: javax/xml/jaxp/unittest/transform/TransformerTest.java needs refactoring

Thanks, Daniel. I pushed it: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/e930c373aaa4 > -Original Message- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Sent: Freitag, 3. Februar 2017 14:56 > To: Langer, Christoph > Cc: core-libs-dev@openjdk.java.net > Subject: Re: Ping: [JAX