RE: RFR - Update: 8168664 [JAXP] XALAN: xsl:element generates namespace prefixes if namespace is given as URI only

Hi Joe, welcome back. :) This sounds reasonable. I'll prepare a change for JDK10. Thanks Christoph From: Joe Wang [mailto:huizhe.w...@oracle.com] Sent: Mittwoch, 8. Februar 2017 01:39 To: Langer, Christoph Cc: core-libs-dev@openjdk.java.net; Aleksej Efimov

Re: Review Request: JDK-8173712: Rename JAVA_OPTIONS environment variable to JDK_JAVA_OPTIONS

On 07/02/2017 21:16, Mandy Chung wrote: Henry, Kumar, Can you please review this patch: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173712/webrev.00/ JAVA_OPTIONS was introduced by JDK-8170832 but it turns out that environment variable name conflicts with existing uses. It might not

Re: Update: RFR 8172974 [JAXP] XALAN: Wrong result when transforming namespace unaware StAX Input

Hi Christoph, We'll double-check whether there's any performance implications. Please give us a couple of (or few) days. Thanks, Joe On 1/30/17, 7:28 AM, Langer, Christoph wrote: Hi Joe, I've updated my webrev for 8172974 after pulling out the refactoring of

Re: RFR - Update: 8168664 [JAXP] XALAN: xsl:element generates namespace prefixes if namespace is given as URI only

Hi Christoph, As we discussed, let's target this for JDK 10 as a spec change at this stage for JDK 9 is too late. Removing the namespace generation would be another reason to do this in JDK 10 since then, we wouldn't need the additional property. Thanks, Joe On 1/31/17, 11:02 AM, Langer,

Re: RFR: JDK-8049375 - Extend how the org.omg.CORBA.ORB handles the search for orb.properties

webrev has been updated as per feedback and suggestions: http://cr.openjdk.java.net/~msheppar/8049375/test/webrev.02/ http://cr.openjdk.java.net/~msheppar/8049375/corba/webrev.02/ regards Mark On 07/02/2017 12:12, Mark Sheppard wrote: thanks Lance for the feedback TODO auto-generated in

Re: Review Request: JDK-8173712: Rename JAVA_OPTIONS environment variable to JDK_JAVA_OPTIONS

+1. Cheers, Henry > On Feb 7, 2017, at 1:16 PM, Mandy Chung wrote: > > Henry, Kumar, > > Can you please review this patch: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173712/webrev.00/ > > JAVA_OPTIONS was introduced by JDK-8170832 but it turns out that >

Re: Review Request: JDK-8173712: Rename JAVA_OPTIONS environment variable to JDK_JAVA_OPTIONS

> On 7 Feb 2017, at 13:16, Mandy Chung wrote: > > Henry, Kumar, > > Can you please review this patch: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173712/webrev.00/ > > JAVA_OPTIONS was introduced by JDK-8170832 but it turns out that > environment variable name

Review Request: JDK-8173712: Rename JAVA_OPTIONS environment variable to JDK_JAVA_OPTIONS

Henry, Kumar, Can you please review this patch: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173712/webrev.00/ JAVA_OPTIONS was introduced by JDK-8170832 but it turns out that environment variable name conflicts with existing uses. It might not be uncommon for scripts to set

RE: RFR: 8173943: Change error reporting of LauncherHelper to include actual Error class name

Thank you Alan and Kumar. I have just pushed the fix. Regards, Ramanand. -Original Message- From: Kumar Srinivasan Sent: Monday, February 06, 2017 9:54 PM To: Ramanand Patil Cc: core-libs-dev Subject: Re: RFR: 8173943: Change

Re: 8057795: Update of the mimestypes.default for JAF

Thank you Bill, I will push as is then. Best Lance > On Feb 7, 2017, at 3:17 PM, Bill Shannon wrote: > > The list of possible MIME type mappings is endless and it's not worth the > effort to try to keep up. This one change just keeps the JDK in sync with > the

Re: JDK 9: 8174128: [testbug] Remove implementation dependency from java.time TCK tests

+1 Stephen On 7 February 2017 at 20:06, Roger Riggs wrote: > Please review minor changes to the java.time.tck tests to avoid the use of > implementation details and the related opening of the modules. > The testng directive to open needed modules is now specific to the >

Re: RFR JDK-8173777: Merge javac -Xmodule into javac--patch-module

> On Feb 7, 2017, at 10:11 AM, Jan Lahoda wrote: > > Updated webrevs: > -langtools repository: > http://cr.openjdk.java.net/~jlahoda/8173777/langtools.01/ test/tools/jdeps/jdkinternals/RemovedJDKInternals.java change looks okay to me. > -jdk repository: >

Re: 8057795: Update of the mimestypes.default for JAF

The list of possible MIME type mappings is endless and it's not worth the effort to try to keep up. This one change just keeps the JDK in sync with the standalone version. Lance Andersen wrote on 02/ 7/17 12:01 PM: > Hi Brian, > > Thank you for the quick review. > > I will defer to Bill on

JDK 9: 8174128: [testbug] Remove implementation dependency from java.time TCK tests

Please review minor changes to the java.time.tck tests to avoid the use of implementation details and the related opening of the modules. The testng directive to open needed modules is now specific to the java.time.test... tests. Webrev:

Re: RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

> On Feb 7, 2017, at 5:10 AM, Daniel Fuchs wrote: > > Hi Mandy, > > On 06/02/17 00:16, Mandy Chung wrote: >> Hi Daniel, >> >> Thanks for the patch and uncover that Constructor::newInstance is not >> covered by SHOW_REFLECT_FRAMES. >> >> The change looks okay. The

Re: 8057795: Update of the mimestypes.default for JAF

Hi Brian, Thank you for the quick review. I will defer to Bill on whether anything else should be added as it should be included in the standalone JAF RI as well. Bill, let us know. :-) Best Lance > On Feb 7, 2017, at 2:56 PM, Brian Burkhalter > wrote: > > Hi

Re: 8057795: Update of the mimestypes.default for JAF

Hi Lance, +1 Good thing especially given that PNG is now two decades old. ;-) Are there other now-common media types which should also be added, e.g., anything that QuickTime, WMP, VideoLAN, iTunes, Preview, etc. would typically handle? See, e.g.,

8057795: Update of the mimestypes.default for JAF

Hi all, Attached is the diff to update the mimetypes.default for JAF. The standalone standalone JAF was updated with support for .png files some time ago. ——— hg diff diff -r 7c829eba7814 src/java.activation/share/classes/META-INF/mimetypes.default ---

Re: RFR JDK-8173777: Merge javac -Xmodule into javac--patch-module

Hi, Thanks. I did two small updates to the patches: -for langtools repository, I added unwrapping to ClientCodeWrapper.WrappedJavaFileManager.getLocationForModule - the incoming JavaFileObject is unwrapped, so that we don't pass our wrappers to the client's code. Direct link:

Re: RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

Hi Mandy, On 06/02/17 00:16, Mandy Chung wrote: Hi Daniel, Thanks for the patch and uncover that Constructor::newInstance is not covered by SHOW_REFLECT_FRAMES. The change looks okay. The javadoc of SHOW_REFLECT_FRAMES can be clarified to include Constructor::newInstance. As for the test,

Re: RFR: JDK-8049375 - Extend how the org.omg.CORBA.ORB handles the search for orb.properties

thanks Lance for the feedback TODO auto-generated in eclipse, I'll delete them yes, for completeness it would do no harm to add a test run with Security Manager regards Mark On 06/02/2017 23:47, Lance Andersen wrote: Hi Mark, The change and test looks reasonable. I might consider

Re: RFR: JDK-8049375 - Extend how the org.omg.CORBA.ORB handles the search for orb.properties

thanks Alan yes, good spot, I lost the L114 change somewhere between the CCC and my development environment! I'll add that in regards Mark On 07/02/2017 07:04, Alan Bateman wrote: On 06/02/2017 21:20, Mark Sheppard wrote: Hi, please oblige and review the following changes to the

Re: ByteBuffer to CharBuffer

As a view of the underlying contents, I guess it is correct that no encoding is applied to coerce a ByteBuffer into a CharBuffer. Maybe the javadoc for ByteBuffer.asCharBuffer() can emphasize this point. It is a bit confusing that most places in the JDK where bytes are converted to chars, a