Re: RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

2017-03-08 Thread Mandy Chung
> On Mar 8, 2017, at 5:21 PM, Alexandre (Shura) Iline > wrote: >> Also specifying the target explicitly makes the test clearer what it does. >> >> .addExports(“java.base/jdk.internal.reflect”, “ALL-UNNAMED”) > > Makes sense. > > I hope though that you are not against having a constant for “AL

Re: RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

2017-03-08 Thread Alexandre (Shura) Iline
Thank you, Mandy! Comments inline. > On Mar 6, 2017, at 6:00 PM, Mandy Chung wrote: > > >> On Mar 6, 2017, at 5:27 PM, Alexandre (Shura) Iline >> wrote: >> >> Hi, >> >> Could you please review the suggested fox for: >> https://bugs.openjdk.java.net/browse/JDK-8159523 >> >> There has been

Re: Is @deprecated javadoc comment still useful?

2017-03-08 Thread Weijun Wang
Hi Stuart This issue may be moot since this example (sun.security.tools.policytool.PolicyTool) is in a private package. I don't know if we deliver the javadoc output for this package. If not, then it doesn't really matter what you write for the @deprecated javadoc tag, or if you omit it entirel

Re: Is @deprecated javadoc comment still useful?

2017-03-08 Thread Stuart Marks
On 3/8/17 2:38 AM, Weijun Wang wrote: The class page has: *Deprecated, for removal: This API element is subject to removal in a future version.* The policytool tool has been deprecated and is planned to be removed in a future release. Usually, the annotation @Deprecated says that the class/m

Re: 9 RFR of JDK-8176337: Mark several tests as intermittently failing

2017-03-08 Thread Xuelei Fan
> sun/security/tools/keytool/DefaultSignatureAlgorithm.java > javax/net/ssl/DTLS/CipherSuite.java The above two updates look fine to me. Thanks, Xuelei On 3/7/2017 7:36 PM, Hamlin Li wrote: Would you please review below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176337 webrev: http

Re: RFR 8176195/9, Fix misc module dependencies in jdk_core tests

2017-03-08 Thread Mandy Chung
> On Mar 7, 2017, at 9:44 PM, Felix Yang wrote: > > Hi there, > > please review the changes to explicitly declare dependencies in tests. This > will make better test selection with --limit-module option. > > Bug: > >https://bugs.openjdk.java.net/browse/JDK-8176195 > > Webrev: > >

Re: Review Request JDK-8175797: (ref) Reference::enqueue method should clear referent before enqueuing

2017-03-08 Thread mark . reinhold
Looks good to me. Thanks for coming up with such a narrow fix for this hairy problem! - Mark

Re: Review Request JDK-8175797: (ref) Reference::enqueue method should clear referent before enqueuing

2017-03-08 Thread Mandy Chung
> On Mar 8, 2017, at 6:52 AM, Alan Bateman wrote: > > On 07/03/2017 15:35, Mandy Chung wrote: > >> This proposes to update Reference::enqueue method to clear this reference >> object before enqueuing it to the registered queue consistent with what >> the garbage collector does that clears the r

Re: Review Request JDK-8175797: (ref) Reference::enqueue method should clear referent before enqueuing

2017-03-08 Thread Alan Bateman
On 07/03/2017 15:35, Mandy Chung wrote: This proposes to update Reference::enqueue method to clear this reference object before enqueuing it to the registered queue consistent with what the garbage collector does that clears the reference object before putting it in the pending queue for enqueui

Re: 9 RFR of JDK-8176337: Mark several tests as intermittently failing

2017-03-08 Thread Alan Bateman
On 08/03/2017 03:36, Hamlin Li wrote: Would you please review below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176337 webrev: http://cr.openjdk.java.net/~mli/8176337/webrev.00/ These tests are failing intermittently, they should be marked accordingly with @key intermittent

Re: Is @deprecated javadoc comment still useful?

2017-03-08 Thread Weijun Wang
Hi Remi On 03/08/2017 06:10 PM, Remi Forax wrote: attachments are skipped by the mailer daemon :( That's bad. The module page has: *Deprecated, for removal: This API element is subject to removal in a future version.* The policytool tool has been deprecated and is planned to be removed in

Re: Is @deprecated javadoc comment still useful?

2017-03-08 Thread Remi Forax
Mail original - > De: "Weijun Wang" > À: "Stuart Marks" > Cc: "Java Core Libs" > Envoyé: Mercredi 8 Mars 2017 01:15:10 > Objet: Is @deprecated javadoc comment still useful? > Hi, Mr Deprecator I'm not Dr Deprecator :) > > I'm adding @Deprecated annotations with arguments to a module