JDK 9 RFR(s): 8173152: Wrong wording in Comparator.compare() method spec

Hi all, Please review this small javadoc fix to correct the wording in Comparator.compare(). There's a sentence defining the sgn() notation, that says "In the foregoing description" but it occurs *before* the actual use of sgn(). I've moved this to the end of the method spec. This also

Re: [8u] RFR: 8177776: Create an equivalent test case for JDK9's SupplementalJapaneseEraTest

Hi Brent, thank you for the review. On 4/6/17 1:08 PM, Brent Christian wrote: Hi, Naoto On 4/5/17 2:14 PM, Naoto Sato wrote: I revised the test case not to rely on shell script. Yay! Hopefully this can also happen sometime for JDK 9+. Sure. Will work on it.

Re: [8u] RFR: 8177776: Create an equivalent test case for JDK9's SupplementalJapaneseEraTest

Hi, Naoto On 4/5/17 2:14 PM, Naoto Sato wrote: I revised the test case not to rely on shell script. Yay! Hopefully this can also happen sometime for JDK 9+. http://cr.openjdk.java.net/~naoto/816/webrev.01/ Looks fine to me, Naoto. A few comments: * I presume additional @bug values

Re: [8u] RFR: 8177776: Create an equivalent test case for JDK9's SupplementalJapaneseEraTest

Thanks for reviewing, Roger. On 4/6/17 8:39 AM, Roger Riggs wrote: Hi Naoto, Thanks for replacing the shell script with Java code. Given the size of the JDK, I'd suggest removing the copy at the end of the test unless you can rely on jtreg to remove it promptly. I was thinking about using

Re: [8u] RFR: 8177776: Create an equivalent test case for JDK9's SupplementalJapaneseEraTest

Hi Naoto, Thanks for replacing the shell script with Java code. Given the size of the JDK, I'd suggest removing the copy at the end of the test unless you can rely on jtreg to remove it promptly. The rest looks fine, Roger On 4/5/2017 5:14 PM, Naoto Sato wrote: I revised the test case

Re: [PATCH] 8178117: Add public state constructors for Int/Long/DoubleSummaryStatistics

# HG changeset patch # User chris_dennis # Date 1491485015 14400 # Thu Apr 06 09:23:35 2017 -0400 # Node ID d789970b8393032457885e739d76919f714bbd50 # Parent c0aecf84349c97f4241eab01f7bbfb7660d51be1 8178117: Add public state constructors for Int/Long/DoubleSummaryStatistics diff --git

Re: RFR 9: 8165641 : Deprecate Object.finalize

Thanks Mandy, I'll put you down as a reviewer for the fix. (8165641 was pushed) diff --git a/src/java.base/share/classes/java/lang/Object.java b/src/java.base/share/classes/java/lang/Object.java --- a/src/java.base/share/classes/java/lang/Object.java +++

Re: RFR 9: 8165641 : Deprecate Object.finalize

+1 Mandy > On Apr 6, 2017, at 7:44 AM, Roger Riggs wrote: > > Thanks Mandy, I'll put you down as a reviewer for the fix. (8165641 was > pushed) > > > diff --git a/src/java.base/share/classes/java/lang/Object.java >

Re: [PATCH] 8178117: Add public state constructors for Int/Long/DoubleSummaryStatistics

Hi Chris, Unfortunately the patch you sent (in what I presume was an attachment) is missing. I believe the OpenJDK mailing list servers intentionally strip out attachments in all emails, which seems to be at odds with the advice given in http://openjdk.java.net/contribute/. (Either the

[PATCH] 8178117: Add public state constructors for Int/Long/DoubleSummaryStatistics

Hi Paul (et al) Like all things API there are wrinkles here when it comes to implementing. This patch isn’t final, there appears to be no existing test coverage for these classes beyond testing the compensating summation used in the double implementation, and I left off adding any until it was

Re: 9 RFR: 8178139: Minor typo in API documentation of java.util.logging.Logger

On 06/04/2017 12:02, Lance Andersen wrote: looks fine Daniel Thanks Lance. Pushed. -- daniel On Apr 6, 2017, at 7:00 AM, Daniel Fuchs > wrote: Hi, Please find below a trivial change to fix 8178139: Minor typo in API documentation of

RE: JDK 9 RFR(s): 8150488: add note to Scanner.findAll()regardingpossible infinite streams

IMHO there should be a notice added in findAll which excludes the behavior of the stream after an empty match from any compatibility requirements while the notice remains in place. This would be to ensure that findAll and the stream it returns can be changed independently from the other methods

Re: 9 RFR: 8178139: Minor typo in API documentation of java.util.logging.Logger

looks fine Daniel > On Apr 6, 2017, at 7:00 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a trivial change to fix > 8178139: Minor typo in API documentation of java.util.logging.Logger > https://bugs.openjdk.java.net/browse/JDK-8178139 > > will configured =>

9 RFR: 8178139: Minor typo in API documentation of java.util.logging.Logger

Hi, Please find below a trivial change to fix 8178139: Minor typo in API documentation of java.util.logging.Logger https://bugs.openjdk.java.net/browse/JDK-8178139 will configured => will be configured (appears twice) This is a minor typo doc fix so AFAIU RDP2 approval is not needed.

Re: JDK 10 RFR of 8176894: Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute in TreeMap

Hi Sergey, this looks good to me*, but I can't help wonder if the modCount checking is something that should be done separately as a bug fix (with a higher priority) and be backported to 8 and 9? Alternatively re-categorize this fix as such. Thanks! /Claes * I wouldn't mind seeing the