Re: [9] RFR 8177969: Faster FilePermission::implies by avoiding the use of Path::relativize

Webrev updated at http://cr.openjdk.java.net/~weijun/8177969/webrev.02/ Changes since webrev.01: 1. Comments. 2. Another enhancement when I am writing comments. Since we can be sure that a path has no ".." by only looking at its head, we can also be sure that a path is all ".." by only loo

Re: JDK 9 RFR(s): 8150488: add note to Scanner.findAll()regardingpossible infinite streams

On 4/6/17 6:38 AM, Timo Kinnunen wrote: IMHO there should be a notice added in findAll which excludes the behavior of the stream after an empty match from any compatibility requirements while the notice remains in place. This would be to ensure that findAll and the stream it returns can be change

Re: RFR: 8178130: Minor update to the Connection javadocs

Looks good! Brian On Apr 7, 2017, at 3:45 PM, Lance Andersen wrote: > Thank you for your input. Here is the revised version:

Re: RFR: 8178130: Minor update to the Connection javadocs

Hi Brian, Thank you for your input. Here is the revised version: ——— hg diff diff -r 45b226ad2e05 src/java.sql/share/classes/java/sql/Connection.java --- a/src/java.sql/share/classes/java/sql/Connection.java Thu Mar 16 16:56:29 2017 -0400 +++ b/src/java.sql/share/classes/java/sql/Conn

Re: JDK 9 RFR(s): 8173152: Wrong wording in Comparator.compare() method spec

On Apr 7, 2017, at 1:54 PM, Stuart Marks wrote: > On 4/7/17 11:44 AM, Brian Burkhalter wrote: >> On Apr 6, 2017, at 7:09 PM, Stuart Marks wrote: >> >>> - * imposes orderings that are inconsistent with equals." >>> + * imposes orderings that are inconsistent with equals." >> >> Picayune

Re: RFR: 8178130: Minor update to the Connection javadocs

Hi Lance, Minor comments inline. Brian On Apr 7, 2017, at 2:11 PM, Lance Andersen wrote: > Please review the following minor update to the Connection javadocs. The CCC > has been approved. > > —— > $ hg diff > diff -r 45b226ad2e05 src/java.sql/share/classes/java/sql/Connection.java

RFR: 8178130: Minor update to the Connection javadocs

Hi all, Please review the following minor update to the Connection javadocs. The CCC has been approved. —— $ hg diff diff -r 45b226ad2e05 src/java.sql/share/classes/java/sql/Connection.java --- a/src/java.sql/share/classes/java/sql/Connection.java Thu Mar 16 16:56:29 2017 -0400 +

Re: JDK 9 RFR(s): 8173152: Wrong wording in Comparator.compare() method spec

On 4/7/17 11:44 AM, Brian Burkhalter wrote: On Apr 6, 2017, at 7:09 PM, Stuart Marks > wrote: - * imposes orderings that are inconsistent with equals." + * imposes orderings that are inconsistent with equals." Picayune question: Would the be better o

Re: [9] RFR 8177969: Faster FilePermission::implies by avoiding the use of Path::relativize

This fix looks good to me. However, I would suggest adding some additional comments to the body of the containsPath method explaining what it is doing so that it is easier to understand. --Sean On 4/7/17 10:50 AM, Weijun Wang wrote: Webrev updated at http://cr.openjdk.java.net/~weijun/817

Re: JDK 9 RFR(s): 8173152: Wrong wording in Comparator.compare() method spec

Hi Stuart, On Apr 6, 2017, at 7:09 PM, Stuart Marks wrote: > - * imposes orderings that are inconsistent with equals." > + * imposes orderings that are inconsistent with equals." Picayune question: Would the be better on the line before “In the foregoing?" > + * > + * In the

RFR 8178323: Add negative tests for bind services Jlink feature

Hi, Please review 3 negative tests for Jlink which tests new bind-services/suggest-providers feature. JBS: https://bugs.openjdk.java.net/browse/JDK-8178323 webrev: http://cr.openjdk.java.net/~anazarov/8178323/webrev.00/webrev/

Re: ProcessHandle::getPid

2017/4/7 7:45:38 -0700, roger.ri...@oracle.com: > That's an unfortunate artifact of evolution. > Process.getPid() was added early in 2014 and ProcessHandle a year later. > > Several iterations of ProcessHandle API explored Process being a > subclass of ProcessHandle > so the method names would be

Re: [9] RFR 8177969: Faster FilePermission::implies by avoiding the use of Path::relativize

Webrev updated at http://cr.openjdk.java.net/~weijun/8177969/webrev.01/ Changes since webrev.00 [1] 1. Copyright years. 2. Test fix. check() should include Windows drive tests like contains() does. Thanks Max [1] http://cr.openjdk.java.net/~weijun/8177969/webrev.01/interdiff.patch.html

Re: ProcessHandle::getPid

Hi Mark, That's an unfortunate artifact of evolution. Process.getPid() was added early in 2014 and ProcessHandle a year later. Several iterations of ProcessHandle API explored Process being a subclass of ProcessHandle so the method names would be the same. When ProcessHandle was decoupled fro

ProcessHandle::getPid

Playing around with the `ProcessHandle` API the other day, I noticed that it uses non-Beans accessor names (good!) -- except for `getPid()`. Is there a reason why that method isn't just `pid()`? - Mark