RFR: [Updated] Update tables in java.base to be HTML5-friendly.

This is an updated review for the changes to improve tables in java.base. The changes incorporate earlier review feedback, and also address a problem that was discovered with nested tables. The summary of the set of changes since the previous round is: * A new style class is added for borderl

Re: RFR 8179852: Remove references to demo tests from TEST.groups

OK - cool! Thanks, Brian On May 5, 2017, at 3:16 PM, Alexandre (Shura) Iline wrote: > Felix took the bug I created for the sample tests: > https://bugs.openjdk.java.net/browse/JDK-8178912 > > He is saying that they are not useful. > > Looks ok. > > Shura >

Re: RFR 8179852: Remove references to demo tests from TEST.groups

> On May 5, 2017, at 3:12 PM, Brian Burkhalter > wrote: > > At the least Felix will have a merge to do with test/TEST.groups. Oh, yes - that is true. Shura > > Brian > > On May 5, 2017, at 3:10 PM, Brian Burkhalter > wrote: > >> You’re welcome! >> >>

Re: RFR 8179852: Remove references to demo tests from TEST.groups

Felix took the bug I created for the sample tests: https://bugs.openjdk.java.net/browse/JDK-8178912 He is saying that they are not useful. Looks ok. Shura > On May 5, 2017, at 3:10 PM, Brian Burkhalter > wrote: > > You’re welcome! > > Is there any conflict with this > http://mail.openjdk

Re: RFR 8179852: Remove references to demo tests from TEST.groups

At the least Felix will have a merge to do with test/TEST.groups. Brian On May 5, 2017, at 3:10 PM, Brian Burkhalter wrote: > You’re welcome! > > Is there any conflict with this > http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047442.html > which I just noticed was approved a

Re: RFR 8179852: Remove references to demo tests from TEST.groups

You’re welcome! Is there any conflict with this http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047442.html which I just noticed was approved at 2:59 PM PT? Brian On May 5, 2017, at 3:00 PM, Alexandre (Shura) Iline wrote: > Thank you! > > Pushed. > > Shura > >> On May 5, 20

Re: RFR 8179852: Remove references to demo tests from TEST.groups

Thank you! Pushed. Shura > On May 5, 2017, at 2:56 PM, Brian Burkhalter > wrote: > > Looks OK to me and I did verify the statement about ProblemList.txt. > > Brian > > On May 5, 2017, at 2:51 PM, Alexandre (Shura) Iline > mailto:alexandre.il...@oracle.com>> wrote: > >> Can you please take

Re: RFR 8178912, Throw away sample tests

> On 3 May 2017, at 19:36, Felix Yang wrote: > > Hi there, > > please review following change to remove tests for several samples, which > have been removed in "JEP 298: Remove Demos and Samples". > > Webrev: http://cr.openjdk.java.net/~xiaofeya/8178912/webrev.00/ > > Bug: https://bugs.ope

Re: RFR 8179852: Remove references to demo tests from TEST.groups

Looks OK to me and I did verify the statement about ProblemList.txt. Brian On May 5, 2017, at 2:51 PM, Alexandre (Shura) Iline wrote: > Can you please take a quick look on this fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8179852 > > Change: > $ hg diff > diff --git a/test/TEST.gro

RFR 8179852: Remove references to demo tests from TEST.groups

Hi. Can you please take a quick look on this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8179852 Change: $ hg diff diff --git a/test/TEST.groups b/test/TEST.groups --- a/test/TEST.groups +++ b/test/TEST.groups @@ -465,7 +465,6 @@ needs_jdk = \ :jdk_jdi \ com/sun/tools \ - demo \

RFR 10 JDK-8159995: Rename internal Unsafe.compare methods

Hi, Please review the following core/hotspot change: Bug: https://bugs.openjdk.java.net/browse/JDK-8159995 core webrev: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8159995-unsafe-compare-and-swap-to-set-jdk/webrev/ hotspot webrev: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8159995-unsafe-c

Re: RFR 8150681 Update JAR specification for multi-release jar files

On 05/05/2017 17:44, Paul Sandoz wrote: : See below for the diff on the previous changeset. This looks good. -Alan

Re: RFR 8150681 Update JAR specification for multi-release jar files

> On 5 May 2017, at 03:51, Alan Bateman wrote: > > > > On 04/05/2017 22:14, Paul Sandoz wrote: >> New update here: >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8150681-jar-spec-markdown-with-mr-jar/webrev/src/java.base/share/specs/jar/jar.md.sdiff.html >> >>

Re: RFR 8150681 Update JAR specification for multi-release jar files

> On 5 May 2017, at 02:32, Chris Hegarty wrote: > > >> On 4 May 2017, at 22:14, Paul Sandoz wrote: >> >> New update here: >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8150681-jar-spec-markdown-with-mr-jar/webrev/src/java.base/share/specs/jar/jar.md.sdiff.html >> >>

Re: RFR: JDK-8179692 Move RMI spec to specs directory

Looks good to me. /Erik On 2017-05-05 06:30, Magnus Ihse Bursie wrote: The RMI spec will be moved to a new location, so all links needs to be updated. Bug: https://bugs.openjdk.java.net/browse/JDK-8179692 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8179692-rmi-spec-markdown/webrev.01 /Ma

RFR: JDK-8179692 Move RMI spec to specs directory

The RMI spec will be moved to a new location, so all links needs to be updated. Bug: https://bugs.openjdk.java.net/browse/JDK-8179692 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8179692-rmi-spec-markdown/webrev.01 /Magnus

Re: RFR 8150681 Update JAR specification for multi-release jar files

On 04/05/2017 22:14, Paul Sandoz wrote: New update here: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8150681-jar-spec-markdown-with-mr-jar/webrev/src/java.base/share/specs/jar/jar.md.sdiff.html

Re: RFR 8150681 Update JAR specification for multi-release jar files

> On 4 May 2017, at 22:14, Paul Sandoz wrote: > > New update here: > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8150681-jar-spec-markdown-with-mr-jar/webrev/src/java.base/share/specs/jar/jar.md.sdiff.html > >