Re: RFR 9: 8180082 : Broken javadoc links

2017-05-12 Thread Jonathan Gibbons
I can strongly recommend using link checker tools. For a long time, linklint has been the recommendation. However, linklint cannot cope with "id" attribute on tags that are not tags. That's legal in HTML 5, but linklint is an old tool. There are newer tools out there, for both online and off

Re: RFR 9: 8180082 : Broken javadoc links

2017-05-12 Thread Magnus Ihse Bursie
On 2017-05-12 17:23, Roger Riggs wrote: Hi Magnus, Webrev updated: http://cr.openjdk.java.net/~rriggs/webrev-broken-links-8180082/ Looks good to me. On 5/12/2017 4:26 AM, Magnus Ihse Bursie wrote: On 2017-05-10 23:05, Brian Burkhalter wrote: Hi Roger, Looks all right to me. I assume

Re: RFR 8180309: Minor update to javax.sql.rowset package.html

2017-05-12 Thread Mandy Chung
+1 Mandy > On May 12, 2017, at 11:07 AM, Lance Andersen > wrote: > > Hi all, > > This change updates the JDBC spec that is being pointed to > > — > hg diff > diff -r e2b414957632 > src/java.sql.rowset/share/classes/javax/sql/rowset/package.html > --- a/src/java.sql.rowset/share/classes

RFR 8180309: Minor update to javax.sql.rowset package.html

2017-05-12 Thread Lance Andersen
Hi all, This change updates the JDBC spec that is being pointed to — hg diff diff -r e2b414957632 src/java.sql.rowset/share/classes/javax/sql/rowset/package.html --- a/src/java.sql.rowset/share/classes/javax/sql/rowset/package.html Fri May 12 10:43:28 2017 -0700 +++ b/src/java.sql.rowset

Re: RFR 9 test-only RFR 8177328 : java/lang/ClassLoader/securityManager/ClassLoaderTest.java times out with -Xcomp

2017-05-12 Thread Brent Christian
On 5/12/17 9:11 AM, Mandy Chung wrote: Minor comment: 95 private final List COMMON_ARGS; This is an instance field and you can use lower case as the convention. 238 return !s.equals(""); You can consider using String::isEmpty. Thanks, Mandy. I will make these cha

Re: (9) (docs only) RFR: 8180176: Broken javadoc links in java.logging and java.naming

2017-05-12 Thread Mandy Chung
> On May 12, 2017, at 4:39 AM, Daniel Fuchs wrote: > > Hi, > > I have refreshed my webrev to use {@extLink } instead as this > is what is needed now for links to technical guides: > > http://cr.openjdk.java.net/~dfuchs/webrev_8180176/webrev.00/index.html Looks good. Mandy

Re: (9) (docs only) RFR: 8180176: Broken javadoc links in java.logging and java.naming

2017-05-12 Thread Chris Hegarty
On 12/05/17 12:39, Daniel Fuchs wrote: Hi, I have refreshed my webrev to use {@extLink } instead as this is what is needed now for links to technical guides: http://cr.openjdk.java.net/~dfuchs/webrev_8180176/webrev.00/index.html Looks good. -Chris.

Re: RFR 9 test-only RFR 8177328 : java/lang/ClassLoader/securityManager/ClassLoaderTest.java times out with -Xcomp

2017-05-12 Thread Mandy Chung
> On May 11, 2017, at 3:25 PM, Brent Christian > wrote: > > Hi, > > I have one more update, with a couple of suggested changes to simplify the > execute() calls: > > * execute() takes a vararg, so explicit String[] creation can be omitted > (mostly). > > * args common to every execute() ca

Re: JDK 9 RFR(xs): 8180137: fix broken link in java.lang.Iterable

2017-05-12 Thread Roger Riggs
Looks fine. On 5/12/2017 11:19 AM, Stuart Marks wrote: Hi all, Another quick doc change. This one removes a link from Iterable to technotes/guides and adjusts adjacent wording to match. Patch below. Bug link: https://bugs.openjdk.java.net/browse/JDK-8180137 Thanks, s'marks # HG changeset

Re: RFR 9: 8180082 : Broken javadoc links

2017-05-12 Thread Roger Riggs
Hi Magnus, Webrev updated: http://cr.openjdk.java.net/~rriggs/webrev-broken-links-8180082/ On 5/12/2017 4:26 AM, Magnus Ihse Bursie wrote: On 2017-05-10 23:05, Brian Burkhalter wrote: Hi Roger, Looks all right to me. I assume you will have already built the actual docs and clicked throug

JDK 9 RFR(xs): 8180137: fix broken link in java.lang.Iterable

2017-05-12 Thread Stuart Marks
Hi all, Another quick doc change. This one removes a link from Iterable to technotes/guides and adjusts adjacent wording to match. Patch below. Bug link: https://bugs.openjdk.java.net/browse/JDK-8180137 Thanks, s'marks # HG changeset patch # User smarks # Date 1494544788 25200 # Thu Ma

Re: Getting a live view of environment variables (Gradle and JDK 9)

2017-05-12 Thread dalibor topic
On 11.05.2017 18:29, Cédric Champeau wrote: Unfortunately, they are not safely mutable in multi-threaded programs on many operating system/libc combinations. But the problem is less about mutating, that it is about reading: the VM returns wrong values at some point, because it _assumes

Re: (9) (docs only) RFR: 8180176: Broken javadoc links in java.logging and java.naming

2017-05-12 Thread Vyom Tewari
Hi Daniel, Changes looks good, i was under impression that if {@extLink } description is multi word then you have to put it under double quotes like {xtLink jndi_overview "JNDI documentation"} but looks like that is not the case ExtLink.java will take care of this. Thanks, Vyom On Friday

Re: (9) (docs only) RFR: 8180176: Broken javadoc links in java.logging and java.naming

2017-05-12 Thread Daniel Fuchs
Hi, I have refreshed my webrev to use {@extLink } instead as this is what is needed now for links to technical guides: http://cr.openjdk.java.net/~dfuchs/webrev_8180176/webrev.00/index.html best regards, -- daniel On 11/05/2017 12:54, Daniel Fuchs wrote: Hi, Please find below a patch for:

Re: RFR: JDK-8179697: Fix Html5 errors in java.naming, java.logging, jdk.httpserver, jdk.net, jdk.sctp

2017-05-12 Thread Daniel Fuchs
Hi Kumar, On 12/05/2017 00:16, Kumar Srinivasan wrote: Hi Daniel, As Jon surmised, this is an ARIA/accessibility requirement, in that one can't have holes in the usage of h* tags, as javadoc tool itself uses h1 and h2, the API docs have to start with h3. With respect to your comment, the h2-

How to create dynamically generated JNLP files post JDK-8157337?

2017-05-12 Thread Tim Anderson
Apologies if this is the wrong place for this post, but there doesn't appear to be a webstart specific list. Is it possible to generate a JNLP file with arguments that change each invocation, and avoid the webstart security popup being displayed each time? Background I have a signed webstart

Re: RFR: JDK-8179697: Fix Html5 errors in java.naming, java.logging, jdk.httpserver, jdk.net, jdk.sctp

2017-05-12 Thread Daniel Fuchs
On 11/05/2017 20:46, Jonathan Gibbons wrote: Daniel, As a general comment, it is an accessibility error to have "gaps" in the header numbering, such as an following an without an intervening . Oh! Thank you for the precision. I will take a second look with that in mind. If you can point t

Re: Proposal: javax.naming.spi.NamingManager.clearInitialContextFactoryBuilder()

2017-05-12 Thread Alan Bateman
On 11/05/2017 22:25, Andrew Guibert wrote: Alan, could you please commit this patch for me? We've tested it locally and all of the jdk_other tests pass with this change on jdk9. 93d92 < * Once installed, the builder cannot be replaced. 101d99 < * @exception IllegalStateException If a factory h

Re: RFR 9: 8180082 : Broken javadoc links

2017-05-12 Thread Daniel Fuchs
Hi Roger, Looks good! Nit: java/lang/management/package.html: 38 conforms to the {@link javax.management JMX} should probably use {@linkplain } instead. (no need for a new webrev) best regards, -- daniel On 11/05/2017 20:41, Roger Riggs wrote: Hi, Thanks for the review and suggestions. {

Re: RFR 9: 8180082 : Broken javadoc links

2017-05-12 Thread Magnus Ihse Bursie
On 2017-05-10 23:05, Brian Burkhalter wrote: Hi Roger, Looks all right to me. I assume you will have already built the actual docs and clicked through the updated links. Always a bit painful … Roger, Did you test the actual links? I found one needing updating: In src/java.base/share/classe