Re: RFR(JAXP) 8182111: Package summary is missing in jdk.xml.dom module

> On Jun 14, 2017, at 9:29 PM, huizhe wang wrote: > > > On 6/14/2017 4:58 PM, Mandy Chung wrote: >>> On Jun 14, 2017, at 4:19 PM, huizhe wang wrote: >>> >>> Hi, >>> >>> Please review new package descriptions for jdk.xml.dom module. Note that

Re: RFR(JAXP) 8182111: Package summary is missing in jdk.xml.dom module

On 6/14/2017 4:58 PM, Mandy Chung wrote: On Jun 14, 2017, at 4:19 PM, huizhe wang wrote: Hi, Please review new package descriptions for jdk.xml.dom module. Note that the link to the XPath specificaiton in xpath/package-info.java is the formal release that is

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

On 2017/6/15 1:22, Alan Bateman wrote: On 12/06/2017 09:00, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8181912 webrev: http://cr.openjdk.java.net/~mli/8181912/webrev.00/ Are you sure that setting the user.* properties on the

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

Hi Claes, The change looks fine. Yes, encoding the 2-byete latin1 at native looks reasonable. One nick picking is that it might be better to initialize the constant "LATIN1" from the String class when intializing String_coder_ID? recently I got a "naked constants" complain #JDK-8156530, so

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

Also disable to run ParallelPrefix.java in concurrency. Ok. Please check the new webrev: http://cr.openjdk.java.net/~mli/8179242/webrev.01/ 29 * @run testng/othervm -Xms256m -Xmx1024m ParallelPrefix Why are you setting the max heap size? In my test result, 1024M is sufficient, and if

Re: RFR(JAXP) 8182111: Package summary is missing in jdk.xml.dom module

> On Jun 14, 2017, at 4:19 PM, huizhe wang wrote: > > Hi, > > Please review new package descriptions for jdk.xml.dom module. Note that the > link to the XPath specificaiton in xpath/package-info.java is the formal > release that is different from the one in the

RFR(JAXP) 8182111: Package summary is missing in jdk.xml.dom module

Hi, Please review new package descriptions for jdk.xml.dom module. Note that the link to the XPath specificaiton in xpath/package-info.java is the formal release that is different from the one in the classes. The later was a working release now requires a login [1]. The only difference in

Re: RFR(JDK10/JAXP): 8181153: Fix lint warnings in JAXP repo: dep-ann

Thanks Lance! Pushed. -Joe On 6/14/2017 1:22 PM, Lance Andersen wrote: Hi Joe, Looks fine. Best Lance On Jun 14, 2017, at 1:44 PM, huizhe wang > wrote: Hi, This change fixes dep-ann warnings. (1) For most cases, @Deprecated is

Re: RFR(JDK10/JAXP): 8181153: Fix lint warnings in JAXP repo: dep-ann

Hi Joe, Looks fine. Best Lance > On Jun 14, 2017, at 1:44 PM, huizhe wang wrote: > > Hi, > > This change fixes dep-ann warnings. > > (1) For most cases, @Deprecated is simply added below the @deprecated javadoc > tag and above the relevant class or method. > > (2)

RFR(JDK10/JAXP): 8181153: Fix lint warnings in JAXP repo: dep-ann

Hi, This change fixes dep-ann warnings. (1) For most cases, @Deprecated is simply added below the @deprecated javadoc tag and above the relevant class or method. (2) For XSLTErrorResources*.java, unused constants are removed. (3) DOM2Helper.java The original DOM2Helper was deprecated

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

On 14/06/2017 18:20, Paul Sandoz wrote: On 12 Jun 2017, at 01:00, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8181478 webrev: http://cr.openjdk.java.net/~mli/8181478/webrev.00/ It took me a few moments to

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

On 12/06/2017 09:00, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8181912 webrev: http://cr.openjdk.java.net/~mli/8181912/webrev.00/ Are you sure that setting the user.* properties on the command actually works? I assume we'll have

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

> On 12 Jun 2017, at 01:00, Hamlin Li wrote: > > Would you please review the below patch? > > bug: https://bugs.openjdk.java.net/browse/JDK-8181478 > > webrev: http://cr.openjdk.java.net/~mli/8181478/webrev.00/ > It took me a few moments to grok the NonExistentDriver

Re: (10) RFR of JDK-8181912, Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

+1 Paul. > On 13 Jun 2017, at 18:10, Hamlin Li wrote: > > Ping. > > Thank you > > -Hamlin > > > On 2017/6/12 16:00, Hamlin Li wrote: >> Would you please review the below patch? >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8181912 >> >> webrev:

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

> On 13 Jun 2017, at 18:08, Hamlin Li wrote: > > Hi Paul, > > Please check my comments inline below. > > > On 2017/6/14 1:23, Paul Sandoz wrote: >>> On 12 Jun 2017, at 20:37, Hamlin Li wrote: >>> >>> Hi Paul, >>> >>> Good idea. Although the

Re: RFR(10) 8176192: Incorrect usage of Iterator in Java 8 In com.sun.jndi.ldap.EventSupport.removeNamingListener

> On 13 Jun 2017, at 22:50, Vyom Tewari wrote: > > Hi Paul, > > Thanks for review, please find the modified webrev. > > http://cr.openjdk.java.net/~vtewari/8176192/webrev0.1/index.html > +1 Paul. > Thanks, > > Vyom

Re: Review Request: JDK-8182137: Missing permissions in deprivileged java.xml.bind and java.xml.ws modules

> On Jun 14, 2017, at 8:18 AM, Alan Bateman wrote: > > On 14/06/2017 16:11, Mandy Chung wrote: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182137/webrev.00/ >> >> java.xml.bind and java.xml.ws modules are deprivileged and granted with >> specific permissions

Re: Review Request: JDK-8182137: Missing permissions in deprivileged java.xml.bind and java.xml.ws modules

Looks fine to me. The bug needs a noreg label. I agree with Alan that the empty jdk.incubator.httpclient entry should be removed. Also, please open a followon issue to fix the permissions (targeting it to 10 would seem appropriate to me). --Sean On 6/14/17 11:11 AM, Mandy Chung wrote:

Re: Review Request: JDK-8182137: Missing permissions in deprivileged java.xml.bind and java.xml.ws modules

On 14/06/2017 16:11, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182137/webrev.00/ java.xml.bind and java.xml.ws modules are deprivileged and granted with specific permissions since jdk-9+51. JAXB and JAX-WS tests were ran and found no regressions when security

Review Request: JDK-8182137: Missing permissions in deprivileged java.xml.bind and java.xml.ws modules

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182137/webrev.00/ java.xml.bind and java.xml.ws modules are deprivileged and granted with specific permissions since jdk-9+51. JAXB and JAX-WS tests were ran and found no regressions when security manager is enabled. It is recently uncovered

Re: Accessing module internals from bytecode rewriting agent

On 14/06/2017 00:57, Jeremy Manson wrote: Hey folks, As a followup to this, given everything else that has happened in the mean time: I wonder if the same logic Mark put in his proposal to allow illegal access to internal APIs (

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

Build changes look good to me. /Erik On 2017-06-13 22:27, Claes Redestad wrote: On 2017-06-13 21:09, Martin Buchholz wrote: Looks good to me, although still hoping for more review from others. I expect Sherman to weigh in. :-) +if (bytes != 0) { Style: use NULL. Done. +static