Re: java.util.Pair

2017-07-13 Thread kedar mhaswade
On Thu, Jul 13, 2017 at 4:24 PM, Dave Brosius wrote: > I would avoid Pair and Entry like the plague. They are devoid of meaning > and are just there to save your fingers. The only difference is that the latter is already available in java.util. And perhaps it is (should be?) more attractive to

Re: [9] JDK-8184306: zlib 1.2.11 upgrade triggers j.u.zip.Deflater regression

2017-07-13 Thread Brian Burkhalter
On Jul 12, 2017, at 11:52 PM, Alan Bateman wrote: > On 13/07/2017 00:06, Xueming Shen wrote: >> : >> >> My reading of the 1.2.11 changes suggests the root cause is that the internal >> state "deflate_state.high_water" is not being reset correctly/appropriately >> (to 0?) >> in deflateReset/defl

Re: java.util.Pair

2017-07-13 Thread Dave Brosius
I would avoid Pair and Entry like the plague. They are devoid of meaning and are just there to save your fingers. If that is your main impetus, i'd just turn to using lombok and have true bean classes, that are finger-cost free. On 07/13/2017 05:41 PM, fo...@univ-mlv.fr wrote: De: "John Rose

Re: java.util.Pair

2017-07-13 Thread forax
> De: "John Rose" > À: "Rémi Forax" > Cc: "joe darcy" , "core-libs-dev" > > Envoyé: Jeudi 13 Juillet 2017 23:05:14 > Objet: Re: java.util.Pair > On Jul 13, 2017, at 1:39 PM, Remi Forax < [ mailto:fo...@univ-mlv.fr | > fo...@univ-mlv.fr ] > wrote: >> Tuples are like an array of value types para

Re: java.util.Pair

2017-07-13 Thread John Rose
On Jul 13, 2017, at 1:39 PM, Remi Forax wrote: > > Tuples are like an array of value types parameterized by a constant integer The homogeneous case is pretty simple; most of what you need is to allow a generic type to be parameterized by an integer. C++ templates have had that for a long time.

Re: java.util.Pair

2017-07-13 Thread Remi Forax
Tuples are like an array of value types parameterized by a constant integer so it will be interesting to revisit this issue when we will have a clear idea about what value types are and how to parameterized a class. cheers, Rémi - Mail original - > De: "joe darcy" > À: "Hohensee, Paul"

Re: java.util.Pair

2017-07-13 Thread John Rose
On Jul 13, 2017, at 10:29 AM, Maurizio Cimadamore wrote: > > Maybe automatic refactoring to Map.Entry ? With the new static method added > in 9, creating one is also very fluent (but I > know that Entry doesn't convey same meaning as Pair in method > signatures/fields) The JavaFX Pair Paul is

Re: java.util.Pair

2017-07-13 Thread Vitaly Davidovich
Similarly, I've used https://docs.oracle.com/javase/8/docs/api/java/util/AbstractMap.SimpleEntry.html and https://docs.oracle.com/javase/8/docs/api/java/util/AbstractMap.SimpleImmutableEntry.html in these circumstances. On Thu, Jul 13, 2017 at 1:29 PM Maurizio Cimadamore < maurizio.cimadam...@orac

Re: java.util.Pair

2017-07-13 Thread Gary Gregory
Hi All, FYI: We added a couple of classes in Apache Commons Lang to deal with pairs and triples. This is definitely for the pragmatic programmer... https://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/tuple/Pair.html https://commons.apache.org/proper/common

Re: java.util.Pair

2017-07-13 Thread Hohensee, Paul
Thanks for the immediate response. Having read the thread, I understand the argument against including Pair in the JDK and personally agree with the sw engineering argument. But, it got into javafx.util somehow and is now effectively part of the JDK anyway, so that ship has sailed. Thus, it see

Re: java.util.Pair

2017-07-13 Thread Hohensee, Paul
That’s a possibility. We could recommend that as an alternative. Thanks, Paul On 7/13/17, 10:29 AM, "Maurizio Cimadamore" wrote: Maybe automatic refactoring to Map.Entry ? With the new static method added in 9, creating one is also very fluent (but I know that Entry doesn't conv

Re: java.util.Pair

2017-07-13 Thread Maurizio Cimadamore
Maybe automatic refactoring to Map.Entry ? With the new static method added in 9, creating one is also very fluent (but I know that Entry doesn't convey same meaning as Pair in method signatures/fields) http://download.java.net/java/jdk9/docs/api/java/util/Map.html#entry-K-V- Cheers Maurizio

Re: java.util.Pair

2017-07-13 Thread joe darcy
Hi Paul, See the discussion in thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-March/003973.html http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-April/thread.html In short, no current plans to add java.util.Pair. -Joe On 7/13/2017 10:07 AM, Hohensee, Paul wrote:

Re: [9] JDK-8184306: zlib 1.2.11 upgrade triggers j.u.zip.Deflater regression

2017-07-13 Thread Martin Buchholz
Random drive-by comments. - consider adding a link to the JDK bug to the zlib bug. - configure on linux reports: --with-zlib use zlib from build system or OpenJDK source (system, bundled) [bundled] Does this need updating to "system" ?

java.util.Pair

2017-07-13 Thread Hohensee, Paul
See the ancient https://bugs.openjdk.java.net/browse/JDK-4947273. At Amazon, many projects depend on JavaFX to get only a single class, namely javafx.util.Pair. That means that we must distribute OpenJFX along with our internal OpenJDK distribution, or split javafx.util.Pair out into a separate

Re: RFR: 8184311: Update java.sql and java.sql.rowset API docs for accessibility

2017-07-13 Thread Jonathan Gibbons
Thanks, Lance -- Jon On 7/13/17 3:20 AM, Lance Andersen wrote: looks fine Jon On Jul 12, 2017, at 10:06 PM, Jonathan Gibbons mailto:jonathan.gibb...@oracle.com>> wrote: Please review ... More noreg-doc API cleanup for accessibility, etc. This time for java.sql and java.sql.rowset. One o

RE: 8182743: Ineffective use of volatile hurts performance of Charset.atBugLevel()

2017-07-13 Thread Kazunori Ogata
Hi Christoph, Thank you for your help! Regards, Ogata "Langer, Christoph" wrote on 2017/07/13 19:32:32: > From: "Langer, Christoph" > To: Kazunori Ogata > Cc: core-libs-dev , "nio- > d...@openjdk.java.net" > Date: 2017/07/13 19:32 > Subject: RE: 8182743: Ineffective use of volatile hurts

RE: 8182743: Ineffective use of volatile hurts performance of Charset.atBugLevel()

2017-07-13 Thread Langer, Christoph
Hi Ogata, I'll take care of backporting a fix to remove the "volatile" qualifier for both, JDK-8182743 and JDK-8184330. Best regards Christoph > -Original Message- > From: Kazunori Ogata [mailto:oga...@jp.ibm.com] > Sent: Freitag, 7. Juli 2017 18:59 > To: core-libs-dev ; nio- > d...@ope

Re: RFR: 8184311: Update java.sql and java.sql.rowset API docs for accessibility

2017-07-13 Thread Lance Andersen
looks fine Jon > On Jul 12, 2017, at 10:06 PM, Jonathan Gibbons > wrote: > > Please review ... > > More noreg-doc API cleanup for accessibility, etc. This time for java.sql > and java.sql.rowset. > One of the tables ought to be restructured a bit, because there is no single > unique column

JDK 10 RFR of JDK-8183377: Refactor java/lang/ClassLoader/deadlock shell tests to java

2017-07-13 Thread Amy Lu
java/lang/ClassLoader/deadlock/TestCrossDelegate.sh java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh Please review this patch to refactor the shell tests to java. bug: https://bugs.openjdk.java.net/browse/JDK-8183377 http://cr.openjdk.java.net/~amlu/8183377/webrev.00/ Thanks, Amy