Re: [10] RFR 8134512 : provide Alpha-Numeric (logical) Comparator

2017-07-23 Thread Ivan Gerasimov
Thank you Jonathan for looking into that! I agree with all your suggestions. Here's the updated webrev with suggested modifications: WEBREV: http://cr.openjdk.java.net/~igerasim/8134512/02/webrev/ With kind regards, Ivan On 7/23/17 3:56 AM, Jonathan Bluett-Duncan wrote: Meant to reply to core

[10] RFR: 8185104: Generate CharacterDataLatin1 lookup tables directly

2017-07-23 Thread Claes Redestad
Hi, java.lang.CharacterDataLatin1 and others are generated at build time by the GenerateCharacter tool, which has a -string mode to generate lookup tables as Strings literals rather than arrays directly. This serves multiple purposes: 1. it reduces the size of the generated bytecode, which i

Re: [10] RFR 8134512 : provide Alpha-Numeric (logical) Comparator

2017-07-23 Thread Jonathan Bluett-Duncan
Meant to reply to core-libs-dev as well; doing so now. Jonathan On 23 July 2017 at 11:50, Jonathan Bluett-Duncan wrote: > Hi Ivan, > > I'm not a reviewer per se, but I thought I'd chime in. > > There's a few things with Comparator.java which I think could be improved: > >1. `comparingNumeri