Re: StackOverflowError - Java 9 Build 181

2017-09-19 Thread Tom Hood
I should add that we have not modified or overridden any policy files. Also, we are not using a custom security manager. On Tue, Sep 19, 2017 at 11:52 AM, Tom Hood wrote: > Hi, > > I hit an infinite recursion loop probably related to PolicyFile that > exists in Java 9

StackOverflowError - Java 9 Build 181

2017-09-19 Thread Tom Hood
Hi, I hit an infinite recursion loop probably related to PolicyFile that exists in Java 9 build 181 for windows 64-bit. It might be related to JDK-8077418 I haven't tracked down what is causing our webstart app to hit this problem yet, but I

18.3 RFR 8187688 Additional tests for MethodHandle.invokeWithArguments

2017-09-19 Thread Paul Sandoz
Hi, Please review some additional tests testing edge case aspects of MethodHandle.invokeWithArguments: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8187688-invoke-with-arguments-test/webrev/ This

Re: [10] RFR(M) 8182701: Modify JVMCI to allow Graal Compiler to expose platform MBean

2017-09-19 Thread Vladimir Kozlov
Finally ;) On 9/19/17 5:56 AM, Jaroslav Tulach wrote: On pátek 15. září 2017 10:53:45 CEST mandy chung wrote: > http://cr.openjdk.java.net/~jtulach/8182701/webrev.05/index.html Looks good. Great. Unless there are further comments, then we can plan integration of my changes. Vladimir, are

Re: RFR 8187631 : Refactor FileDescriptor close implementation

2017-09-19 Thread Roger Riggs
Hi, I had a suggestion to use  fdo and fd parameter names and to fix copyright dates.   http://cr.openjdk.java.net/~rriggs/webrev-fd-refactor-8187631-02/ Thanks, Roger On 9/19/2017 10:52 AM, Brian Burkhalter wrote: Hi Roger, On Sep 19, 2017, at 6:51 AM, Roger Riggs

Re: Review Request: JDK-8187449: jdeps fails when an upgradeable module is upgraded with an automatic module

2017-09-19 Thread Paul Sandoz
> On 18 Sep 2017, at 14:44, mandy chung wrote: > > http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8187449/webrev.00/ > JdepsConfiguration — 288 // is this module from the system module path? 289 boolean isSystem = false; 290 if

Re: RFR 8187631 : Refactor FileDescriptor close implementation

2017-09-19 Thread Brian Burkhalter
Hi Roger, On Sep 19, 2017, at 6:51 AM, Roger Riggs wrote: > The updated webrev is: > http://cr.openjdk.java.net/~rriggs/webrev-fd-refactor-8187631-02/ > > I avoided cluttering the initial webrev with misc cleanup. This looks good. The name “rawfd” is good. It could

Re: RFR 8187631 : Refactor FileDescriptor close implementation

2017-09-19 Thread Roger Riggs
Hi Alan, The updated webrev is: http://cr.openjdk.java.net/~rriggs/webrev-fd-refactor-8187631-02/ I avoided cluttering the initial webrev with misc cleanup. I renamed the parameters, corrected some old markup and reordered the declarations so a side-by side diff of the Unix and Windows

Re: [BUG PROPOSAL]: C++ code that calls JNI_CreateJavaVM can be exited by java

2017-09-19 Thread Adam Farley8
Hi David, Alan, You are right in that the changes to HotSpot would be nontrivial. I see a number of places in (e.g.) arguments.cpp that seem to exit in the same manner as Xlog (such as -Xinternalversion). I would advise ploughing through the CSR process to alter the JNI spec, and

Re: [10] RFR(M) 8182701: Modify JVMCI to allow Graal Compiler to expose platform MBean

2017-09-19 Thread Jaroslav Tulach
On pátek 15. září 2017 10:53:45 CEST mandy chung wrote: > > http://cr.openjdk.java.net/~jtulach/8182701/webrev.05/index.html > > Looks good. Great. Unless there are further comments, then we can plan integration of my changes. Vladimir, are you "sponsor" of my change? Will you integrate it

Re: RFR 8187631 : Refactor FileDescriptor close implementation

2017-09-19 Thread Alan Bateman
On 18/09/2017 20:28, Roger Riggs wrote: In anticipation of the re-opening (not yet) of the JDK 10 repo please review refactoring the handling of closing of files in FileInputStream, FileOutputStream, RandomAccessFile, and FileChannelImpl and related native code. The refactoring enables a

Re: Scanning multi version jars?

2017-09-19 Thread Alan Bateman
On 19/09/2017 05:37, Greg Wilkins wrote: : Which raises an interesting point with the multi versioned jar I have used as an example, which contains: - org/example/Foo.class - org/example/Foo$Bar.class - META-INF/versions/9/org/example/Foo.class What does the classloader do

Re: Scanning multi version jars?

2017-09-19 Thread Remi Forax
Hi Greg, the notion of inner classes do not exist at runtime (apart if you explicitly ask by reflection). The compiler desugar inner classes to several classes, so the compiler needs attributes (InnerClasses and EnclosingMethod) in the classfile to be able to reconstruct the java source file