Re: JDK 10 RFR of JDK-8189952: New methods on String: chars() and codePoints() should be marked since 9

2017-10-26 Thread Paul Sandoz
> On 26 Oct 2017, at 17:24, joe darcy wrote: > > Hello, > > The initial changeset which introduced these the methods String.chars() and > String.codePoints(), JDK-8071477 , had the expected @since tags for the time > (@since 1.9), but subsequent changes to String seem

RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity

2017-10-26 Thread Brent Christian
Hi, It would be useful to have a Properties constructor that takes an argument to set the initial capacity. Such a constructor is present on many of the other Map implementations in the JDK, including Hashtable, the superclass of Properties. In particular, being able to specify the initial

Re: JDK 10 RFR of JDK-8189952: New methods on String: chars() and codePoints() should be marked since 9

2017-10-26 Thread Brian Burkhalter
Hi Joe, Looks fine. Thanks, Brian On Oct 26, 2017, at 5:24 PM, joe darcy wrote: > The initial changeset which introduced these the methods String.chars() and > String.codePoints(), JDK-8071477 , had the expected @since tags for the time > (@since 1.9), but subsequent

JDK 10 RFR of JDK-8189952: New methods on String: chars() and codePoints() should be marked since 9

2017-10-26 Thread joe darcy
Hello, The initial changeset which introduced these the methods String.chars() and String.codePoints(), JDK-8071477 , had the expected @since tags for the time (@since 1.9), but subsequent changes to String seem to have removed them. Please review the patch below to add them back. Thanks,

[10] RFR 8186046 Minimal ConstantDynamic support

2017-10-26 Thread Paul Sandoz
Hi, Please review the following patch for minimal dynamic constant support: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8186046-minimal-condy-support-hs/webrev/

Module naming for logging implementations

2017-10-26 Thread Stephen Colebourne
I've spent some time discussing module names for logging implementations recently: https://github.com/jodastephen/jpms-module-names/wiki/Logging-APIs https://issues.apache.org/jira/browse/LOG4J2-2056 https://jira.qos.ch/browse/SLF4J-407?jql=text%20~%20%22jpms%22 Most logging projects are split in

Re: RFR: 8188858: Caching latestUserDefinedLoader() results in ObjectInputStream.readObject()

2017-10-26 Thread Alan Bateman
On 24/10/2017 11:53, Kazunori Ogata wrote: : Comments for revising the text (and fixing my poor English) are welcome. Webrev: http://cr.openjdk.java.net/~horii/8188858/webrev.04/ I've read through webrev.03 and webrev.04 and they seem correct. Are there are more comments on the