Hi Brian
See latest changes here:
http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.03
-Patrick
> Am 14.11.2017 um 01:34 schrieb Brian Burkhalter :
>
> Hi Patrick,
>
> More editorial comments ... ;-)
>
No problem :-)
> In Readable.java these lines
>
> 73 * Depending on wh
I tried the same test with
changeset: 47679:d85284ccd1bd
user:sspitsyn
date:Fri Nov 03 17:09:25 2017 -0700
summary: 8189731: Disable CFLH when there are no transformers
and it also yields the exception. E.g. the problem is certainly not result of
my changes.
-jt
PS: I tr
Hi Patrick,
More editorial comments ... ;-)
In Readable.java these lines
73 * Depending on which class implements the appendable, there may be a
limit
74 * of data that can written to which in turn could lead to an
exception.
are a bit unclear to me. Do you mean to say a limit o
Latest changes:
http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.03
-Patrick
> Am 13.11.2017 um 15:35 schrieb Roger Riggs :
>
> Hi Patrick,
>
> Comments on http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.02:
>
> Readable.java:
> 74: „to an error" is a bit overloaded, p
Hello Mandy,
this was a good test:
> >
> > ./build/linux-x64/jdk/bin/java -XX:+UnlockExperimentalVMOptions -XX:
> > +EnableJVMCI -XX:+UseJVMCICompiler -jar ...
>
> You can also try running the above command with -Djava.security.manager
> as a sanity test (the application may need additional perm
Hello,
A few comments on this thread:
As Paul noted, a portion of fdlibm has been ported from C to Java. I do
intend to finish the port at some point. The port gives an
implementation speedup by avoiding Java -> C -> Java transition
overheads. However, the same algorithms are being used of co
Hey Claes,
though far away from being an expert on the subject matter, I have some very
minor comments if you don't mind.
ClassSpecializer.java
L510: * For example, a concrete species for two reference and one integral
bound values have a shape like the following:
Should be imho:
L510: * For ex
Thanks Vladimir!
/Claes
On 2017-11-13 17:38, Vladimir Ivanov wrote:
Looks good!
Best regards,
Vladimir Ivanov
On 11/13/17 7:34 PM, Claes Redestad wrote:
Hi,
this patch factors out the BoundMethodHandle species data class
generation to a new ClassSpecializer facility.
While currently se
Looks good!
Best regards,
Vladimir Ivanov
On 11/13/17 7:34 PM, Claes Redestad wrote:
Hi,
this patch factors out the BoundMethodHandle species data class
generation to a new ClassSpecializer facility.
While currently semantically neutral, this will make it possible
to reuse the facility in
Hi,
this patch factors out the BoundMethodHandle species data class
generation to a new ClassSpecializer facility.
While currently semantically neutral, this will make it possible
to reuse the facility in other places.
Webrev: http://cr.openjdk.java.net/~redestad/8184777/open.00/
Bug: https
Hi Jason,
On 13/11/2017 15:14, Jason Mehrens wrote:
Hi Daniel,
Sorry for the late reply I was offline for the long weekend.
Hot reloads of the LogManager have always been a problem. I think you are
running into https://bugs.openjdk.java.net/browse/JDK-8033661 in your testing
and that is goi
Hi Daniel,
Sorry for the late reply I was offline for the long weekend.
Hot reloads of the LogManager have always been a problem. I think you are
running into https://bugs.openjdk.java.net/browse/JDK-8033661 in your testing
and that is going to give you troubling results on what is recreated a
Hi Patrick,
Comments on http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.02:
Readable.java:
74: "to an error" is a bit overloaded, perhaps "to an exception"
X-Buffer.java.template:
1567: "this buffer": do you mean the "out buffer"
1578: "The out buffer is this buffer": will read
Thanks David, Peter for your review and comments. As I am new to the
community, can you please help me to open a bug and integrate the
changes into code base?
-Venkat
On 12/11/17 2:19 AM, Peter Levart wrote:
Hi David, Venkat,
On 11/11/17 21:15, Peter Levart wrote:
For example, take the foll
14 matches
Mail list logo
