Re: [10] RFR: 8193507: [REDO] Startup regression due to JDK-8185582

2017-12-15 Thread Xueming Shen
On 12/15/17, 3:43 PM, Peter Levart wrote: Hi Claes, I see this is already pushed. I don't have any additional comments, but just want to know what was wrong with old code. You say that you used non-static inner classes. I don't see that in old code. All the lambdas you replaced with nested st

Re: [10] RFR: 8193507: [REDO] Startup regression due to JDK-8185582

2017-12-15 Thread Peter Levart
Hi Claes, I see this is already pushed. I don't have any additional comments, but just want to know what was wrong with old code. You say that you used non-static inner classes. I don't see that in old code. All the lambdas you replaced with nested static classes should have already captured

Re: [11] RFR 8193085 Vectorize the nio Buffer equals and compareTo implementations

2017-12-15 Thread Paul Sandoz
> On 15 Dec 2017, at 13:01, David Lloyd wrote: > > I'm not a reviewer, but I was curious about this change; unfortunately > the diff seems to be dominated by case and formatting changes making > the actual functional aspect change hard to divine. > If not already i recommend viewing via udiff

Re: [11] RFR 8193085 Vectorize the nio Buffer equals and compareTo implementations

2017-12-15 Thread David Lloyd
I'm not a reviewer, but I was curious about this change; unfortunately the diff seems to be dominated by case and formatting changes making the actual functional aspect change hard to divine. Within the JBoss unit we have an informal policy that formatting changes should be presented separately so

[11] RFR 8193085 Vectorize the nio Buffer equals and compareTo implementations

2017-12-15 Thread Paul Sandoz
Hi, Please review this patch to vectorize the buffer equals and compareTo implementations, using the same approach that was used for arrays: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8193085-buffer-equals-compareTo-vectorize/webrev/

Re: RFR JDK-8193479: test/hotspot/jtreg/compiler/codegen/Test6896617.java fails after JDK-8184947

2017-12-15 Thread Tobias Hartmann
Hi Sherman, On 15.12.2017 10:48, Tobias Hartmann wrote: > I would say it's best to wait for the jdk10 repo to open. I've checked with Jesper and we can/should quarantine this test right away. I'll take care of it [1]. Best regards, Tobias [1] http://mail.openjdk.java.net/pipermail/hotspot-com

Re: RFR JDK-8193479: test/hotspot/jtreg/compiler/codegen/Test6896617.java fails after JDK-8184947

2017-12-15 Thread Tobias Hartmann
Hi Sherman, On 14.12.2017 21:46, Xueming Shen wrote: > I have a webrev out there. But I will probably have to wait for the > new jdk10 repo open next week. > > Or maybe the hs repo is still open for something like this? and > you guys can help get it in directly there? I would say it's best to w