Re: RFR 8139206: Add InputStream readNBytes(int len)

On Jan 23, 2018, at 1:19 AM, Weijun Wang wrote: > + * Therefore, the method may be safely called with very large values of > + * {@code len} provided sufficient memory is available. > > What does "sufficient memory" mean? For len, or the number of available

Re: [11] RFR JDK-8191170: Clarify if java.class.path can be undefined

It is the module where the main class is per the value of the "jdk.module.main" system property.  If not set, the initial module is an unnamed module.  What about adding the following to @implNote?      * The "{@code jdk.module.main}" system property specifies the name * of the initial

Re: [11] RFR JDK-8191170: Clarify if java.class.path can be undefined

Hi Mandy, What is the “initial module”? Thanks, Paul. > On Jan 23, 2018, at 2:40 PM, mandy chung wrote: > > http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8191170/webrev.00/index.html > > A small adjustment in the javadoc. It clarifies what an empty value of >

Patch fixing JDK-8176553

Hi, I has prepared trivial patch for bug JDK-8176553, which I has reported. I will welcome if it could be merged into JDK. (The bug is present in JDK9 and JDK8 too.) I am covered by Red Hat OCA. The patch is attached, bug reproducer is already in JIRA:

Re: Microsecond support in java.time.Duration/Instant?

I'm not sure I want to bring this into the discussion, but there's a proposal (pushed largely by Facebook) for a timescale called the "flick" which is exactly 1/70560 second. Quote: "This unit of time is the smallest time unit which is LARGER than a nanosecond, and can in integer

[11] RFR JDK-8191170: Clarify if java.class.path can be undefined

http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8191170/webrev.00/index.html A small adjustment in the javadoc.  It clarifies what an empty value of "java.class.path" property is interpreted by the built-in application class loader. Mandy

Re: RFR: JDK-8161348 Several tools/jlink tests failed due to time out

Hi, After offline discussion with Leonid and with Igor in JBS we decided to skip test in case of -Xcomp option presence and do not increase timeout. Issue was faced in our build and test system only with -Xcomp flag. see updated patch http://cr.openjdk.java.net/~anazarov/JDK-8161348/webrev.02/

Re: [JDK 11] RFR: 8195096: Exception printed on console with custom LogManager on starting Apache Tomcat

Looks great! Personally, these LogManager startup issues make my head hurt. :) Jason From: Daniel Fuchs Sent: Tuesday, January 23, 2018 1:13 PM To: Jason Mehrens; core-libs-dev@openjdk.java.net Cc: Mandy Chung Subject: Re: [JDK

Re: RFR(XS): 8195824: tools/launcher/HelpFlagsTest.java fails with java.lang.AssertionError

Hi, I got the test results and I also manually tested on Windows, everything looks good, you can go ahead and push the changes. Thanks Kumar The last time around, I was missing the deploy repo and thus the build/test system did not take deploy into account. My error. I will retest and

Re: [10] RFR 8195970 Crash passing null to a VarHandle

Looks good to me.  This is very low risk and no objection from me to fix in 10. Mandy On 1/23/18 11:12 AM, Paul Sandoz wrote: Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8195970-varhandle-buffer-view-null/webrev/

Re: [JDK 11] RFR: 8195096: Exception printed on console with custom LogManager on starting Apache Tomcat

On 1/23/18 11:13 AM, Daniel Fuchs wrote: Hi Jason, I take it back :-) Mandy helped me finding better names to refactor the code, so here is a (hopefully) better version: http://cr.openjdk.java.net/~dfuchs/webrev_8195096/webrev.02/ I like this better.   Thank you for the update. 1220

Re: [JDK 11] RFR: 8195096: Exception printed on console with custom LogManager on starting Apache Tomcat

Hi Jason, I take it back :-) Mandy helped me finding better names to refactor the code, so here is a (hopefully) better version: http://cr.openjdk.java.net/~dfuchs/webrev_8195096/webrev.02/ best regards, -- daniel On 23/01/2018 10:27, Daniel Fuchs wrote: Hi Jason, On 22/01/2018 21:30,

[10] RFR 8195970 Crash passing null to a VarHandle

Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8195970-varhandle-buffer-view-null/webrev/ The ByteBuffer view VarHandle implements were (embarrassingly) missing a null check on the

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

+1 Naoto On 1/22/18 10:15 PM, Rachna Goel wrote: Hi, Kindly review updated patch for this doc fix: patch: http://cr.openjdk.java.net/%7Ergoel/8146656/webrev.02/ Approved CSR : https://bugs.openjdk.java.net/browse/JDK-8191414 Thanks, Rachna On 20/12/17 10:44 PM, joe darcy wrote: Hi

Re: RFR(XS): 8195824: tools/launcher/HelpFlagsTest.java fails with java.lang.AssertionError

The last time around, I was missing the deploy repo and thus the build/test system did not take deploy into account. My error. I will retest and report. Kumar Hi, I can not do proper tests with OracleJDK, sorry for that. This webrev removes the problem from the ProblemList:

Re: [JDK 11] RFR: 8195096: Exception printed on console with custom LogManager on starting Apache Tomcat

On 23/01/2018 15:44, mandy chung wrote: Isn't addLocalLogger called only when LogManager does not override addLogger? It's also called by ensureDefaultLogger(). -- daniel Mandy

Re: [JDK 11] RFR: 8195096: Exception printed on console with custom LogManager on starting Apache Tomcat

On 1/23/18 2:49 AM, Daniel Fuchs wrote: I did give it some consideration. I think this would be a mistake. The whole point of this fix is that loadLoggerHandlers *must* be called *within* addLogger - so that a subclass of LogManager that overrides addLogger can take over. Isn't

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

Looks fine. Regards, Roger On 1/23/2018 1:15 AM, Rachna Goel wrote: Hi, Kindly review updated patch for this doc fix: patch: http://cr.openjdk.java.net/%7Ergoel/8146656/webrev.02/ Approved CSR : https://bugs.openjdk.java.net/browse/JDK-8191414 Thanks, Rachna On 20/12/17 10:44 PM, joe

Re: Microsecond support in java.time.Duration/Instant?

Hi Kurt, I created an enhancement request in the Jira and linked the core-libs emails in.     https://bugs.openjdk.java.net/browse/JDK-8196003 Thanks for the frequency usage info.  Its hard to guess whether if micro APIs were available whether they would have been used instead of millis.

Re: [JDK 11] RFR: 8195096: Exception printed on console with custom LogManager on starting Apache Tomcat

Hi Jason, On 22/01/2018 21:30, Jason Mehrens wrote: Daniel, Fantastic! The patch looks good as is. The only > thing that sticks out is that both the 'if' and the 'else if' have the same code inside them. That could be refactored a bit. I had the same feeling - but then when looking at

Re: RFR: 8195976: Add JNDI test javax/naming/dns/AttributeTests/GetAny.java

Thank you Alan, I just moved it to com/sun/jndi/dns/ as you suggested and removed unused "@modules jdk.naming.dns/com.sun.jndi.dns”, updated webrev as below, thanks http://cr.openjdk.java.net/~xiaofeya/8195976/webrev.00/ Regards, Chris

Re: RFR 8139206: Add InputStream readNBytes(int len)

+ * Therefore, the method may be safely called with very large values of + * {@code len} provided sufficient memory is available. What does "sufficient memory" mean? For len, or the number of available bytes? --Max > On Jan 23, 2018, at 4:49 AM, Brian Burkhalter

RE: RFR(XS): 8195824: tools/launcher/HelpFlagsTest.java fails with java.lang.AssertionError

Hi, I can not do proper tests with OracleJDK, sorry for that. This webrev removes the problem from the ProblemList: http://cr.openjdk.java.net/~goetz/wr18/8195824-fixHelpTest2/webrev.02/ Actually, you should have an internal ProblemList for things that fail with the OracleJDK. We do so for SAP

Re: RFR 8139206: Add InputStream readNBytes(int len)

On 22/01/2018 21:27, Brian Burkhalter wrote: I have updated this verbiage in place in webrev.02 and webrev.01-02. Updated wording looks okay to me. -Alan