Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

Hi Ivan, looks good. Best Regards, Thomas On Wed, Jul 18, 2018 at 2:01 AM, Ivan Gerasimov wrote: > Hello! > > In the file WinNTFileSystem_md.c there is a potential leak of native handle > obtained from FindFirstFileW() in the unfortunate event of memory allocation > failure. > > Would you pleas

Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

Hi Ivan, looks good to me, although i am not the official reviewer. Thanks, Vyom On Wednesday 18 July 2018 05:31 AM, Ivan Gerasimov wrote: Hello! In the file WinNTFileSystem_md.c there is a potential leak of native handle obtained from FindFirstFileW() in the unfortunate event of memory a

Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

Thank you Brian for review! On 7/17/18 5:08 PM, Brian Burkhalter wrote: Hi Ivan, This looks all right to me. Thanks, Brian On Jul 17, 2018, at 5:01 PM, Ivan Gerasimov > wrote: In the file WinNTFileSystem_md.c there is a potential leak of native handle ob

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

PS This change is part of preparatory work to allow stricter checking of serial-related properties by the javac -Xlint:serial checks. So in the fullness of time, the work intended to be done under JDK-8202056: "Expand serial warning to check for bad overloads of serial-related methods" will ch

Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

Hi Ivan, This looks all right to me. Thanks, Brian On Jul 17, 2018, at 5:01 PM, Ivan Gerasimov wrote: > In the file WinNTFileSystem_md.c there is a potential leak of native handle > obtained from FindFirstFileW() in the unfortunate event of memory allocation > failure. > > Would you please

Re: RFR: 8206456 - [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mem

On 7/17/18 7:00 AM, Bob Vandette wrote: Please review this fix which eliminates some docker/cgroup test failures when running on older Linux kernels with missing cgroup metric files. BUGS: https://bugs.openjdk.java.net/browse/JDK-8206456 WEBREV: http://cr.openjdk.java.net/~bobv/8206456/webr

RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

Hello! In the file WinNTFileSystem_md.c there is a potential leak of native handle obtained from FindFirstFileW() in the unfortunate event of memory allocation failure. Would you please help review a simple fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8207750 WEBREV: http://cr.openj

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

Hi Joe > On Jul 17, 2018, at 7:32 PM, Joseph D. Darcy wrote: > > Hi Lance, > > On 7/17/2018 4:25 PM, Lance Andersen wrote: >> Hi Joe, >> >> +1 >> >> I assume we do not need to add a specific test for this clean-up? > > I put a "noreg-hard" label on the bug; I don't think it merits a dedicated

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

Hi Lance, On 7/17/2018 4:25 PM, Lance Andersen wrote: Hi Joe, +1 I assume we do not need to add a specific test for this clean-up? I put a "noreg-hard" label on the bug; I don't think it merits a dedicated test. Thanks, -Joe

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

Hi Joe, +1 I assume we do not need to add a specific test for this clean-up? > On Jul 17, 2018, at 7:19 PM, joe darcy wrote: > > Hello, > > The nested enum java.time.temporal.JulianFields.Field declare a > serialVersionUID field. Per the serialization spec, a serialVersionUID field > in an

Re: RFR [12] 8207748: Fix for 8202794 breaks tier1 builds

> On Jul 17, 2018, at 7:18 PM, Brian Burkhalter > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8207748.01 > > Diff included below. Build verified on Linux, macOS, and Solaris. > > Thanks, > > Brian > > --- a/src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c > +++

Re: RFR [12] 8207748: Fix for 8202794 breaks tier1 builds

+1 -Joe On 7/17/2018 4:18 PM, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8207748.01 Diff included below. Build verified on Linux, macOS, and Solaris. Thanks, Brian --- a/src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c +++ b/src/jdk.management/uni

JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

Hello, The nested enum java.time.temporal.JulianFields.Field declare a serialVersionUID field. Per the serialization spec, a serialVersionUID field in an enum is ignored. "The process by which enum constants are serialized cannot be customized: any class-specific writeObject, readObject, re

RFR [12] 8207748: Fix for 8202794 breaks tier1 builds

https://bugs.openjdk.java.net/browse/JDK-8207748.01 Diff included below. Build verified on Linux, macOS, and Solaris. Thanks, Brian --- a/src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c +++ b/src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c @@ -75,6

Re: 8202794: Native Unix code should use readdir rather than readdir_r

On 17 July 2018 at 19:13, Brian Burkhalter wrote: > > On Jul 17, 2018, at 9:05 AM, B. Blaser wrote: > > On 17 July 2018 at 09:46, Alan Bateman wrote: > > For serviceability-dev but I assume OperatingSystemImpl.c should move to > readdir64 to be consistent with the other usages. > > > I made this

Re: 8202794: Native Unix code should use readdir rather than readdir_r

On Jul 17, 2018, at 11:45 AM, Alan Bateman wrote: > On 17/07/2018 18:13, Brian Burkhalter wrote: >> >> I made this small change: >> >> http://cr.openjdk.java.net/~bpb/8202794/webrev.01/ > Looks okay. Thanks. >> : >> >> Is there any issue on file for these things? I could file one but perha

Re: 8202794: Native Unix code should use readdir rather than readdir_r

On 17/07/2018 18:13, Brian Burkhalter wrote: I made this small change: http://cr.openjdk.java.net/~bpb/8202794/webrev.01/ Looks okay. : Is there any issue on file for these things? I could file one but perhaps someone else already kno

Re: 8207393: ServiceLoader class description improvements

Hi Alan, The changes read well Best Lance > On Jul 17, 2018, at 6:46 AM, Alan Bateman wrote: > > [1] JDK-8207393 is suggestions from Alex Buckley to improve ServiceLoader's > class description and specifically to add a strong recommendation that an > application should not require the modules

Re: RFR 8205610: [TESTLIB] Improve listing of open file descriptors

Looks good, Roger Brian On Jul 17, 2018, at 7:16 AM, Roger Riggs wrote: > Please review a suggested improvement to the test library that lists open > file descriptors, > adding support for Solaris pfiles. > > webrev: > http://cr.openjdk.java.net/~rriggs/webrev-lsof-8205610/ > > Issue: >

Re: 8202794: Native Unix code should use readdir rather than readdir_r

On Jul 17, 2018, at 9:05 AM, B. Blaser wrote: > On 17 July 2018 at 09:46, Alan Bateman wrote: >> >> For serviceability-dev but I assume OperatingSystemImpl.c should move to >> readdir64 to be consistent with the other usages. I made this small change: http://cr.openjdk.java.net/~bpb/8202794

Re: 8143850: retrofit ArrayDeque to implement List

Hi again, I updated ArrayDeque with your last idea (adding all list methods but not implementing List) and added a subclass ArrayDeque.List which overrides equals and hashcode and implements List. There is also a subclass ArrayDeque.WithNulls that accepts null elements. ArrayDeque has removeAt(

Re: Adding new IBM extended charsets

History: I recall 15 years ago wondering why no one from IBM was maintaining the IBM charsets in the jdk. Today anything but UTF-* is increasingly legacy, so the case for including them is weaker than back then. Probably today the IBM charsets are best maintained outside the jdk sources as a thi

Re: 8202794: Native Unix code should use readdir rather than readdir_r

On 17 July 2018 at 09:46, Alan Bateman wrote: > On 17/07/2018 04:57, Brian Burkhalter wrote: >> >> https://bugs.openjdk.java.net/browse/JDK-8202794 >> >> Continues thread [1] with subject line updated to match the issue summary. >> Part of this general problem was addressed in [2]. >> >> The patch

Re: RFR 8205610: [TESTLIB] Improve listing of open file descriptors

The changes look good Roger > On Jul 17, 2018, at 10:16 AM, Roger Riggs wrote: > > Please review a suggested improvement to the test library that lists open > file descriptors, > adding support for Solaris pfiles. > > webrev: > http://cr.openjdk.java.net/~rriggs/webrev-lsof-8205610/ > > Is

RFR 8205610: [TESTLIB] Improve listing of open file descriptors

Please review a suggested improvement to the test library that lists open file descriptors, adding support for Solaris pfiles. webrev:     http://cr.openjdk.java.net/~rriggs/webrev-lsof-8205610/ Issue:     https://bugs.openjdk.java.net/browse/JDK-8205610 Thanks, Roger

RE: 8206456 - [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mem

Hi Bob, looks good (I am not a Reviewer however) ! The reported issues occured on a SUSE Linux 12 SP1 system , where /sys/fs/cgroup/cpuset/cpuset.effective_cpus and /sys/fs/cgroup/cpuset/cpuset.effective_memsare not present . I applied Bobs patch , now the jdk/internal/pl

Re: RFR 8189717: Too much documentation of ProcessBuilder.start copied to ProcessBuilder.startPipeline

The corresponding CSR is:   https://bugs.openjdk.java.net/browse/JDK-8207403 With a reviewer, it can be finalized sooner. Thanks, Roger On 7/13/2018 4:50 PM, Lance Andersen wrote: Hi Roger, +1 Have a great weekend! Best Lance On Jul 13, 2018, at 4:38 PM, Roger Riggs

RFR: 8206456 - [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mem

Please review this fix which eliminates some docker/cgroup test failures when running on older Linux kernels with missing cgroup metric files. BUGS: https://bugs.openjdk.java.net/browse/JDK-8206456 WEBREV: http://cr.openjdk.java.net/~bobv/8206456/webrev/ This fix has been verified by the report

Re: Adding new IBM extended charsets

Hi Alan, Thank you for your inputs. I would like to clarify that all the IBM charsets (IBM) in jdk.charsets are not IBM platform specific charsets. For example, only 43 charsets out of 72 IBM in jdk.charsets are EBCDIC or IBM platform specific charsets. Similarly, many charsets in the

Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

On 16/07/2018 14:53, Baesken, Matthias wrote: Hello, after latest comments from Alan and JaikiranI created a new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.2/ The jar file path is now printed in case jdk.includeInExceptions contains jarpath (this approa

RFR : 8207395: jar has issues with UNC-path arguments for the jar -C parameter [windows]

Please review this small fix for allowing windows UNC paths in the jar -C parameter. Currently passing a UNC path to a directory with -Cfails : c:\testdir>c:\tools\jdk10\bin\jar.exe test.jar -C \\MYMACHINE\subdir README.txt Illegal option: s Try `jar --help' for more information. W

8207393: ServiceLoader class description improvements

[1] JDK-8207393 is suggestions from Alex Buckley to improve ServiceLoader's class description and specifically to add a strong recommendation that an application should not require the modules that provide implementations of the service. The diffs for jdk/jdk are inlined below. I have already

Re: 8202794: Native Unix code should use readdir rather than readdir_r

On 17/07/2018 04:57, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8202794 Continues thread [1] with subject line updated to match the issue summary. Part of this general problem was addressed in [2]. The patch is in effect that proposed in thread [1] less the changes in [2]