Re: JVMInit function call - where is it located the source?

Ok, David. Great, you did it. From: David Holmes Sent: Tuesday, August 21, 2018 9:38:06 PM To: mr rupplin; core-libs-dev@openjdk.java.net; Andrew Haley Subject: Re: JVMInit function call - where is it located the source? On 22/08/2018 11:02 AM, mr rupplin wrote:

Re: JVMInit function call - where is it located the source?

On 22/08/2018 11:02 AM, mr rupplin wrote: Quickly, where do we look? I can't seem to find where the "javac" command is called in the C interface. javac is just the name of a executable launcher that is built. See make/launcher/Launcher-jdk.compiler.gmk Where is the java code that runs the

Re: JVMInit function call - where is it located the source?

Quickly, where do we look? I can't seem to find where the "javac" command is called in the C interface. Where is the java code that runs the parser/compiler? Ok, thanks gotta run ably. /mr From: mr rupplin Sent: Tuesday, August 21, 2018 6:37:30 PM To: core

Re: JVMInit function call - where is it located the source?

Thanks. Get Outlook for Android From: Andrew Haley Sent: Tuesday, August 21, 2018 12:32:20 PM To: mr rupplin; core-libs-dev@openjdk.java.net Subject: Re: JVMInit function call - where is it located the source? On 08/21/2018 05:21 PM, mr ru

Re: RFR(JDK12/JAXP/java.xml) 8209615: ParseError in XMLEventReader on a valid input

Thanks Lance! Yes, the test for 8158619 passed, as did all other xml tests. Best, Joe On 8/21/18, 12:01 PM, Lance Andersen wrote: Hi Joe, The change and test look fine. I assume the test for 8158619 is still happy :-) Best lance On Aug 21, 2018, at 2:17 PM, Joe Wang

Re: RFR(JDK12/JAXP/java.xml) 8209615: ParseError in XMLEventReader on a valid input

Hi Joe, The change and test look fine. I assume the test for 8158619 is still happy :-) Best lance > On Aug 21, 2018, at 2:17 PM, Joe Wang wrote: > > Hi, > > Please review a patch for a regression that was introduced in JDK 9 b147 by > the patch for JDK-8158619[1]. Prior to JDK-8158619, th

RFR(JDK12/JAXP/java.xml) 8209615: ParseError in XMLEventReader on a valid input

Hi, Please review a patch for a regression that was introduced in JDK 9 b147 by the patch for JDK-8158619[1]. Prior to JDK-8158619, the JDK parser returns all contiguous character data in a single chunk. After the patch then, the parser would return partially if the data is not read completel

Re: RFR: JDK-8205461 Create Collector which merges results of two other collectors

On 8/21/18 12:04 AM, Peter Levart wrote:  - UNORDERED: should the returned collector be UNORDERED if *either* of the provided collectors is UNORDERED? (Current draft says *both*.) I think *both* is the right behavior. If you are collecting:     teeingAndThen(         Collectors.toList(),      

Re: JVMInit function call - where is it located the source?

On 08/21/2018 05:21 PM, mr rupplin wrote: > Inside java.c there is a JLI_Launch which purports to be the launching or > entry point for the JVM. The last line shows: > > > return JVMInit(&ifn, threadStackSize, argc, argv, mode, what, ret); > > > This is given apparently as a function call tha

Re: JVMInit function call - where is it located the source?

Hi, I think you need to freshen up the search-fu: find, grep, and ack (beyondgrep). Without it, you would find understanding the structure of any large project, OpenJDK included, quite frustrating. On 08/21/2018 06:21 PM, mr rupplin wrote: > This is given apparently as a function call that will

Re: JVMInit function call - where is it located the source?

On 8/21/18 9:21 AM, mr rupplin wrote: Inside java.c there is a JLI_Launch which purports to be the launching or entry point for the JVM. The last line shows: return JVMInit(&ifn, threadStackSize, argc, argv, mode, what, ret); This is given apparently as a function call that will return a

JVMInit function call - where is it located the source?

Inside java.c there is a JLI_Launch which purports to be the launching or entry point for the JVM. The last line shows: return JVMInit(&ifn, threadStackSize, argc, argv, mode, what, ret); This is given apparently as a function call that will return an int. However the include file java.h sh

Re: Is returning a value != '0' or '1' as jboolean from a JNI function legal?

On 08/20/2018 08:25 PM, Jason Greene wrote: > >> On Aug 20, 2018, at 12:23 PM, Andrew Haley wrote: >> >> On 08/20/2018 04:14 PM, Jason Greene wrote: >> >>> IMO departing from C semantics (non-zero = TRUE, zero = false) >>> offers little gain and will likely just lead to hard to catch >>> bugs. Ev

Re: RFR 8209064: Make intellij support more robust after changes for 2018.2

Hi Maurizio! Even if this only incidentally relates to the build, please always include build-dev when making changes in the "make" directory. As far as I can understand, your changes looks good. One question: the build.xml was previously stored as a "template", and copied to the output dire

Re: RFR: JDK-8205461 Create Collector which merges results of two other collectors

I just note that sometimes naming is hard. Not because there would be no suitable name to choose from but because there are too many. In such situations it becomes apparent that every individual's brain works slightly differently. That said, I must admit that teeingAndThen is not my favorite ei

Re: RFR: JDK-8205461 Create Collector which merges results of two other collectors

Hi Stuart, On 08/21/2018 07:43 AM, Stuart Marks wrote: 2. Characteristics  - UNORDERED: should the returned collector be UNORDERED if *either* of the provided collectors is UNORDERED? (Current draft says *both*.) I think *both* is the right behavior. If you are collecting:     teeingAndThen