Please update the copyright year to "2018". Otherwise looks good to me.
No further review is needed.
Naoto
On 8/29/18 4:41 PM, li.ji...@oracle.com wrote:
Hi Naoto,
Please review the fix to update the currency symbol for VES.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8210153
Webrev:
htt
Hi Naoto,
Thanks for checking; cheers,
-Joe
On 8/28/2018 6:44 PM, naoto.s...@oracle.com wrote:
Hi Joe,
This is a typical currency data change, and does not involve any
public interface changes, so I think CSR is not needed. We haven't
filed CSRs for such changes in the past.
Naoto
On 8/2
Hi Naoto,
Please review the fix to update the currency symbol for VES.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8210153
Webrev:
http://cr.openjdk.java.net/~ljiang/8210153/webrev/
Built and tier1~tier3 tests passed on mach5.
Thanks,
Leo
On 8/29/18, 3:22 AM, Alan Bateman wrote:
The approach looks okay, I think just wonder if the test could be
expanded to cover entry with repeated leading slashes.
One nit is that hasAbsolutePath (and also the existing readOnly)
aren't final. One suggestion is for initCEN to return a CEN object
Looks fine.
On 28/08/2018 09:50, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8210039/webrev.00/index.html
698 lines changed: 114 ins; 240 del; 344 mod
Hi all,
could you please review this clean up of jdk testlibrary?
the patch updates the tests to use jdk.test.lib.Platform in
Hi Jim!
Why a new line is always added to the result of indent(int):
return stream.collect(Collectors.joining("\n", "", *"\n"*));
Because of this, a call to str.indent(0) depends on whether the string
is single-line or multi-line: In the former case it is unchanged, while
in the later case it
Thanks for taking this on.
Wait loops are notoriously hard to get right...
One sharp corner is that wait(0) waits forever, and TimeUnit conversion
truncates. You can probably avoid those problems via TimeUnit.timedWait.
In code like this in j.u.c. we try to optimize away the call to nanoTime
whe
Hi Roger!
This is of course a corner case, but now if you call
thread.join(Long.MAX_VALUE, 1) you'll get
IllegalArgumentException("timeout value is negative");
And the same with sleep(long, int).
Before the fix, the same would happen with join(Long.MAX_VALUE, 50),
which was also not quit
Please review changes for:
8098798: Thread.join(ms) on Linux still affected by changes to the
time-of-day clock
Use System.nanoTime to compute any remaining delay
8210004: Thread.sleep(millis, nanos) timeout returns early
Avoid an early return by rounding the milliseconds up if there
Hi Stephen,
On 08/28/2018 11:21 PM, Stephen Colebourne wrote:
So is there a way to achieve what you want for your test with existing API?
Probably. I could have a separate maven module creating a separate
modular jar file with the testing resource in it, and run the test
using both the classpat
SecurityProperties.java:
- Please add the copyright+license header to the new file.
- The "jdk.includeInExceptions" definition says there can be "Leading and
trailing whitespaces". You might need to call trim() on each token.
java.security:
- I would suggest saying "classes from the java.util.
Hi Max, thanks for your input .
I created another webrev , this contains now the suggested
SecurityProperties class :
http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.6/
Best regards, Matthias
> -Original Message-
> From: Weijun Wang
> Sent: Montag, 27. August 2018 17:35
>
Please review the code for String::align and String::indent at the link below.
Notes:
Includes a private version of String::isMultiline() which may be made
into a public method at some future date
Includes minor correctness clean up of StringLatin1.java,
StringUTF16.java
webre
Hello,
Not an Reviewer But just wanted to give a short Feedback: I like the new
Version it is really helpful.
However I wonder if the usage example should be outside of the apinote.
Given the existence of List.of() I wonder if you either mention it as a
alternative to the example (with slightl
On 29/08/2018 03:09, Xueming Shen wrote:
Hi,
Please help review the proposed change for JDK-8197398.
issue: https://bugs.openjdk.java.net/browse/JDK-8197398
webrev: http://cr.openjdk.java.net/~sherman/8197398/webrev
A little background:
The existing zipfs has an assumption that the "normal/he
Hi Stephen,
On 08/28/2018 11:21 PM, Stephen Colebourne wrote:
On Tue, 28 Aug 2018 at 20:43, Peter Levart wrote:
Do you think this functionality is really needed in programs? It seems useful
just for testing.
Why do people add classes at runtime? Might they not reasonably want
to also add res
16 matches
Mail list logo
