Hi,
I am currently testing many sort algorithms to improve the Marlin renderer
(AA 2D shape rasterizer), I integrated since OpenJDK9 and am still
improving for OpenJDK12 .
I created my MergeSort (top down, check for sorted parts, array / buffer
swap to minimize moves, isort on small sub arrays) t
Thank you David for the quick review.
Pushed.
Thanks,
Amy
On 2018/11/9 12:04 PM, David Holmes wrote:
Okay. Worth a try.
Thanks Amy.
David
On 9/11/2018 1:18 PM, Amy Lu wrote:
java/nio/channels/SocketChannel/AsyncCloseChannel.java
Please review this trivial fix to make this test run in othe
Okay. Worth a try.
Thanks Amy.
David
On 9/11/2018 1:18 PM, Amy Lu wrote:
java/nio/channels/SocketChannel/AsyncCloseChannel.java
Please review this trivial fix to make this test run in othervm to bring
Mach 5 back to green.
bug: https://bugs.openjdk.java.net/browse/JDK-8213576
This test fai
Hi Vicente,
On 9/11/2018 2:39 AM, Vicente Romero wrote:
Hi David, Igor
On 11/7/18 10:03 PM, David Holmes wrote:
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible to
see the actual substantive changes :(
ASM 7 also supports the Nestmate attributes and I was tryi
java/nio/channels/SocketChannel/AsyncCloseChannel.java
Please review this trivial fix to make this test run in othervm to bring
Mach 5 back to green.
bug: https://bugs.openjdk.java.net/browse/JDK-8213576
This test fails repeatedly in Mach 5 on osx-x64 (JDK-8213235) recently,
and the issue JDK
On 11/8/18 12:52 PM, Brian Burkhalter wrote:
Hi Daniel,
On Nov 8, 2018, at 1:50 AM, Daniel Fuchs wrote:
So FWIW my point was that there's nothing that you can really
guarantee in InputSteam::skipFully() if a subclass implementation of
skip() uses negative number to e.g. signal abnormal condit
On 11/8/18 7:41 AM, Roger Riggs wrote:
Webrev updated in place: (Only System.java is modified)
http://cr.openjdk.java.net/%7Erriggs/webrev-props-cleanup-8185496/index.html
Just notice this...
I wonder if System.setProperties(null) should call
VM.saveAndRemoveProperties(props) to be consist
Hi Daniel,
> On Nov 8, 2018, at 1:50 AM, Daniel Fuchs wrote:
>
> So FWIW my point was that there's nothing that you can really
> guarantee in InputSteam::skipFully() if a subclass implementation of
> skip() uses negative number to e.g. signal abnormal conditions
> (such as EOF?). And I wonder if
On 11/7/18 3:52 AM, Baesken, Matthias wrote:
Sorry, I haven't had time to look at this in more detail yet. But, let's
take a step back first. Can you or Matthias explain in more detail why
this fix is necessary? What are the use cases and motivation?
Hello,
adding paths (or maybe more det
Thank you, Andrew, for sending changes
I am fine with intrinsics general wording in JEP. I 'reviewed' JEP.
I have several questions and issues with proposed changes in Hotspot which needs to be discussed
during changes review. My main question is - should new nodes be treated as global memory b
Checked in. Thanks all for all of the great help!
Best regards,
Joe
On 11/7/18, 11:39 AM, Ivan Gerasimov wrote:
Thank you Joe!
I like the last variant.
With kind regards,
Ivan
On 11/7/18 9:59 AM, Joe Wang wrote:
Thanks Ivan!
I agree that the upfront edge case checks aren't really necessary
Hi David, Igor
On 11/7/18 10:03 PM, David Holmes wrote:
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible to
see the actual substantive changes :(
ASM 7 also supports the Nestmate attributes and I was trying to see
how/where that appeared but its somewhat obscur
On 11/8/18 8:14 AM, Alan Bateman wrote:
On 07/11/2018 19:33, Igor Ignatyev wrote:
Hi Vicente,
I recall an (internal?) discussion about updating ASM somewhen in JDK
11TF, and AFAIR it was decided not to update ASM b/c nothing in JDK
needs that, has it been changed? put somewhat differently,
Hi Claes,
yes, those template files bit me again. And the tools didn't save me (yet).
I wonder if it is worth the trouble to make the generated source files
be read-only...
Thanks, Roger
On 11/08/2018 10:50 AM, Claes Redestad wrote:
Hi Roger,
On 2018-11-08 16:41, Roger Riggs wrote:
Hi Ma
Hi Roger,
On 08/11/18 14:51, Roger Riggs wrote:
> If to achieve the performance or functional goals of the JEP hotspot
> changes are needed
> they should be mentioned (no details needed) in the JEP.
> It helps the reader understand the scope and impact of the change.
Thanks. I have added a brief
Hi Derek,
On 08/11/18 15:49, White, Derek wrote:
> Given that there is platform-specific code, it would be good to be
> clear which platforms you are intending to implement as part of this
> JEP, and which platforms will need others to step in to support.
>
> I'm quite happy with your plan, but
Hi Roger,
On 2018-11-08 16:41, Roger Riggs wrote:
Hi Mandy,
Webrev updated in place: (Only System.java is modified)
http://cr.openjdk.java.net/%7Erriggs/webrev-props-cleanup-8185496/index.html
Don't you need to update VersionProps.template.java, too?
/Claes
Hi Mandy,
Webrev updated in place: (Only System.java is modified)
http://cr.openjdk.java.net/%7Erriggs/webrev-props-cleanup-8185496/index.html
On 11/07/2018 07:19 PM, Mandy Chung wrote:
Hi Roger
On 11/6/18 8:17 AM, Roger Riggs wrote:
While working to reduce startup time initializing properti
Hi Sean,
I think we could still call the event
"jdk.SecurityPropertyModification", but add a @Description that explains
that events are only emitted for the JDK due to security concerns. If we
at a later stage want to include user events, we could add those and
remove the @Description, possib
Hi Jacob,
Its hard to resist the urge to add convenience methods, they look nice
and help a few developers.
However, they accumulate rapidly and end up obscuring the core
functionality.
They can hurt comprehension since they fold different functions together
and the collective API surface area
Hi,
Please approve the backport of JDK-8171049 to 8u-dev.
Master bug : https://bugs.openjdk.java.net/browse/JDK-8171049
Webrev for [8u-dev]: http://cr.openjdk.java.net/~rpatil/8171049/webrev.00/
JDK Review Thread:
http://mail.openjdk.java.net/pipermail/i18n-dev/2018-November/002682.htm
Hi Andrew,
If to achieve the performance or functional goals of the JEP hotspot
changes are needed
they should be mentioned (no details needed) in the JEP.
It helps the reader understand the scope and impact of the change.
Regards, Roger
On 11/08/2018 04:10 AM, Andrew Dinn wrote:
On 07/11/1
There was a typo in my last e-mail:
`.count("Java::equals")` should be `.count("Java"::equals)`
Thanks,
Jacob Glickman
On Thu, Nov 8, 2018 at 9:02 AM Jacob Glickman wrote:
> Tagir,
>
> Nothing is wrong with it, but I think the addition of the convenience
> method(s) would help to improve read
Tagir,
Nothing is wrong with it, but I think the addition of the convenience
method(s) would help to improve readability in some cases. Personally, I'd
much rather have the option of writing `.count("Java::equals")` than
`.filter("Java"::equals).count()`. As Zheka stated, this type of
convenience
Thanks for the clarification, Alan.
-Jaikiran
On Thursday, November 8, 2018, Alan Bateman wrote:
> On 08/11/2018 12:59, Jaikiran Pai wrote:
>>
>> A slightly related question - I used the example that Roger showed and
>> it mostly worked. However, Files.isSameFile throws a
>> java.nio.file.NoSuch
On 07/11/2018 19:33, Igor Ignatyev wrote:
Hi Vicente,
I recall an (internal?) discussion about updating ASM somewhen in JDK 11TF, and
AFAIR it was decided not to update ASM b/c nothing in JDK needs that, has it
been changed? put somewhat differently, why are we doing this?
in any case, I don'
On 08/11/2018 12:59, Jaikiran Pai wrote:
A slightly related question - I used the example that Roger showed and
it mostly worked. However, Files.isSameFile throws a
java.nio.file.NoSuchFileException since the path2 doesn't exist (on a
case sensitive file system). I checked the javadoc of Files.is
A slightly related question - I used the example that Roger showed and
it mostly worked. However, Files.isSameFile throws a
java.nio.file.NoSuchFileException since the path2 doesn't exist (on a
case sensitive file system). I checked the javadoc of Files.isSameFile
and couldn't find a clear mention
Hi Ichiroh,
sorry, but unfortunately, this change is way beyond my level of expertise :)
You should try to get a review from Sherman or Alan.
Regards,
Volker
On Fri, Oct 26, 2018 at 3:33 PM Ichiroh Takiguchi
wrote:
>
> Hello.
>
> Could you review the fix ?
>
> Bug:https://bugs.openjdk.java.
Hi Brian,
On 07/11/2018 23:37, Brian Burkhalter wrote:
http://hg.openjdk.java.net/jdk/jdk/file/44f34d2c3243/src/java.desktop/share/classes/com/sun/media/sound/AudioFloatInputStream.java#l99
The above class is not a descendent of InputStream. In any case, as
InputStream and all its “direct kno
What's wrong with `filter(predicate).count()`? Saving nine characters?
With best regards,
Tagir Valeev.
On Thu, Nov 8, 2018 at 8:02 AM Jacob Glickman wrote:
>
> Hello!
>
> I see myself having to often call count() as a terminal operation on a
> Stream immediately after performing a filter operat
On 07/11/18 17:12, Vladimir Kozlov wrote:
> I am Lead for Hotspot [1]. Alan is Group Lead for core libs and he gave
> review already.
>
> I don't see any reference to Hotspot in JEP so I am not sure what to
> review. Do you need any new optimizations/intrinsics in Hotspot for this
> JEP?
Yes I do
32 matches
Mail list logo
