Hello!
I wouldn't use presized HashSet, because you never know how many duplicates
are expected. What if the input stream has a million of elements, but only
two of them are distinct? Do you really want to allocate a hash table for
million elements in advance?
For toMap() without custom supplier
Tagir,
Great to see the validating benchmarks.
> I think it's the best solution given the fact that very few collectors may
benefit from the exact known size, and this benefit usually disappears when
collectors are composed (e.g. using groupingBy: downstream toList() would
not win anything if it
Hi Andy,
Revised webrev looks good.
Thanks,
Alexander
On 2/27/2019 4:41 PM, Andy Herrick wrote:
revised webrev at http://cr.openjdk.java.net/~herrick/8217902/webrev.02/
Do not Log a verbose message when cfg not found in getAppName() - just
use APP_NAME parameter as is done on Linux and Mac
revised webrev at http://cr.openjdk.java.net/~herrick/8217902/webrev.02/
Do not Log a verbose message when cfg not found in getAppName() - just
use APP_NAME parameter as is done on Linux and Mac
/Andy
On 2/26/2019 8:15 AM, Andy Herrick wrote:
JDK-8217902: jpackage fails with --app-image opt
That looks better.
Btw, the copyright header should only have a single "2019" (we don't
repeat the year for a file created and last modified in the same year).
You can fix this when you push.
Thanks.
-- Kevin
On 2/27/2019 4:24 PM, Alexander Matveev wrote:
Hi Kevin,
You right, comparison
looks good now.
/Andy
On 2/27/2019 7:24 PM, Alexander Matveev wrote:
Hi Kevin,
You right, comparison was not right. I fixed it.
http://cr.openjdk.java.net/~almatvee/8191709/webrev.01/
Thanks,
Alexander
On 2/26/2019 4:17 PM, Kevin Rushforth wrote:
The comparison isn't quite right. It will f
Hi Kevin,
You right, comparison was not right. I fixed it.
http://cr.openjdk.java.net/~almatvee/8191709/webrev.01/
Thanks,
Alexander
On 2/26/2019 4:17 PM, Kevin Rushforth wrote:
The comparison isn't quite right. It will fail if either the major or
minor is less than the minimum. This means, f
Wrong list. You want 2d-dev.
-phil.
On 2/27/19, 3:26 PM, Bernd Eckenfels wrote:
Hello,
(please let me know in case I picked the wrong list.)
Since OpenJDK does not ship Default *.ttf font files the change that a JRE is
installed in a way that no System Fonts can be found is quite high.
In O
jsr166 is sort-of an upstream project of openjdk and has its own mailing
list.
It looks like forkjoin changes were discussed here:
https://markmail.org/thread/ezvo7xf3xh6q2u2c
(and yeah, everyone has trouble understanding forkjoin implementation)
On Wed, Feb 27, 2019 at 2:10 PM Chris Dennis
wrote
Hello,
(please let me know in case I picked the wrong list.)
Since OpenJDK does not ship Default *.ttf font files the change that a JRE is
installed in a way that no System Fonts can be found is quite high.
In OpenJDK8 it is a bit unfortunate that in this situation even for the
headless graphi
On 2/10/2019 8:27 PM, Martin Buchholz wrote:
On Sun, Feb 10, 2019 at 8:24 PM David Holmes
wrote:
On 11/02/2019 2:20 pm, Martin Buchholz wrote:
On Sun, Feb 10, 2019 at 7:41 PM David Holmes mailto:david.hol...@oracle.com>> wrote:
> Still in limbo:
> 8203662: remove increment of
Hi All,
Apologies for dredging up an older mail thread. I lurk and follow along with
various JDK development threads and this 166 integration change jumped out at
me. I have to confess although I understood the intent of the change and the
explanation in the comments, like David I found it very
I had the same doubts about the @deprecation N+1 Policy. In both cases a „must
be deprecated in at least a LTS version“ would be more conservative (but
understandable very expensive)
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: core-libs-dev im Auftrag von Al
+1
Mandy
On 2/27/19 12:11 PM, Joe Darcy wrote:
Hello,
Please review the patch below to fix a small typo ("at" -> "as") in text
of Throwable introduced with some of the Project Coin changes.
Thanks,
-Joe
diff -r 2c50e900e8af src/java.base/share/classes/java/lang/Throwable.java
--- a/src/ja
Hi Joe,
+1
Brian
> On Feb 27, 2019, at 12:11 PM, Joe Darcy wrote:
>
> Please review the patch below to fix a small typo ("at" -> "as") in text of
> Throwable introduced with some of the Project Coin changes.
Hello,
Please review the patch below to fix a small typo ("at" -> "as") in text
of Throwable introduced with some of the Project Coin changes.
Thanks,
-Joe
diff -r 2c50e900e8af src/java.base/share/classes/java/lang/Throwable.java
--- a/src/java.base/share/classes/java/lang/Throwable.java
this looks good - at least for now.
I would like to eventually override the generated cpl.plist with a user
defined resource file.
/Andy
On 2/26/2019 10:10 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the
Thank you Christoph and Chris!
Change pushed.
Thanks,
Amy
On 2/27/19 6:03 PM, Chris Hegarty wrote:
+1
-Chris.
On 27/02/2019 09:31, Langer, Christoph wrote:
Hi Amy,
seems reasonable to me. +1
Best regards
Christoph
-Original Message-
From: core-libs-dev On Behalf
Of Amy Lu
Sent:
On 27/02/2019 10:18, Andrew Leonard wrote:
Hi,
Does anyone know if this JEP will be modified to cater for the shorter
release cycles and LTS releases?
https://bugs.openjdk.java.net/browse/JDK-8046172
The original Impact statement stated: "but even with this new policy
source code 10 or more years
Thanks for merging Roger
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com
From: Roger Riggs
To: Andrew Leonard , Mandy Chung
Cc: core-libs-dev@openjdk.java.net
Da
Hi,
Does anyone know if this JEP will be modified to cater for the shorter
release cycles and LTS releases?
https://bugs.openjdk.java.net/browse/JDK-8046172
The original Impact statement stated: "but even with this new policy
source code 10 or more years old should still be able to be compiled"
h
Thanks for all the reviews.
mach5-one-dchuyko-JDK-8215009-4-20190226-2029-850647: PASSED.
Pushed.
-Dmitry
On 2/27/19 12:07 AM, David Holmes wrote:
Hi Dmitry,
This seems fine to me too - much simpler.
Thanks,
David
On 27/02/2019 6:23 am, Dmitry Chuyko wrote:
I made mentioned cleanups in cha
+1
-Chris.
On 27/02/2019 09:31, Langer, Christoph wrote:
Hi Amy,
seems reasonable to me. +1
Best regards
Christoph
-Original Message-
From: core-libs-dev On Behalf
Of Amy Lu
Sent: Mittwoch, 27. Februar 2019 02:41
To: OpenJDK Dev list ; Core-Libs-Dev
Subject: [JDK 13] RFR 8219802:
Hi Amy,
seems reasonable to me. +1
Best regards
Christoph
> -Original Message-
> From: core-libs-dev On Behalf
> Of Amy Lu
> Sent: Mittwoch, 27. Februar 2019 02:41
> To: OpenJDK Dev list ; Core-Libs-Dev libs-...@openjdk.java.net>
> Subject: [JDK 13] RFR 8219802: Problem list
> java/net
24 matches
Mail list logo
