Re: The application requires 10.13 or later.

2019-04-03 Thread Philip Race
JDK 11 runs on older versions. I don't see where that message would come from in the jpackage code but I could just be missing it. It may be more to do with you having run jpackage on 10.13 and the question is can it target an earlier version of MacOS than the one on which the .pkg is created ? -

The application requires 10.13 or later.

2019-04-03 Thread Kustaa Nyholm
Hi, last night I released a new version of my app and one of the testers reported he gets a dialog that says: "You can't use this version of the application with this version of OS X. You havew OS X 10.11.6. The application requires 10.13 or later." Now this is a first version of this particula

Re: Robot.mouseMove() in macOS Mojave

2019-04-03 Thread Philip Race
awt-dev. But try including the exact jdk version + a test case when you do since I am not sure that exact issue has been seen. Problems with needing to allow accessibility is the mojave specific issue I can recall. -phil. On 4/3/19, 10:56 PM, David Holmes wrote: Hi Kusti, The folks on swin

Re: Robot.mouseMove() in macOS Mojave

2019-04-03 Thread David Holmes
Hi Kusti, The folks on swing-dev or awt-dev are probably the ones most likely to be able to assist. Cheers, David On 4/04/2019 3:51 pm, Kustaa Nyholm wrote: Hi, I've got an application where zooming with the scroll wheel on the mouse will also center the mouse on the screen (well window a

Robot.mouseMove() in macOS Mojave

2019-04-03 Thread Kustaa Nyholm
Hi, I've got an application where zooming with the scroll wheel on the mouse will also center the mouse on the screen (well window actually). This has worked since day one for some 15 years. The mouse centring is implemented with Robot.mouseMove() method. This morning I received a message from

Re: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

2019-04-03 Thread Brian Burkhalter
Hi Raffaello, et. al. > On Apr 3, 2019, at 7:43 AM, Raffaello Giulietti > wrote: > > in this patch there are additional white-box tests against critical package > private entities in the jdk.internal.math classes. In particular the class > jdk.internal.math.MathUtils is thoroughly tested. >

Re: RFR: JDK-8221876:[macOS] JPackage install takes long time

2019-04-03 Thread Alexander Matveev
Hi Semyon, Looks good. Thanks, Alexander On 4/3/2019 2:30 PM, semyon.sadet...@oracle.com wrote: Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8221876 webrev: http://cr.openjdk.java.net/~ssadetsky/8221876/webrev.00/ The fix eliminate delay in install which is caused by postinstall sc

RFR: JDK-8221876:[macOS] JPackage install takes long time

2019-04-03 Thread semyon . sadetsky
Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8221876 webrev: http://cr.openjdk.java.net/~ssadetsky/8221876/webrev.00/ The fix eliminate delay in install which is caused by postinstall script introduced in 8215241 when it set permissions for large number of files. Actually setting perm

Re: RFR: JDK-8208652: JPackageCreateInstallerFileAssociationsTest.java fails on Mac.

2019-04-03 Thread Alexander Matveev
Hi Semyon, Looks good. I assume you did run all tests on all platforms, since it is shared code for most tests. Thanks, Alexander On 4/3/2019 12:16 PM, semyon.sadet...@oracle.com wrote: Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8208652 webrev: http://cr.openjdk.java.net/~ssadets

RFR: JDK-8208652: JPackageCreateInstallerFileAssociationsTest.java fails on Mac.

2019-04-03 Thread semyon . sadetsky
Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8208652 webrev: http://cr.openjdk.java.net/~ssadetsky/8208652/webrev.00 It is a fix for a test issue on Mac. Unlikely other platforms Mac platform sends the file path to open in a special OS OpenFile event the application should handle. The

Re: [PATCH] Some improvements for java.lang.Class

2019-04-03 Thread Brian Goetz
I agree that getting rid of the append(concatenation) is a good move regardless; that’s just wasteful movement. The rest of the patch seems harmless. As to applying the refactor more broadly, there’s a risk of recreating the “append(concatenation)” problem, where the concatenation is hidden

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

2019-04-03 Thread Lindenmaier, Goetz
Hi Maurizio, I put your java PoC into a webrev, and added some tests: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/06-java-Maurizio/ Please have a look at NullPointerExceptionTestMini4.java. It is failing, as the class does not reside in a file. Do you have an idea how to fix this?

Re: RFR: 8221701: Archive constant BaseLocales

2019-04-03 Thread Claes Redestad
Hi Naoto, On 2019-04-03 05:25, naoto.s...@oracle.com wrote: Hi Claes, The new version looks good, and I like this approach better. Simpler and easily maintainable IMO. Also I like the improved startup time, which I think is more important than multiple creation of Locale instances, which is

Re: RFR: 8221397 Support implementation-defined Map Modes

2019-04-03 Thread Andrew Dinn
Hi Alan, Thanks for reviewing this patch. On 02/04/2019 11:22, Alan Bateman wrote: > On 02/04/2019 10:12, Andrew Dinn wrote: >> Could I please have reviews for the following enhancement: >> >> JIRA:   https://bugs.openjdk.java.net/browse/JDK-8221397 >> webrev: http://cr.openjdk.java.net/~adinn/82