RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-14 Thread Patrick Zhang OS
Hi David, Many thanks, I integrated your updates into the new patch. > I think STACK_SIZE_MINIMUM is an empirical value, NOT suitable for 'all' > platforms, at least not that safe, for example, a tricky experiment is: > create the initial thread with 320K, and have later VM inner threads

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-14 Thread David Holmes
Hi Patrick, Please see: http://cr.openjdk.java.net/~dholmes/8222334/webrev/ for my suggested updates to the commentary. Note that GetDefaultJavaVMInitArgs returns the build-time default stack sizes and so will only return 0 (for "use the system default") on Windows. It is not affected by

RFR: JDK-8222439: New jpackage test fails on mac, linux

2019-04-14 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222439 [2] http://cr.openjdk.java.net/~herrick/8222406/