RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

Removed it. http://cr.openjdk.java.net/~qpzhang/8222334/webrev.03/jdk.changeset By the way, could you please sponsor to push it once approved? thanks in advance. Regards Patrick -Original Message- From: David Holmes Sent: Monday, April 15, 2019 2:33 PM To: Patrick Zhang OS ; core-li

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

On 15/04/2019 5:34 pm, Patrick Zhang OS wrote: Removed it. http://cr.openjdk.java.net/~qpzhang/8222334/webrev.03/jdk.changeset By the way, could you please sponsor to push it once approved? thanks in advance. Sure - if the core-libs person who also reviews doesn't volunteer (hint hint ;-) )

RFR: 8222484: Specialize generation of simple String concatenation expressions

Hi, please review this enhancement to specialize a few simple and common String concatenation patterns in the default strategy. Bug:https://bugs.openjdk.java.net/browse/JDK-8222484 Webrev: http://cr.openjdk.java.net/~redestad/8222484/open.00/ This reduces first-time bootstrap times for the

RE: RFR(trivial): 8222394: HashMap.compute() throws CME on an empty Map if clear() called concurrently

Hi Stuart, Thanks. I intentionally modified the map in remapping functions, just like those tests in http://hg.openjdk.java.net/jdk/jdk/file/00c0906bf4d1/test/jdk/java/util/Map/FunctionalCMEs.java. My original tests were: create two threads, modify or perform read-only operations in each, and

Re: RFR: JDK-8222439: New jpackage test fails on mac, linux

Looks fine. -- Kevin On 4/14/2019 7:16 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222439 [2] http://cr.openjdk.java.net/~

Re: RFR: 8222484: Specialize generation of simple String concatenation expressions

The StringConcatHelper::valueOf really should be StringConcatHelper::stringOf to clarify the result. Use here is unlike String::valueOf context where the result is logically String. StringConcatHelper::mix comments really should describe the encoding. If does a lot of handwaving re checking for

Re: RFR: 8222484: Specialize generation of simple String concatenation expressions

Hi Jim, thanks for reviewing, and it's fair that we seek to improve comments and readability of this code while we're at it: http://cr.openjdk.java.net/~redestad/8222484/open.01/ Also fixed so we're starting with the value of initialCoder() rather than 0L for documentation purposes. Using initi

RFR: 8222486: Reorder sample usage in jpackage help output

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222486 [2] http://cr.openjdk.java.net/~herrick/8222486/ /Andy

Re: ZipFileSystem performance regression

I have made a small command-line utility which creates zip archives by compressing the input files in parallel. I do this by calling Files.copy(input, zipOutputStream) in a parallel Stream over all input files. I have run this with Java 1.8, 9, 10, and 11, on both my local laptop and on server

Re: RFR: 8222484: Specialize generation of simple String concatenation expressions

On 2019-04-15 15:10, Claes Redestad wrote: This reduces first-time bootstrap times for the targeted patterns from ~20ms to be lost in the noise on my machine (so ~0.5ms), while being peak performance neutral and not regressing bootstrap characteristics on more complex patterns. Correction: I ac

Re: RFR: 8222486: Reorder sample usage in jpackage help output

Looks good. -- Kevin On 4/15/2019 6:32 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222486 [2] http://cr.openjdk.java.net/

Re: ZipFileSystem performance regression

Hi Lennart, I can reproduce this locally, and have narrowed down to https://bugs.openjdk.java.net/browse/JDK-8034802 as the cause. As you say the compression is deferred to ZipFileSystem.close() now, whereas previously it happened eagerly. We will have to analyze the changes more in-depth to try

RFR (JDK 13/java.xml) 8222415: Xerces 2.12.0: Parsing Configuration

Please review an update from Xerces in the configuration area. The patch contains changes not easily measurable with test (e.g. a few bytes for a parse, or small leaks for a file as large as a GB, or none at all). But the change does improve in that a method ( readAndBuffer) that explicitly buf

Re: RFR: 8222486: Reorder sample usage in jpackage help output

Hi Andy, Looks good. Thanks, Alexander On 4/15/2019 6:32 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222486 [2] http://cr

Re: SoftReference incorrect javadoc?

Hi Michael, Re-directing to core-libs-dev and hotspot-gc-dev. Thanks, David On 16/04/2019 12:14 pm, Michael Pollmeier wrote: Quoting https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/ref/SoftReference.html All soft references to softly-reachable objects are guaranteed t

Re: SoftReference incorrect javadoc?

Hi Michael, On 4/16/19 4:19 AM, David Holmes wrote: Hi Michael, Re-directing to core-libs-dev and hotspot-gc-dev. Thanks, David On 16/04/2019 12:14 pm, Michael Pollmeier wrote: Quoting https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/ref/SoftReference.html All sof