On 01/05/2019 02:59, Joe Darcy wrote:
:
--- a/src/java.base/share/classes/java/nio/file/FileSystems.java Tue
Apr 30 16:11:42 2019 -0700
+++ b/src/java.base/share/classes/java/nio/file/FileSystems.java Tue
Apr 30 18:52:11 2019 -0700
@@ -252,10 +252,9 @@
* Suppose there is a provider iden
Hello,
The readability of usage example for FileSystems.newFileSystem would
benefit from using a method to create a map from JEP 269: "Convenience
Factory Methods for Collections." The current example is rendered in
javadoc as
Map env = new HashMap<>();
env.put("capacity", "16G");
e
Hi Andy,
Looks good overall.
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/Info-lite.plist.template.html
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources
I have a couple nit-picky comments:
1. The change to src/jdk.jlink/share/classes/module-info.java is
unrelated to jpackage and should be reverted (there is only a
white-space change and a copyright date change to that file)
2. The following files have whitespace errors that will cause jcheck
A couple of questions / observations :-
1) setlocale
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/linux/native/jpackageapplauncher/launcher.cpp.html
52 int main(int argc, char *argv[]) {
53 int result = 1;
54 setlocale(LC_ALL, "en_US.utf8");
Why is this
Hi Vicente,
CSR reviewed.
I suggesting adding a test case for
cd.nested("good", null)
Thanks,
-Joe
On 4/29/2019 2:41 PM, Vicente Romero wrote:
Hi Joe,
Thanks for the review. I have modified the patch, please see [1] . I
still need a reviewer for the CSR [2],
Vicente
[1] http://cr.o
I've had no takers. Please take the time. Thank you.
-- Jim
> On Apr 26, 2019, at 2:57 PM, Jim Laskey wrote:
>
> Please review. Thank you.
>
> Cheers,
>
> -- Jim
>
>
>
> Summary: Add the method ClassDesc::displayFullName to return the fully
> qualified class name from a ClassDesc. Add a
I think these benchmarks looks OK. Thanks for doing this!
/Claes
On 2019-04-30 20:15, Martin Buchholz wrote:
Webrev updated.
More comments.
I now use
@Param("999")
public int size;
All values of @Param are plausible, so only including one representative
one.
Webrev updated.
More comments.
I now use
@Param("999")
public int size;
All values of @Param are plausible, so only including one representative
one.
On Mon, Apr 29, 2019 at 2:56 PM Claes Redestad
wrote:
>
> This should work:
>
> make test TEST="micro:foo" MICRO="OPTIONS=-p SIZE=1024,2048"
>
Thanks for the help! Something like this should go into doc/testing.md
I found that running one value of the param at a time works best for me:
(cd $(
Hello Tagir!
On 4/30/19 8:57 AM, Tagir Valeev wrote:
Hello!
New webrev looks good. Probably it worth adding a testcase for
overflow (assert that OOME is thrown)? I guess, something like
"1".repeat(65536).replace("1", "1".repeat(65536)) would produce OOME
quite fast and without allocating much
Hello!
New webrev looks good. Probably it worth adding a testcase for
overflow (assert that OOME is thrown)? I guess, something like
"1".repeat(65536).replace("1", "1".repeat(65536)) would produce OOME
quite fast and without allocating much memory.
With best regards,
Tagir Valeev.
On Tue, Apr 30
Hi,
it turned out that there was a regression in my last version. I needed to fix
some initializations in the constructor of Entry. I also added some other fixes
found by the IDE’s code analysis to ZipFileSystem.java.
By accident, I updated the last webrev in-place. So, please find my most
cur
Hi Martin,
Thanks for pushing this. :)
I'm not familiar with the jsr166 CVS system though, or the process of
aiding a commit to it.
Is there anything further I can do here?
Best Regards
Adam Farley
IBM Runtimes
David Holmes wrote on 30/04/2019 08:51:24:
> From: David Holmes
> To: Martin
Hi Martin,
On 30/04/2019 4:00 am, Martin Buchholz wrote:
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html
8222930: ConcurrentSkipListMap.clone() shares size variable between
original and clone
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/Con
On 4/30/19 6:43 AM, Ivan Gerasimov wrote:
I used StringConcatHelper.newArray() to avoid bringing Unsafe into
StringLatin1.
In the StringLatin1.replace(), the newly allocated array is guaranteed
to be filled up, and the filling code should never throw, so I believe
using uninitialized arrays
16 matches
Mail list logo
