Re: RFR: 8212700: Change the mechanism by which JDK loads the platform-specific AWT Toolkit

On 5/6/19, 3:11 PM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8212700 CSR: https://bugs.openjdk.java.net/browse/JDK-8223417 Webrev: https://cr.openjdk.java.net/~prr/8212700 Please review this bug + CSR to remove the awt.headless system property. That would be awt.toolki

RFR: 8212700: Change the mechanism by which JDK loads the platform-specific AWT Toolkit

Bug: https://bugs.openjdk.java.net/browse/JDK-8212700 CSR: https://bugs.openjdk.java.net/browse/JDK-8223417 Webrev: https://cr.openjdk.java.net/~prr/8212700 Please review this bug + CSR to remove the awt.headless system property. This should be the last of the fixes to remove use of system prope

Re: RFR 8222955 : Optimize String.replace(CharSequence, CharSequence) for Latin1 encoded strings

Looks ok to me. /Claes On 2019-05-06 21:42, Ivan Gerasimov wrote: Hello everyone! I'm seeking a (capital R) Reviewer to review/approve the fix, so I could go ahead and push it. The latest webrev contains an additional testcase for OOM suggested by Tagir. BUGURL: https://bugs.openjdk.java

Re: RFR 8222955 : Optimize String.replace(CharSequence, CharSequence) for Latin1 encoded strings

Thank you Claes! On 5/6/19 12:53 PM, Claes Redestad wrote: Looks ok to me. /Claes On 2019-05-06 21:42, Ivan Gerasimov wrote: Hello everyone! I'm seeking a (capital R) Reviewer to review/approve the fix, so I could go ahead and push it. The latest webrev contains an additional testcase fo

Re: [13] RFR: 8220037: Inconsistencies of generated timezone files between Windows and Linux

Thanks, Roger. Webrev is modified accordingly: http://cr.openjdk.java.net/~naoto/8220037/webrev.01/ Naoto On 5/6/19 11:59 AM, Roger Riggs wrote: Hi Naoto, CLDRConverter:  358-271: Is a lambda viable here?  Not significantly different, just a more contemporary style.     (o1, o2) -> {...}.

Re: RFR 8222955 : Optimize String.replace(CharSequence, CharSequence) for Latin1 encoded strings

Hello everyone! I'm seeking a (capital R) Reviewer to review/approve the fix, so I could go ahead and push it. The latest webrev contains an additional testcase for OOM suggested by Tagir. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8222955 WEBREV: http://cr.openjdk.java.net/~igerasim/

Re: [13] RFR: 8220037: Inconsistencies of generated timezone files between Windows and Linux

Hi Naoto, CLDRConverter:  358-271: Is a lambda viable here?  Not significantly different, just a more contemporary style.     (o1, o2) -> {...}. CLDRDisplayNamesTest.java:  136-137, 155, 158:  Another option is to have the stream return the count of the number of errors and use peek to print t

[13] RFR: 8220037: Inconsistencies of generated timezone files between Windows and Linux

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8220037 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8220037/webrev.00/ The inconsistency comes from the different enumeration order of CLDR source files on each platform. Fix i

[PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

Hi, no new code this time, only a warm invitation to review the rather substantial patch submitted on 2019-04-18 [1] and the CSR [2]. I spent an insane amount of (unpaid) free time offering my contribution to solve a bug known since about 15 years. Thus, I think it is understandable that I'd

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, incorporating comments by Coleen, I prepared a new webrev: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/08/ incremental webrev: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/08-incremental/ I renamed the following new classes: TrackingStackCreator -> ExcpetionMessa