RE: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi, here is a little update to my latest webrev: http://cr.openjdk.java.net/~clanger/webrevs/8213031.11/ I had to make modifications to fix test errors and enhance testing: a) in initOwner/initGroup the UOE has to be catched and handled explicitly as it is never wrapped into PAE because it is a

RFR: 8224656: Problem list java/security/SecureClassLoader/DefineClass.java until JDK-8224635 is fixed

Hi, Please find a patch below that temporarily problem lists java/security/SecureClassLoader/DefineClass.java on linux and windows until JDK-8224635 [1] is fixed: 8224656: Problem list java/security/SecureClassLoader/DefineClass.java until JDK-8224635 is fixed https://bugs.openjdk.java.

Re: RFR: 8224656: Problem list java/security/SecureClassLoader/DefineClass.java until JDK-8224635 is fixed

On 23/05/2019 10:32, Daniel Fuchs wrote: Hi, Please find a patch below that temporarily problem lists java/security/SecureClassLoader/DefineClass.java on linux and windows until JDK-8224635 [1] is fixed: 8224656: Problem list java/security/SecureClassLoader/DefineClass.java until JDK-8

Re: RFR: 8224656: Problem list java/security/SecureClassLoader/DefineClass.java until JDK-8224635 is fixed

Looks good! Thanks Daniel. David On 23/05/2019 7:32 pm, Daniel Fuchs wrote: Hi, Please find a patch below that temporarily problem lists java/security/SecureClassLoader/DefineClass.java on linux and windows until JDK-8224635 [1] is fixed: 8224656: Problem list java/security/SecureClassLoader/

Re: RFR: 8224656: Problem list java/security/SecureClassLoader/DefineClass.java until JDK-8224635 is fixed

Daniel, > On 23 May 2019, at 10:32, Daniel Fuchs wrote: > > Hi, > > Please find a patch below that temporarily problem lists > java/security/SecureClassLoader/DefineClass.java > on linux and windows until JDK-8224635 [1] is fixed: > > 8224656: Problem list java/security/SecureClassLoader/Defin

RFR: 8207851: Implement JEP 352

Hi, Could I please have reviews of the following change set which implements JEP 352: JEP:https://openjdk.java.net/jeps/352 JIRA: https://bugs.openjdk.java.net/browse/JDK-8207851 webrev: http://cr.openjdk.java.net/~adinn/8207851/webrev.00/ I would also very much like to target this impleme

Re: RFR: 8224202: Speed up Properties.load

Hi Ivan! On 2019-05-23 02:11, Ivan Gerasimov wrote: Hi Claes! A few comments: 1)  571 if (len == lineBuf.length) {  572 int newLength = ArraysSupport.newLength(lineBuf.length, 1, lineBuf.length); could be written slightly shorter as  571 

RE: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Stuart, big thanks for your great updates here. This all looks a lot cleaner: http://cr.openjdk.java.net/~clanger/webrevs/8223553.3/ So, for ConcurrentSkipListMap.java, the new coding is a real improvement, removing a @SuppressWarnings("unchecked") and a cast which are both unnecessary then

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

On 23/05/2019 14:39, Langer, Christoph wrote: big thanks for your great updates here. This all looks a lot cleaner:http://cr.openjdk.java.net/~clanger/webrevs/8223553.3/ I concur. Thanks Stuart! best regards, -- daniel

Re: [13] RFR: 8221431: Support for Unicode 12.1

Build changes look good. /Erik On 2019-05-22 18:36, naoto.s...@oracle.com wrote: Hi Erik, Thank you for your comments. Updated the webrev accordingly: https://cr.openjdk.java.net/~naoto/8221431/webrev.04/ Naoto On 5/22/19 4:13 PM, Erik Joelsson wrote: Hello Naoto, In GensrcEmojiData.gmk:

Re: RFR: 8224202: Speed up Properties.load

Hi Claes, Looking good. Is there any performance benefit to using ?: instead of if..else at Line 509-515    c = (fromStream) ? (char) (byteBuf[off++] & 0xFF) : charBuf[off++]; Line 578-581:   precedingBackslash = (c == '\\') ? !precedingBackslash : false; Line 600:  add 'the"  to "characte

Re: RFR: 8224202: Speed up Properties.load

Hi Roger, On 2019-05-23 16:42, Roger Riggs wrote: Hi Claes, Looking good. Is there any performance benefit to using ?: instead of if..else at Line 509-515    c = (fromStream) ? (char) (byteBuf[off++] & 0xFF) : charBuf[off++]; Line 578-581:   precedingBackslash = (c == '\\') ? !precedingBack

Re: RFR: 8224202: Speed up Properties.load

Hi Claes! Looks good to me! The comment 630 // Reset the shared buffer should probably be moved down to 645 out.setLength(0); With kind regards, Ivan On 5/23/19 5:57 AM, Claes Redestad wrote: Hi Ivan! On 2019-05-23 02:11, Ivan Gerasimov wrote: Hi Claes! A few comments:

Re: RFR: 8224202: Speed up Properties.load

On 2019-05-23 18:28, Ivan Gerasimov wrote: Hi Claes! Looks good to me! Thanks Ivan, I'll fix up the comments before push. /Claes

Need help with OpenJDK sandbox branch creation

Hi, sorry for wide distribution, but I am at my wits’ end and need help. I have finished writing the code for the new JEP on "Enhanced pseudo-random number generators” (https://bugs.openjdk.java.net/browse/JDK-8193209) and am now trying to follow the instructions at https://cr.openjdk.j

Re: Need help with OpenJDK sandbox branch creation

You need to be a 'jdk' Project Committer [1] in order to push to any repo in the jdk Project, including the sandbox. -- Kevin [1] https://openjdk.java.net/census#jdk On 5/23/2019 11:16 AM, Guy Steele wrote: Hi, sorry for wide distribution, but I am at my wits’ end and need help. I have fini

Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

Hello! Do you think it's good to go now? Thanks in advance, Ivan On 5/20/19 12:26 PM, Ivan Gerasimov wrote: Thank you Jon and Alan for your suggestions! Here's the new webrev updated accordingly: http://cr.openjdk.java.net/~igerasim/7061590/01/webrev/ With kind regards, Ivan On 5/20/19

Re: Need help with OpenJDK sandbox branch creation

> On May 23, 2019, at 2:23 PM, Kevin Rushforth > wrote: > > You need to be a 'jdk' Project Committer [1] in order to push to any repo in > the jdk Project, including the sandbox. > > -- Kevin > > [1] https://openjdk.java.net/census#jdk Yep, that’ll do it. Thanks!

Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

On 23/05/2019 19:25, Ivan Gerasimov wrote: Hello! Do you think it's good to go now? Thanks in advance, This version looks okay to me. -Alan

RFR: JDK-8223643: Provide better defined context for custom installer steps on Windows

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). src\jdk.jpackage\windows\classes\jdk\jpackage\internal\WinMsiBundler.java:  - code running candle.exe on WiX sources reworked. Before the fix template.

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

On 5/23/19 6:39 AM, Langer, Christoph wrote: big thanks for your great updates here. This all looks a lot cleaner: http://cr.openjdk.java.net/~clanger/webrevs/8223553.3/ Great, glad to help. While I'm still unsure about the underlying reasons for this disagreement between the compilers, th

Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

Thank you Alan! On 5/23/19 11:35 AM, Alan Bateman wrote: On 23/05/2019 19:25, Ivan Gerasimov wrote: Hello! Do you think it's good to go now? Thanks in advance, This version looks okay to me. -Alan -- With kind regards, Ivan Gerasimov

Re: RFR - JDK-8223775 String::stripIndent (Preview)

Hi, I have a couple questions/comments about the special treatment of the last line in a text block. -- In the CSR we have: "3. If the last line in the list of individual lines (i.e., the line with the text block closing delimiter) is blank, then add it to the set of determining lines. (The

openjdk jpackage bug

Hello, I can not post bug on jdk bug database. I encounter the following problem on Mac OS Mojave 10.14.5. Execution of the order: clear; rm -rf ./tmpjpackage/ ./garbage/; ~ / jdk-13.jdk / Contents / Home / bin / jpackage create-installer --temp-root ./tmpjpackage/ --installer-type pkg -o ./g

Re: RFR: jsr166 integration 2019-06

Adding trivial fix 8224698: ConcurrentSkipListMap.java does not compile with the Eclipse Java Compiler https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/ecj/index.html https://bugs.openjdk.java.net/browse/JDK-8224698 On Thu, May 16, 2019 at 2:58 PM Martin Buchholz wrote: > > ht

RE: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

> Overall, introducing a local variable is more-or-less reasonable even if it's > used only once. One point is that somebody might come along and "clean > up" the > code and inline local variables and reintroduce the problem. Another point is > that, hypothetically, if in the future Eclipse is chan

Re: RFR: JDK-8223643: Provide better defined context for custom installer steps on Windows

Hi Alexey, Looks fine. Thanks, Alexander On 5/23/2019 11:57 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). src\jdk.jpackage\windows\classes\jdk\jpackage\internal\WinMsi

Re: RFR - JDK-8223775 String::stripIndent (Preview)

Hi, Jim I have a few comments on the webrev. src/java.base/share/classes/java/lang/String.java 2982 private static int outdent(List lines) { Can you please add a doc comment for what this method does? 2973 .map(line -> { 2974 int firstNonWhitespace = line.indexOfNonWhitespace(); 29

RFR 8224682: Remove the com.sun.CORBA.ORBIorTypeCheckRegistryFilter security property

Hi all, Please review the fix for 8224682 which removes this legacy property left over from the removal from CORBA The webrev can be found: http://cr.openjdk.java.net/~lancea/8224682/webrev.00/ Best lance

Re: RFR 8224682: Remove the com.sun.CORBA.ORBIorTypeCheckRegistryFilter security property

Looks fine. I guess you'll want to update/add the Copyright year in JDKSecurityProperties.java. -Brent On 5/23/19 3:58 PM, Lance Andersen wrote: Hi all, Please review the fix for 8224682 which removes this legacy property left over from the removal from CORBA The webrev can be found: http

Re: RFR 8224682: Remove the com.sun.CORBA.ORBIorTypeCheckRegistryFilter security property

Thank you Brent for the review. > On May 23, 2019, at 7:10 PM, Brent Christian > wrote: > > Looks fine. I guess you'll want to update/add the Copyright year in > JDKSecurityProperties.java. Ah, forgot that, update below: —— $ hg diff test/lib/jdk/test/lib/security/JDKSecurityProperties.

Re: RFR 8224682: Remove the com.sun.CORBA.ORBIorTypeCheckRegistryFilter security property

+1 On 5/23/19 4:15 PM, Lance Andersen wrote: Thank you Brent for the review. On May 23, 2019, at 7:10 PM, Brent Christian mailto:brent.christ...@oracle.com>> wrote: Looks fine.  I guess you'll want to update/add the Copyright year in JDKSecurityProperties.java. Ah, forgot that, update bel

Re: RFR 8224682: Remove the com.sun.CORBA.ORBIorTypeCheckRegistryFilter security property

On 5/23/19, 4:10 PM, Brent Christian wrote: Looks fine. I guess you'll want to update/add the Copyright year in JDKSecurityProperties.java. Why ? What are you copyrighting ? There is nothing being added or modified, only a line deleted. Copyright is held in created content, not the act

Re: Thread stack size issue related to glibc TLS bug

Hi Jiangli, On 24/05/2019 9:21 am, Jiangli Zhou wrote: Hi David (and others), There was a discussion [1] (between you, Jeremy, Martin and others) back in 2015 regarding a stack size issue caused by a glibc bug related to TLS (Thread local storage) [2]. The issue was manifested as a StackOverflo

Re: RFR - JDK-8223775 String::stripIndent (Preview)

Hi, Excuse me for asking, but I can't find any text describing motivation for introduction of this method in JEP-355 other than "Developers will have access to this algorithm via String::stripIndent instance method"... If I understand the JEP correctly, this is an algorithm that is applied t