Re: RFR (XS) 8224849 : Flag (?U:...) is allowed for non-capturing groups

Thank you Brent for review! On 6/25/19 10:40 AM, Brent Christian wrote: That looks fine, Ivan. -Brent On 6/24/19 10:46 PM, Ivan Gerasimov wrote: Hello! Would someone volunteer to review this extra-small doc-only fix? Thanks in advance! With kind regards, Ivan On 5/28/19 9:33 AM, Ivan G

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

Hi Ivan, > On Jun 25, 2019, at 6:14 PM, Ivan Gerasimov wrote: > > On 6/25/19 3:33 PM, Joseph D. Darcy wrote: >> Hello, >> >> Please file a CSR for this change; thanks, >> > > Filed: https://bugs.openjdk.java.net/browse/JDK-8226784 > > > Ple

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

Hello! On 6/25/19 3:33 PM, Joseph D. Darcy wrote: Hello, Please file a CSR for this change; thanks, Filed: https://bugs.openjdk.java.net/browse/JDK-8226784 Please take a look at your convenience. With kind regards, Ivan -Joe On 6/25/2019 11:30 AM, Brent Christian wrote: I was musing abo

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

Hello, Please file a CSR for this change; thanks, -Joe On 6/25/2019 11:30 AM, Brent Christian wrote: I was musing about this myself. If the changes are within the @implNote(s), then perhaps not? -Brent On 6/25/19 11:15 AM, Brian Burkhalter wrote: > Is a CSR in order? Thanks, Brian On J

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

Hi Alexey, I cannot use index to get items from map. At least I did not figure it out how to do this. We need to use iterator when getting values from map. Thanks, Alexander On 6/25/2019 4:52 AM, Alexey Semenyuk wrote: In http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/src/jdk.jpackag

Re: RFR: JDK-8226709: MethodTypeDesc::resolveConstantDesc needs access check per the specification

Thanks Mandy, I will fix this in my local copy, Vicente On 6/25/19 10:37 AM, Mandy Chung wrote: Hi Vicente, This looks fine. Nit: the new test line 71 and 80 have an extra space "Error (" that can be taken out. Mandy On 6/24/19 8:33 PM, Vicente Romero wrote: Please review fix for [1], at

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

I was musing about this myself. If the changes are within the @implNote(s), then perhaps not? -Brent On 6/25/19 11:15 AM, Brian Burkhalter wrote: > Is a CSR in order? Thanks, Brian On Jun 25, 2019, at 5:49 AM, Ivan Gerasimov wrote: Hello! Would someone volunteer to review this extra-sm

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

Hi Ivan, Looks OK to me. Is a CSR in order? Thanks, Brian > On Jun 25, 2019, at 5:49 AM, Ivan Gerasimov wrote: > > Hello! > > Would someone volunteer to review this extra-small doc-only fix? > > Thanks in advance! > > With kind regards, > Ivan > > > On 5/29/19 2:39 PM, Ivan Gerasimov wro

Re: JPackage EA build 8 ( jdk-14-jpackage+1-8 )

I just tried this out. One thing that has changed since my last testing was the “create-installer” vs “--package-type” parameter. “--package-type all” isn’t allowed. If I want to create .rpm and .deb, or .exe. and .msi, do I need to run twice now? Maybe this could be a comma separated list or

Re: RFR (XS) 8224849 : Flag (?U:...) is allowed for non-capturing groups

That looks fine, Ivan. -Brent On 6/24/19 10:46 PM, Ivan Gerasimov wrote: Hello! Would someone volunteer to review this extra-small doc-only fix? Thanks in advance! With kind regards, Ivan On 5/28/19 9:33 AM, Ivan Gerasimov wrote: Hello! When the fix for JDK-7039066 (which added support

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

I'm fine with this either way. The ini file will have GetAllowDuplicates() true, but any OrderedMap that doesn't will have count of 1. /Andy On 6/25/2019 7:52 AM, Alexey Semenyuk wrote: In http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/src/jdk.jpackage/share/native/libapplauncher/Ja

Re: RFR: JDK-8226709: MethodTypeDesc::resolveConstantDesc needs access check per the specification

Hi Vicente, This looks fine. Nit: the new test line 71 and 80 have an extra space "Error (" that can be taken out. Mandy On 6/24/19 8:33 PM, Vicente Romero wrote: Please review fix for [1], at [2]. The implementation of method MethodTypeDesc.resolveConstantDes is not in sync with its speci

JPackage EA build 8 ( jdk-14-jpackage+1-8 )

core-libs-dev-requ...@openjdk.java.net wrote on 24/06/2019 20:12: I've been getting the new jpackage working with our project build. Generally everything's fine. One probable minor bug relating to JDK-8221333:  Replace Inno Setup with custom MSI wrapper for .exe bundler: The generated EXE ins

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

Hello! Would someone volunteer to review this extra-small doc-only fix? Thanks in advance! With kind regards, Ivan On 5/29/19 2:39 PM, Ivan Gerasimov wrote: Hello! In the implNote section of the javadoc for xxxSummaryStatistics classes it is mentioned that the sum is not checked for overfl

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

In http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/src/jdk.jpackage/share/native/libapplauncher/JavaVirtualMachine.cpp.sdiff.html, JavaOptions::AppendValues(), why do we need branching based on the result of Values.GetAllowDuplicates()? Why can't we use the same logic that was introduced

RE: [11u]: Backport of RFR 8211122: Reduce the number of internal classes made accessible to jdk.unsupported (and JDK-8205537 and JDK-8211121)

Hi, after Alan's input and contemplating a bit more about this I think we really should not pull the removals to 11. I explored amending the backport of JDK-8211122 to keep the applet classes and the ReflectionFactory method working and found out it's quite trivial. So I'll go that route. Will

Re: [11u]: Backport of RFR 8211122: Reduce the number of internal classes made accessible to jdk.unsupported (and JDK-8205537 and JDK-8211121)

On 6/24/19 4:12 PM, Alan Bateman wrote: > On 24/06/2019 15:23, Langer, Christoph wrote: >> : >> The original issues didn't have CSRs attached but it really feels CSRish. >> Let me know whether I shall create CSRs as you're still sorting out the >> process. > The sun.applet package was JDK interna

RE: [BUG] Inet6Address.isIPv4CompatibleAddress uses wrong prefix

Hi Rob, sending this over to net-dev, where it should be discussed... /Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Rob Spoor > Sent: Montag, 24. Juni 2019 22:58 > To: core-libs-dev@openjdk.java.net > Subject: [BUG] Inet6Address.isIPv4CompatibleAddress uses wrong

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

- Mail original - > De: "John Rose" > À: "Ioi Lam" > Cc: "core-libs-dev" , "hotspot-runtime-dev" > > Envoyé: Lundi 24 Juin 2019 19:13:04 > Objet: Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders > On Jun 20, 2019, at 12:12 AM, Ioi Lam wrote: >> ... >> I have a