Re: (13) RFR (S): 8227055: Minor edits to launcher help text

> I'm fine if you want to move ahead with this patch. Thanks Mandy - much appreciated! We can continue this refinement for 14. I have filed JDK-8227229 to deprecate and remove Xdebug - for history see: https://bugs.openjdk.java.net/browse/JDK-6272174 BTW thanks for the reference to JEP-293, I

Re: JDK 14 RFR of JDK-8227202: clarify Class.isEnum() doc

Hi Joe, Sounds good. Thanks, Brian > On Jul 3, 2019, at 3:46 PM, Joe Darcy wrote: > > Thanks for catching that; I'll correct before pushing. > > Cheers, > > -Joe > > On 7/3/2019 2:28 PM, Brian Burkhalter wrote: >> Hi Joe, >> >>> On Jul 3, 2019, at 2:24 PM, Joe Darcy >>

Re: JDK 14 RFR of JDK-8227202: clarify Class.isEnum() doc

Hi Brian, Thanks for catching that; I'll correct before pushing. Cheers, -Joe On 7/3/2019 2:28 PM, Brian Burkhalter wrote: Hi Joe, On Jul 3, 2019, at 2:24 PM, Joe Darcy > wrote: + * Note that if an enum constant is declared with a class body, + * the

Re: JDK 14 RFR of JDK-8227202: clarify Class.isEnum() doc

Hi Joe, > On Jul 3, 2019, at 2:24 PM, Joe Darcy wrote: > > + * Note that if an enum constant is declared with a class body, > + * the class of that enum constant is an anonymous class and > + * not the class of the declaring enum type. The {@link > + * Enum.getDeclaringClass}

JDK 14 RFR of JDK-8227202: clarify Class.isEnum() doc

Hello, Please review the patch below to address     JDK-8227202: clarify Class.isEnum() doc To condense a long story (see https://blogs.oracle.com/darcy/so-you-want-to-change-the-java-programming-language), there are cases where the Class object of an enum constant is *not* the Class object

Re: RFR: JDK-8227058: Regressions related to no longer setting user.dir

Hi Andy, Looks good. Thanks, Alexander On 7/3/2019 7:16 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8227058 [2]

Re: Slow performance of StackWalker.getCallerClass() vs Reflection.getCallerClass()

On 7/2/19 6:57 PM, Ralph Goers wrote: Thanks Mandy, It seems I commented on the thread mentioned in the issue you linked to. Unfortunately, it doesn’t look like any work has been done on the issue.in the last 18 months. I did start to explore some options and never have time to spend

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

Just a thought below to consider or ignore ;-) > On Jul 2, 2019, at 11:27 PM, Stuart Marks wrote: > > Hi Jaikiran, > > OK, good analysis. Rather a lot of issues for what seems like a simple patch, > eh? > > - Idempotency > > Yes, it looks to me like Inflater.end() and Deflater.end()

Re: (13) RFR (S): 8227055: Minor edits to launcher help text

On 7/2/19 11:10 PM, David Holmes wrote: Hi Mandy, Thanks for taking a look. On 3/07/2019 8:57 am, Mandy Chung wrote: On 7/2/19 3:44 PM, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8227055/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8227055 The launcher help

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

Hi, Looks ok, but... .../java/time/format/DateTimeFormatterBuilder.java 3924: needs a space in "if(" -> "if (" java/time/format/TestLocalizedOffsetPrinterParser.java I would cut the number of test cases to a minimum; only need to ensure the code is correct. We don't need to be testing the

Re: 8226863: [aix] jdk/java/lang/reflect/exeCallerAccessTest cannot launch on primordial thread

On 7/2/19 10:30 PM, Thomas Stüfe wrote: Hi Mandy, On Wed, Jul 3, 2019, 00:20 Mandy Chung > wrote: Hi Thomas, This is AIX-only.    It would be cleaner to move AIX-specific launcher to a new file like main_aix.c.  Have you considered that? I

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

Looks good. Naoto On 7/3/19 5:32 AM, Thejasvi Voniadka wrote: Hi Naoto, Thank you for the review. Please find the updated webrev: http://cr.openjdk.java.net/~vagarwal/8154520/webrev.3/ The TCKOffsetPrinterParser.java has been reverted back to what it was, except for the copyright year and

RFR: JDK-8227058: Regressions related to no longer setting user.dir

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8227058 [2] http://cr.openjdk.java.net/~herrick/8227058/ /Andy

RE: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

Hi Naoto, Thank you for the review. Please find the updated webrev: http://cr.openjdk.java.net/~vagarwal/8154520/webrev.3/ The TCKOffsetPrinterParser.java has been reverted back to what it was, except for the copyright year and the locale addition. I have incorporated your comments to

Re: JPackage application image file system layout

On 7/3/2019 2:08 AM, Robert Lichtenberger wrote: I just noticed that my last reply was addressed to Scott Palmer only, so I "repost" my latest thougths now: Am 01.07.19 um 16:50 schrieb Scott Palmer: On Jul 1, 2019, at 2:47 AM, Robert Lichtenberger wrote: While trying to update our

Re: (13) RFR (S): 8227055: Minor edits to launcher help text

Hi Mandy, Thanks for taking a look. On 3/07/2019 8:57 am, Mandy Chung wrote: On 7/2/19 3:44 PM, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8227055/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8227055 The launcher help text needs some minor updates/corrections -

Re: JPackage application image file system layout

I just noticed that my last reply was addressed to Scott Palmer only, so I "repost" my latest thougths now: Am 01.07.19 um 16:50 schrieb Scott Palmer: >> On Jul 1, 2019, at 2:47 AM, Robert Lichtenberger >> wrote: >> >> While trying to update our application to the (ea-version of) jpackager I >>