Re: Comments on jpackage (JEP 343)

2019-09-16 Thread Philip Race
> but I'd concede it to be "." as a default On second thoughts I am not sure about that either. I find it much cleaner to know what was generated by looking in a new directory rather than hunting in my current directory, especially for the default app-image case which will dump a bunch of

Re: Comments on jpackage (JEP 343)

2019-09-16 Thread Philip Race
I've been thinking about this. output is nicely symmetrical with input and in the case of a default app-image it is more than a single item and personally I'd much rather it not clutter my working directory and again you get symmetry with input which you really want to specify but I'd concede

Re: RFR: 8229773: Resolve permissions for code source URLs lazily

2019-09-16 Thread Peter Firmstone
Hi Alan, Your suspicion is correct. :) Thanks for the leads, I'll look into it further. Currently the policy implementation finds policy url's in system properties, "java.security.policy" and numbered policy locations with the prefix "policy.url." if the "java.security.policy" property

Re: RFR [14/java.xml] 8230814: Enable SAX ContentHandler to handle XML Declaration

2019-09-16 Thread Joe Wang
On 9/14/19 1:08 AM, Alan Bateman wrote: On 13/09/2019 21:50, Joe Wang wrote: : It can be said that the SAX project, in terms of the API work, was dead a long time ago. There hasn't been any updates/changes since SAX 2.0.2 released in 2004[1]. SAX is in public domain [2]. Sun/Oracle

Re: [PATCH] Add *.iml to .hgignore and .gitignore

2019-09-16 Thread JARvis PROgrammer
Intellij configuration files may appear in directories other than /.idea/. For example the script suggested by AdoptOpenJDK generates such in the root directory. пн, 16 сент. 2019 г., 9:33 Alan Bateman : > > I think the .ignore files are maintained on build-dev. Note that .idea > is already

[jpackage] Customize msi installer

2019-09-16 Thread Tobias Diez
Hi, after experimenting with jpackage for creating a msi installer, I would like to suggest the following improvements: 1. Set the ARPPRODUCTICON property, that controls the icon displayed in Add/Remove Programs for your application.

RE: 8229471: Calendar under a specific timezone changes HOUR field when MILLISECOND field is changed

2019-09-16 Thread Yano, Masanori
Hi Naoto, Thank you for replying. I understand that this behavior is expected. I will consider the existing behavior. Regards, Masanori Yano > -Original Message- > From: naoto.s...@oracle.com [mailto:naoto.s...@oracle.com] > Sent: Friday, September 13, 2019 5:25 AM > To: Yano, Masanori

Re: [PATCH] Add *.iml to .hgignore and .gitignore

2019-09-16 Thread Erik Joelsson
Hello, The .ignore file is currently in regexp format so new additions should probably be in that format. I don't object to ignoring .iml files. /Erik On 2019-09-15 23:33, Alan Bateman wrote: I think the .ignore files are maintained on build-dev. Note that .idea is already excluded and it

Re: RFR: JDK-8230649: Make jpackage tool an experimental feature

2019-09-16 Thread Kevin Rushforth
On 9/16/2019 6:06 AM, Alan Bateman wrote: On 16/09/2019 13:56, Kevin Rushforth wrote: In that case, it may be better to issue any warnings about it being experimental directly from jpackage instead of relying on the incubating modules. Incubating modules are incubating non-final APIs so I

Re: RFR: JDK-8230649: Make jpackage tool an experimental feature

2019-09-16 Thread Alan Bateman
On 16/09/2019 13:56, Kevin Rushforth wrote: In that case, it may be better to issue any warnings about it being experimental directly from jpackage instead of relying on the incubating modules. Incubating modules are incubating non-final APIs so I don't think it's the right solution here. I

Re: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

2019-09-16 Thread Thomas Stüfe
Hi Goetz, not a full review, just a small suggestion. In jvm.cpp you could just access ss->base() instead of ss->as_string() since the internal buffer is already NULL terminated and result_string does not outlive the stringStream object. Also it misses including ostream.hpp. Cheers, Thomas On

Re: RFR: JDK-8230649: Make jpackage tool an experimental feature

2019-09-16 Thread Kevin Rushforth
In that case, it may be better to issue any warnings about it being experimental directly from jpackage instead of relying on the incubating modules. -- Kevin On 9/15/2019 1:05 PM, Andy Herrick wrote: yes - result of this change is as you suggest, everything shows this warning, so we will

Re: RFR 8221623 : Add StackWalker micro benchmarks to jdk repo

2019-09-16 Thread Daniel Fuchs
Hi Brent, The StackWalker benchmark look good to me. However I have some doubts about the the logging benchmark. Is the benchmark run in a single thread? If not then there doesn't seem any guarantee that each call to publish() will be immediately followed by a call to reset(), but instead, if

Re: [PATCH] Add *.iml to .hgignore and .gitignore

2019-09-16 Thread Alan Bateman
I think the .ignore files are maintained on build-dev. Note that .idea is already excluded and it contains the .iml and other workspace files are created for the IntelliJ project, maybe your setup might be different? -Alan. On 15/09/2019 21:22, JARvis PROgrammer wrote: This is a small