RFR: JDK-8230654: jpackage package-type dmg on macOS

Hi, why are there scrollbars in the image on JBS? When you normally open a DMG you do not get scrollbars. Michael Message: 6 Date: Tue, 17 Sep 2019 19:42:01 -0700 From: Alexander Matveev To: core-libs-dev Subject: RFR: JDK-8230654: jpackage package-type dmg on macOS Message-ID: <94fa6522-c

RFR: JDK-8230654: jpackage package-type dmg on macOS

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added link to "/Application" folder to DMG for drag and drop app to this folder. - Added background image with arrow pointing from App icon to Appli

Re: Concurrent Hash Map javadoc question

Re-directing to core-libs-dev mailing list. David On 18/09/2019 5:45 am, Keith Turner wrote: The javadoc for ConcurrentHashMap.computeIfAbsent() states the remapping function is applied at most once. The functions computeIfPresent() and compute() do not explicitly state if the remapping functi

Re: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Goetz, in bytecodeUtils.cpp, in print_local_var(), i believe that the code if (!method->is_static() && (slot == 0)) { os->print("this"); } ... is only true if the bytecode is generated by javac and ecj, tools like proguard that tries to obfuscate the code will reuse the slot 0 once

Re: RFR: JDK-8230920: jpackage problems when -input dir contains any files with "cfg" extension.

On 9/17/2019 3:51 PM, Alexey Semenyuk wrote: On 9/17/2019 3:17 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). On Windows  when building MSI, the original application nam

Re: RFR: JDK-8230920: jpackage problems when -input dir contains any files with "cfg" extension.

On 9/17/2019 3:17 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). On Windows  when building MSI, the original application name was determined by looking into the /app dir

RFR: JDK-8230920: jpackage problems when -input dir contains any files with "cfg" extension.

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). On Windows  when building MSI, the original application name was determined by looking into the /app dir for a ".cfg" file. The problem was that:  -

Re: RFR: 8231098: (tz) Upgrade time-zone data to tzdata2019c

On 9/17/19 10:14 AM, Martin Buchholz wrote: On Tue, Sep 17, 2019 at 9:45 AM > wrote: +1 On 9/17/19 8:29 AM, Martin Buchholz wrote: > Looks good to me. > At Google we also integrated tzdata2019c, and it was uneventful (good!). > But we'

Re: RFR: 8231098: (tz) Upgrade time-zone data to tzdata2019c

On Tue, Sep 17, 2019 at 9:45 AM wrote: > +1 > > On 9/17/19 8:29 AM, Martin Buchholz wrote: > > Looks good to me. > > At Google we also integrated tzdata2019c, and it was uneventful (good!). > > But we're still using rearguard format. > > The vanguard/rearguard distinction is a source of errors, s

Re: RFR: 8231098: (tz) Upgrade time-zone data to tzdata2019c

+1 On 9/17/19 8:29 AM, Martin Buchholz wrote: Looks good to me. At Google we also integrated tzdata2019c, and it was uneventful (good!). But we're still using rearguard format. The vanguard/rearguard distinction is a source of errors, so it should be made clear what format is being used to impor

Re: RFR: 8231124: Missing closedir call with JDK-8223490

Looks good. Naoto On 9/17/19 9:27 AM, Seán Coffey wrote: A minor issue that was introduced via my recent JDK-8223490 fix. One which I noticed while backporting the edits.. https://bugs.openjdk.java.net/browse/JDK-8231124 proposed patch: diff --git a/src/java.base/unix/native/libjava/TimeZone

RFR: 8231124: Missing closedir call with JDK-8223490

A minor issue that was introduced via my recent JDK-8223490 fix. One which I noticed while backporting the edits.. https://bugs.openjdk.java.net/browse/JDK-8231124 proposed patch: diff --git a/src/java.base/unix/native/libjava/TimeZone_md.c b/src/java.base/unix/native/libjava/TimeZone_md.c --

Re: RFR [14/java.xml] 8230814: Enable SAX ContentHandler to handle XML Declaration

On 9/17/19 3:00 AM, Alan Bateman wrote: On 16/09/2019 19:25, Joe Wang wrote: : I deliberately left the javadoc in the SAX package as they are. But I agree it may be worth it to address this aspect of the document. I suggest we do so with a separate doc-only request[1] to clarify the relati

Re: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Makes sense Goetz. Cheers, Thomas On Tue, Sep 17, 2019 at 11:23 AM Lindenmaier, Goetz < goetz.lindenma...@sap.com> wrote: > Hi Thomas, > > thanks for pointing this out. I improved the placement > of the ResourceMarks. > Unfortunately, base() returns an immutable string, but > for trim_well_know

Re: RFR: 8231098: (tz) Upgrade time-zone data to tzdata2019c

Looks good to me. At Google we also integrated tzdata2019c, and it was uneventful (good!). But we're still using rearguard format. The vanguard/rearguard distinction is a source of errors, so it should be made clear what format is being used to import the files. If you have a script to update the j

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

@core-libs experts, I would appreciate comments on the changes to NullPointerException.java, especially wrt. the Javadoc comment. The change there is S. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Dienstag, 10. September 2019 11:48 > To: 'Hotspot dev run

Re: RFR(s): 8228580: DnsClient TCP socket timeout

Milan, While the CSR is being processed, could we maybe think of some additional testing for that change? Otherwise, that test seems kind of anemic. It makes sure that the query doesn't hang, but that's about it. It doesn't check that the timeout is respected. I was wondering if you could propo

Re: Comments on jpackage (JEP 343)

Hi Phil, In the app-image case it always creates a new directory with the name of the application underneath the dest/output directory for holding all of the files. So you either have:    /appname.ext or    /appname/ So I think "." is a reasonable default if not specified. As to whether t

Re: RFR [14/java.xml] 8230814: Enable SAX ContentHandler to handle XML Declaration

On 16/09/2019 19:25, Joe Wang wrote: : I deliberately left the javadoc in the SAX package as they are. But I agree it may be worth it to address this aspect of the document. I suggest we do so with a separate doc-only request[1] to clarify the relationship with the SAX project, likely adding

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Thomas, thanks for pointing this out. I improved the placement of the ResourceMarks. Unfortunately, base() returns an immutable string, but for trim_well_known_class_names this does not work. So I'd propose this: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/17-incremental/ http

Re: RFR(s): 8228580: DnsClient TCP socket timeout

I have filed the CSR: https://bugs.openjdk.java.net/browse/JDK-8230965 > On 13 Sep 2019, at 11:21, Pavel Rappo wrote: > > Here's the latest webrev accumulating all the changes we've discussed so far: > >http://cr.openjdk.java.net/~prappo/8228580/webrev.03/ > > If people are okay with

RE: RFR: 8228482: fix xlc16/xlclang comparison of distinct pointer types and string literal conversion warnings

Hi Matthias, this seems fine to me. The change in NetworkInterface.c is correct, too. Best regards Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Baesken, Matthias > Sent: Donnerstag, 25. Juli 2019 15:45 > To: Doerr, Martin ; 'hotspot- > d...@openjdk.java.net' ; cor

Re: Comments on jpackage (JEP 343)

I have built many times with the new jpackage, but actually just now tried to install the package built by it. The new jpackage adds a lot of Requires to the built RPM package. We had the same problem with the old javapackager. Its default RPM spec file had a lot of Requires that made it difficult

RFR: 8231098: (tz) Upgrade time-zone data to tzdata2019c

Hi all, Please review the patch for tzdata2019c integration into jdk project(jdk-14). Webrev: http://cr.openjdk.java.net/~rpatil/8231098/14/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8231098 The patch has passed all the related testing including JCK. Regards, Ramanand.

Re: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Additionally, since 8224193, stringStream does not use RA anymore, so you do not need ResourceMarks for the backing buffer. 8224193 has been backported to 11, btw. On Mon, Sep 16, 2019 at 2:53 PM Thomas Stüfe wrote: > Hi Goetz, > > not a full review, just a small suggestion. In jvm.cpp you could