RE: JEP proposed to target JDK 14: 358: Helpful NullPointerExceptions

2019-09-25 Thread Lindenmaier, Goetz
Hi Jon, Good catch, I fixed it. Thanks! Goetz. > -Original Message- > From: hotspot-runtime-dev boun...@openjdk.java.net> On Behalf Of Jonathan Gibbons > Sent: Thursday, September 26, 2019 12:41 AM > To: hotspot-runtime-...@openjdk.java.net runtime d...@openjdk.java.net>; OpenJDK D

[14]RFR 8231213: Migrate SimpleDateFormatConstTest to JDK Repo

2019-09-25 Thread Daisy Zhou
Hello, Please help to review this patch for migrating SimpleDateFormatConstTest from Tonga to Jtreg. Bug:HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8231213"; https://bugs.openjdk.java.net/browse/JDK-8231213 Webrev: http://cr.openjdk.java.net/~yzhou/8231213/webrev.02/ Thanks, D

Re: Comments on jpackage (JEP 343)

2019-09-25 Thread Alexey Semenyuk
Sverre, Thank you for your feedback. I've captured it in https://bugs.openjdk.java.net/browse/JDK-8230668. - Alexey On 9/25/2019 9:45 AM, Sverre Moe wrote: I have some new comments regarding the Windows build of jpackage. 1) Is there any way to build an trusted application installer using W

Re: RFR: JDK-8231382: Use main class from main module if available

2019-09-25 Thread Alexey Semenyuk
Looks good. - Alexey On 9/25/2019 6:30 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Main class from module will be used if main class is not specified in CLI. Mai

Re: JEP proposed to target JDK 14: 358: Helpful NullPointerExceptions

2019-09-25 Thread Jonathan Gibbons
Typo "isnull" and/or font issue, in "The format of the null-detail message" 1. In a failed array access --|Cannot load from object array because 'a[i][j]' is|null|.|-- the second part|'a[i][j]' is null.|suffices to pinpoint the|null|expression in source code,|a[i][j][k] = 99;| -- Jon

RFR: JDK-8231382: Use main class from main module if available

2019-09-25 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Main class from module will be used if main class is not specified in CLI. Main class from CLI will be preferred over main class specified in module

Re: RFR: JDK-8230649 : Make jpackage tool an experimental feature

2019-09-25 Thread Kevin Rushforth
That seems fine then. Thanks. -- Kevin On 9/25/2019 8:29 AM, Andy Herrick wrote: I can will remove the makefile change then. The warning is going the same place as the help output (Log.info()) which is stdout unless a different stream is passed to ToolProvider. So if we want a more detaile

Re: RFR: JDK-8230649 : Make jpackage tool an experimental feature

2019-09-25 Thread Andy Herrick
I can will remove the makefile change then. The warning is going the same place as the help output (Log.info()) which is stdout unless a different stream is passed to ToolProvider. So if we want a more detailed message in Help text we can either show the more detailed message in addition to t

Re: RFR: JDK-8230649 : Make jpackage tool an experimental feature

2019-09-25 Thread Kevin Rushforth
On 9/25/2019 7:44 AM, Alan Bateman wrote: On 25/09/2019 15:33, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). These are the code changes to make jpackage an experimental feat

Re: RFR: JDK-8230649 : Make jpackage tool an experimental feature

2019-09-25 Thread Alan Bateman
On 25/09/2019 15:33, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). These are the code changes to make jpackage an experimental feature. [1] https://bugs.openjdk.java.net/browse

RFR: JDK-8230649 : Make jpackage tool an experimental feature

2019-09-25 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). These are the code changes to make jpackage an experimental feature. [1] https://bugs.openjdk.java.net/browse/JDK-8230649 [2] http://cr.openjdk.java.n

Re: Comments on jpackage (JEP 343)

2019-09-25 Thread Sverre Moe
I have some new comments regarding the Windows build of jpackage. 1) Is there any way to build an trusted application installer using WiX? I want to avoid "Unknown Publisher" when installing the application. Also having problems with Windows Defender SmartScreen, depending on what settings the use

Re: RandomAccess Interface and List Heirarchy

2019-09-25 Thread Remi Forax
Hi Cyrus, as the javadoc says RandomAccess is a marker interface, an interface used at runtime to indicate if the implementation provides a fast random access operation or not. "marker interface" is the precursor of a runtime visible annotation. RandomAccess was introduce in 1.4 while annotations

Re: JDK 14 RFR of JDK-8231442 : Suppress warnings on non-serializable instance fields in java.sql.* modules

2019-09-25 Thread Lance Andersen
Hi Joe, Looks OK SyncProviderException.java, SQLClientInfoException.java, StatementEvent.java should probably have the copyright notice updated to 2019 prior to pushing Best Lance > On Sep 25, 2019, at 12:34 AM, Joe Darcy wrote: > > Hello, > > Next step in the serialization warnings pre-cle