Re: 8229022: BufferedReader performance can be improved by using StringBuilder

Hi Brian, Looks good to me. thanks, Vyom On Wed, Oct 2, 2019 at 5:44 AM Brian Burkhalter wrote: > While the performance improvement that I measured for this proposed change > [1] using JMH was only in the 2% to 8% range as opposed to the 13% claimed > in the issue description, given the simplici

Re: 8229022: BufferedReader performance can be improved by using StringBuilder

Hi Brian! This looks good to me! With kind regards, Ivan On 10/1/19 5:13 PM, Brian Burkhalter wrote: While the performance improvement that I measured for this proposed change [1] using JMH was only in the 2% to 8% range as opposed to the 13% claimed in the issue description, given the sim

8229022: BufferedReader performance can be improved by using StringBuilder

While the performance improvement that I measured for this proposed change [1] using JMH was only in the 2% to 8% range as opposed to the 13% claimed in the issue description, given the simplicity of the change [2] it is probably worth doing. All use of the StringBuilder is within a synchronized

Re: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

2019/9/24 1:13:14 -0700, goetz.lindenma...@sap.com: > http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/19/ This is very nice work! I especially appreciate the thorough tests. Looking at the tests, and the details of the JEP, I noticed that the generated messages all end in a period (e.g.

Re: RFR: JDK-8231721: jpackage --install-dir should reject system dirs on Linux

Looks good. On 10/1/19 3:00 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8231721 [2] http://cr.openjdk.java.net/~asemenyuk

Re: RFR: 8231584: Deadlock with ClassLoader.findLibrary and System.loadLibrary call

On 30.09.2019 21:18, Mandy Chung wrote: > Skimming through the implementation, it seems to me that the > Runtime::loadLibrary0 does not need to be synchronized. > ClassLoader::loadLibrary0 should ensure that a native library of a given name > is loaded and registered only once. Interesting

RFR: JDK-8231721: jpackage --install-dir should reject system dirs on Linux

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8231721 [2] http://cr.openjdk.java.net/~asemenyuk/8231721/webrev.00/

RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hello! The constructors of SocketPermission and FilePermission expect a String argument with comma-separated list of actions. If the list is malformed, then the constructors throw IllegalArgumentException. It turns out that the current implementation fails to throw IAE if the list starts w

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Thanks, Ralf! Best regards, Goetz. > -Original Message- > From: Schmelter, Ralf > Sent: Dienstag, 1. Oktober 2019 10:11 > To: Lindenmaier, Goetz ; Hotspot dev runtime > ; Java Core Libs d...@openjdk.java.net> > Subject: RE: RFR (L, final): 8218626: Add detailed message to > NullPointe

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Goetz, thanks for the additional test. Looks good. Best regards, Ralf -Original Message- From: Lindenmaier, Goetz Sent: Montag, 30. September 2019 18:31 To: Schmelter, Ralf ; Hotspot dev runtime ; Java Core Libs Subject: RE: RFR (L, final): 8218626: Add detailed message to NullP