On 10/22/19 3:37 PM, mark.reinh...@oracle.com wrote:
2019/10/22 14:12:18 -0700, mandy.ch...@oracle.com:
On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.jav
On 23/10/2019 2:10 am, Ioi Lam wrote:
Hi Adam,
The HotSpot logging option:
-Xlog:class+load=debug
will show the class loader, super class, interfaces, size of the
classfile, etc.
A related option:
-Xlog:class+resolve=debug
shows all the class resolution done by the Java code
On 23/10/2019 7:52 am, Mandy Chung wrote:
On 10/22/19 8:03 AM, Claes Redestad wrote:
http://cr.openjdk.java.net/~redestad/8232613/open.03
Looks good to me.
Filed and drafted a CSR: https://bugs.openjdk.java.net/browse/JDK-8232801
I think it'd be good to include the IAE message as an exa
+1
Thanks
Vladimir
> On Oct 22, 2019, at 3:42 PM, Bob Vandette wrote:
>
> Hotspot changes look good to me.
>
> Bob.
>
>
>> On Oct 22, 2019, at 6:36 PM, mark.reinh...@oracle.com wrote:
>>
>> 2019/10/22 12:43:42 -0700, bob.vande...@oracle.com:
> On Oct 22, 2019, at 3:22 PM, mark.reinh...@
Hi Alexey,
Looks good.
Thanks,
Alexander
On 10/22/2019 2:14 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Additionally:
- fixes for [3], [4], [5] and [6] bugs.
- remo
Hotspot changes look good to me.
Bob.
> On Oct 22, 2019, at 6:36 PM, mark.reinh...@oracle.com wrote:
>
> 2019/10/22 12:43:42 -0700, bob.vande...@oracle.com:
>>> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote:
>>> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com:
In arguments
2019/10/22 14:12:18 -0700, mandy.ch...@oracle.com:
> On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
>> Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
>
> Looks good to me.
2019/10/22 12:43:42 -0700, bob.vande...@oracle.com:
>> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote:
>> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com:
>>> In arguments.cpp, could you use a new JVMFlag to declare options
>>> that came from this resource as RESOURCE?
>>>
>>> - ji
All looks good to me! :)
Thanks,
David
On 23/10/2019 4:25 am, Alan Bateman wrote:
I brought up the issue of deprecating, for removal,
Thread.suspend/resume a few weeks ago [1]. Mark said "Got for it", no
other replies or objections.
Here's the webrev with the changes to deprecate-for-removal
On 10/22/19 8:03 AM, Claes Redestad wrote:
http://cr.openjdk.java.net/~redestad/8232613/open.03
Looks good to me.
Filed and drafted a CSR: https://bugs.openjdk.java.net/browse/JDK-8232801
I think it'd be good to include the IAE message as an example.
Is there a CSR that documents the p
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Removed --mac-app-store-category.
- Added Hello.java test app to support file association on OS X.
- Modified Hello.java to write output file to user
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Additionally:
- fixes for [3], [4], [5] and [6] bugs.
- removed unused l10n strings from Windows resource files.
- replaced `throw new
ConfigException
On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
Looks good to me. One minor comment:
AddResourcePlugin isn't really a FILTE
Looks good.
On 10/22/2019 12:34 PM, Andy Herrick wrote:
There really aren't any tests for overridable resources in packages,
the mechanism is only tested by testing the one resource that is
overriddable in app-image build, the app icon.
This the second resources overridable in windows package
Looks fine to me.
Mandy
On 10/22/19 11:25 AM, Alan Bateman wrote:
I brought up the issue of deprecating, for removal,
Thread.suspend/resume a few weeks ago [1]. Mark said "Got for it", no
other replies or objections.
Here's the webrev with the changes to deprecate-for-removal
Thread.suspend
> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote:
>
> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com:
>> In arguments.cpp, could you use a new JVMFlag to declare options that came
>> from this resource as RESOURCE?
>>
>> - jint result = parse_each_vm_init_arg(vm_options_args,
There really aren't any tests for overridable resources in packages, the
mechanism is only tested by testing the one resource that is
overriddable in app-image build, the app icon.
This the second resources overridable in windows packages, (the
post-install script is the other).
On Linux (ot
2019/10/22 7:15:10 -0700, alan.bate...@oracle.com:
> On 22/10/2019 04:22, mark.reinh...@oracle.com wrote:
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
>> Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
>
> I've read through
2019/10/22 10:31:55 -0700, bob.vande...@oracle.com:
> In arguments.cpp, could you use a new JVMFlag to declare options that came
> from this resource as RESOURCE?
>
> - jint result = parse_each_vm_init_arg(vm_options_args, &patch_mod_javabase,
> JVMFlag::INTERNAL);
> + jint result = parse_each_v
Looks good.
It would be good to have a test for this change as a part of this fix or
as a follow up CR.
- Alexey
On 10/22/2019 2:50 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpa
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
use createResource() to get an over-ridable resource.
[1] https://bugs.openjdk.java.net/browse/JDK-8232723
[2] http://cr.openjdk.java.net/~herrick/823
On 22/10/2019 18:00, Lance Andersen wrote:
Per your suggestion, I tweaked the patch to move to BOF when the
negative skip value goes beyond BOF. I updated the release note as well.
webrev can be found at:
http://cr.openjdk.java.net/~lancea/8231451/webrev.01/index.html
I assume skip(Long.M
I brought up the issue of deprecating, for removal,
Thread.suspend/resume a few weeks ago [1]. Mark said "Got for it", no
other replies or objections.
Here's the webrev with the changes to deprecate-for-removal
Thread.suspend/resume, ThreadGroup.suspend/resume, and
ThreadGroup.allowThreadSusp
In arguments.cpp, could you use a new JVMFlag to declare options that came from
this resource as RESOURCE?
- jint result = parse_each_vm_init_arg(vm_options_args, &patch_mod_javabase,
JVMFlag::INTERNAL);
+ jint result = parse_each_vm_init_arg(vm_options_args, &patch_mod_javabase,
JVMFlag::RESOU
On 2019-10-22 19:09, Lois Foltan wrote:
Filed and drafted a CSR: https://bugs.openjdk.java.net/browse/JDK-8232801
Hi Claes,
You have my review for webrev .03.
Thanks!
Thanks for adding the test case. I
agree with David that a CSR is warranted. Only minor comment I have on
it is tha
On 10/22/2019 11:03 AM, Claes Redestad wrote:
On 2019-10-22 15:55, David Holmes wrote:
With your change interface I's registerNatives default method is
invoked successfully. I don't think this is a major backward
compatibilty issue but we should have someone from core-libs okay
the removal
> On Oct 18, 2019, at 7:18 AM, Alan Bateman wrote:
>
> On 16/10/2019 18:06, Lance Andersen wrote:
>> Hi all,
>>
>> Please review this fix to ZipFileInputStream::skip when specifying a
>> negative value to the skip method when accessing a STORED entry,
>> https://bugs.openjdk.java.net/browse/
HotSpot changes seem fine to me.
Thanks,
Vladimir
On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
This change implements jlink p
Hi Adam,
The HotSpot logging option:
-Xlog:class+load=debug
will show the class loader, super class, interfaces, size of the
classfile, etc.
A related option:
-Xlog:class+resolve=debug
shows all the class resolution done by the Java code during execution.
You're right that the
Hi David,
I didn't, no. Thanks for pointing it out. :)
I see this tells us where the class comes from, much like
"-verbose:class".
So it's useful when a class can be successfully loaded, but
doesn't tell us which classloaders tried to load the class,
nor where they looked, etc.
Something I c
Hi Alan,
Thanks for the quick response.
Stewart, if you have a moment, could you please advise on the section with
the @Stewart tag?
Alan Bateman wrote on 22/10/2019 12:36:26:
> From: Alan Bateman
...
> This looks very messy and I don't think is in any state to be reviewed.
I'm sorry to he
On 2019-10-22 15:55, David Holmes wrote:
With your change interface I's registerNatives default method is
invoked successfully. I don't think this is a major backward
compatibilty issue but we should have someone from core-libs okay the
removal of the method from Object before committing.
On 22/10/2019 04:22, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
I've read through the code for the new jlink plugins and the changes to
VersionPro
On 22/10/2019 11:41 pm, Claes Redestad wrote:
Hi Lois,
to make sure noone misses it, here's the new webrev:
http://cr.openjdk.java.net/~redestad/8232613/open.03
I like the code placement in this version - Coleen's suggestion was
better than mine :)
Comments inline..
Comments inline ...
Hi Lois,
to make sure noone misses it, here's the new webrev:
http://cr.openjdk.java.net/~redestad/8232613/open.03
Comments inline..
On 2019-10-22 14:33, Lois Foltan wrote:
On 10/22/2019 7:13 AM, Claes Redestad wrote:
On 2019-10-22 13:05, Andrew Dinn wrote:
On 22/10/2019 12:05, Claes Redes
Hi Adam,
Did you look at the logging available from the VM: -Xlog:class+load?
BTW I moved the bug you filed to the correct component.
Cheers,
David
On 22/10/2019 8:40 pm, Adam Farley8 wrote:
Hey All,
This one goes out to anyone who's struggled to figure out
why OpenJDK isn't loading their cl
Hi Claes,
On 22/10/2019 8:38 pm, Claes Redestad wrote:
Hi David,
On 2019-10-22 01:08, David Holmes wrote:
Hi Claes,
My only nit with this is that I don't think register_native and
friends belongs in the SystemDictionary class as it has nothing to do
with the SD. This code seems to be all ab
On 22/10/2019 12:13, Claes Redestad wrote:
> No wait, I missed the use in jni.cpp where the bool return is actually
> used. I ignored it in systemDict since when I got an exception there
> (by misspelling a name or using the wrong signature) the exception
> bubbles up and crashes the VM.
>
> Perha
> On 21 Oct 2019, at 19:32, Vicente Romero wrote:
>
> Hi all,
>
> Please review the serialization changes to support records.
>
> Thanks,
> Vicente
>
> http://cr.openjdk.java.net/~vromero/records.review/serialization/webrev.00/
Peter has raised an issue over on amber-spec-experts [1], which
On 10/22/2019 7:13 AM, Claes Redestad wrote:
On 2019-10-22 13:05, Andrew Dinn wrote:
On 22/10/2019 12:05, Claes Redestad wrote:
On 2019-10-22 12:44, Andrew Dinn wrote:
Why not leave it void?
I guess:
http://cr.openjdk.java.net/~redestad/8232613/open.02/
Ship it ;-)
No wait, I missed th
On 22/10/2019 11:40, Adam Farley8 wrote:
Hey All,
This one goes out to anyone who's struggled to figure out
why OpenJDK isn't loading their class.
The requirement is for OpenJDK to give more detailed
information while loading user-specified classes (e.g. the
one OpenJDK is failing to load). Som
On 2019-10-22 13:05, Andrew Dinn wrote:
On 22/10/2019 12:05, Claes Redestad wrote:
On 2019-10-22 12:44, Andrew Dinn wrote:
Why not leave it void?
I guess:
http://cr.openjdk.java.net/~redestad/8232613/open.02/
Ship it ;-)
No wait, I missed the use in jni.cpp where the bool return is act
On 22/10/2019 12:05, Claes Redestad wrote:
> On 2019-10-22 12:44, Andrew Dinn wrote:
>> Why not leave it void?
>
> I guess:
>
> http://cr.openjdk.java.net/~redestad/8232613/open.02/
Ship it ;-)
regards,
Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in Eng
On 2019-10-22 12:44, Andrew Dinn wrote:
On 22/10/2019 11:38, Claes Redestad wrote:
how about this:
http://cr.openjdk.java.net/~redestad/8232613/open.01/
Sure that works.
It's a bit more obvious now though that you are pointlessly returning a
boolean from Method::register_native (this was a
On 22/10/2019 11:38, Claes Redestad wrote:
> how about this:
>
> http://cr.openjdk.java.net/~redestad/8232613/open.01/
Sure that works.
It's a bit more obvious now though that you are pointlessly returning a
boolean from Method::register_native (this was also there in the
previous version).
Why
Hey All,
This one goes out to anyone who's struggled to figure out
why OpenJDK isn't loading their class.
The requirement is for OpenJDK to give more detailed
information while loading user-specified classes (e.g. the
one OpenJDK is failing to load). Some debug information is
available while
Hi David,
On 2019-10-22 01:08, David Holmes wrote:
Hi Claes,
My only nit with this is that I don't think register_native and friends
belongs in the SystemDictionary class as it has nothing to do with the
SD. This code seems to be all about Methods so that seems like the place
to put this.
On 2019-10-22 05:22, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
Build changes look good.
/Magnus
This change implements jlink plugins, and asso
On 2019-10-16 14:55, Erik Joelsson wrote:
Build change looks good now.
I agree.
/Magnus
/Erik
On 2019-10-16 05:50, Jan Lahoda wrote:
Hi,
An updated patch is here:
http://cr.openjdk.java.net/~jlahoda/8226585/webrev.02/
Changes in the update:
-added the dependency into the makefiles
-loosen
Hi Andrew,
On 22/10/2019 6:11 pm, Andrew Dinn wrote:
Hi Claes/David,
On 22/10/2019 00:08, David Holmes wrote:
My only nit with this is that I don't think register_native and friends
belongs in the SystemDictionary class as it has nothing to do with the
SD. This code seems to be all about Metho
Hi Claes/David,
On 22/10/2019 00:08, David Holmes wrote:
> My only nit with this is that I don't think register_native and friends
> belongs in the SystemDictionary class as it has nothing to do with the
> SD. This code seems to be all about Methods so that seems like the place
> to put this.
Clae
51 matches
Mail list logo
