Re: Jar manifest and EOF character (code 26)

2019-11-03 Thread Philipp Kunz
Hi Max, Even if it was easy to implement, I don't think we actually would want it. Hopefully not put too much to the point, it sound like last century operating with punch cards. The discussed portion of the specification refers to "EOF character (code 26)" and also I am not talking about an end

Re: RFR: 8233291: [TESTBUG] tools/jlink/plugins/VendorInfoPluginsTest.java fails with debug VMs

2019-11-03 Thread Jie Fu
Thank you so much, Mandy. On 2019/11/4 上午11:49, Mandy Chung wrote: Looks good.  I'll sponsor it.

Re: RFR: 8233291: [TESTBUG] tools/jlink/plugins/VendorInfoPluginsTest.java fails with debug VMs

2019-11-03 Thread Mandy Chung
Hi Jie, On 11/2/19 4:46 AM, Jie Fu wrote: Hi Mandy, Thanks for your review and valuable comments. Updated: http://cr.openjdk.java.net/~jiefu/8233291/webrev.02/ Looks good.  I'll sponsor it. Mandy Testing:   --    

Re: RFR of JDK-8233313: server socket created by LocateRegistry.createRegistry(0) can not be closed

2019-11-03 Thread Hamlin Li
Thanks Roger. On 2019/11/1 11:14 PM, Roger Riggs wrote: Hi Hamlin, I would expect endPoint().getPort() to be non-zero except during the narrow window of the initialization before the server socket is opened. See TCPEndPoint.listen(). I assumed you mean TCPTransport.listen(). If that's