Re: RFR: JDK-8233591: Reorder jpackage help text to focus on package

2019-11-09 Thread Alexey Semenyuk
Kevin, My point was to add consistency. We used to have class names in camel case and pascal case (className, ClassName) and this didn't look right for me. I agree ClassName, `mypkg` is more appropriate. I'm neutral about myJar.jar and MyJar.jar. - Alexey On 11/9/2019 12:37 AM, Kevin

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

2019-11-09 Thread Mandy Chung
The patch looks fine to me as well. As for the test, perhaps adding a new createAFile(File aFile, List lines, boolean hasTrailingBlankLine) in TestHelper instead may help avoid any confusion. Mandy On 11/8/19 7:43 AM, Mat Carter wrote: Hi Alan The method you propose: