Re: RFR of JDK-8232446: logging enhancement for rmi when socket closed

Hi Roger, Thank you for reviewing, I have updated as you suggested: http://cr.openjdk.java.net/~mli/8232446/webrev.01/ Thank you -Hamlin On 2019/11/18 11:48 PM, Roger Riggs wrote: Hi Hamlin, TCPConnection.java:212: Keep the "close connection" logging and add the socket to the same log

Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

Hi everyone, a few hours ago I signed the Oracle Contributor Agreement. I'd like to work on JDK-8229959: Convert proxy class to use constant dynamic. Without further ado, here are some questions and answers you may ask: * What are you exactly planing to do? I'd like to replace the GETSTATIC

Re: RFR: JEP 367: Remove the Pack200 Tools and API

Hi Mandy, On 11/21/19 5:45 PM, Mandy Chung wrote: CSR needs to mention that jar -n option is removed.  I made minor edit to the CSR to state that jdk.pack module is removed. thanks for the changes, I added a mention to the jar -n option, Mandy Thanks, Vicente On 11/21/19 2:22 PM,

Re: RFR [14/java.xml] 8233548: Update CUP to v0.11b

Thanks Lance! -Joe On 11/21/19 3:59 PM, Lance Andersen wrote: Hi Joe, Looks OK overall. Best Lance On Nov 20, 2019, at 4:48 PM, Joe Wang > wrote: Hi, Please review an update to Java CUP. This is an effort to move to the latest version, v0.11b. JCUP is used

Re: RFR [14/java.xml] 8233548: Update CUP to v0.11b

Hi Joe, Looks OK overall. Best Lance > On Nov 20, 2019, at 4:48 PM, Joe Wang wrote: > > Hi, > > Please review an update to Java CUP. This is an effort to move to the latest > version, v0.11b. JCUP is used by Xalan to generate XPathParser. Included in > the JDK are runtime classes and

RE: RFR: 8234089: (zipfs) Remove classes JarFileSystemProvider and JarFileSystem

Hi Lance, thanks again. Makes sense to keep comments consistent. So this is what I’m going to push tomorrow: http://cr.openjdk.java.net/~clanger/webrevs/8234089.5/ Cheers Christoph From: Lance Andersen Sent: Mittwoch, 20. November 2019 19:02 Cc: Langer, Christoph ; nio-dev ;

Re: RFR: JEP 367: Remove the Pack200 Tools and API

CSR needs to mention that jar -n option is removed.  I made minor edit to the CSR to state that jdk.pack module is removed. Mandy On 11/21/19 2:22 PM, Vicente Romero wrote: please wait, I found some additional dependencies on module jdk.pack, will submit another webrev, sorry Vicente On

Re: RFR: JEP 367: Remove the Pack200 Tools and API

please wait, I found some additional dependencies on module jdk.pack, will submit another webrev, sorry Vicente On 11/21/19 2:53 PM, Vicente Romero wrote: Hi, I think I have covered all the proposed fixes so far. This is the last iteration of the webrev [1], all the current changes are in

RE: RFR [XS] : 8234339: replace JLI_StrTok in java_md_solinux.c

+1 > -Original Message- > From: core-libs-dev On Behalf > Of Roger Riggs > Sent: Mittwoch, 20. November 2019 16:08 > To: core-libs-dev@openjdk.java.net > Subject: Re: RFR [XS] : 8234339: replace JLI_StrTok in java_md_solinux.c > > Hi Matthias, > > Good to see the switch to strtok_r. >

Re: RFR: JEP 367: Remove the Pack200 Tools and API

Hi, I think I have covered all the proposed fixes so far. This is the last iteration of the webrev [1], all the current changes are in this one, the code hasn't been split into different webrevs. I'm also forwarding to build-dev as there are some build related changes too. The CSR for this

Re: Turkish Time Zone name string and translation

Hi Letu, The change in the resource bundle file looks good. As to the regression test, I would avoid adding a separate file, instead add some variations for open/test/jdk/sun/text/resources/LocaleDataTest.java as I mentioned. Add some lines in "LocaleData" file, which contains the expected

Re: JDK14 RFR of JDK-8234381: API docs should mention special handling of enums in serialization

LGTM Joe. -Chris. > On 19 Nov 2019, at 18:21, Joe Darcy wrote: > > Hello, > > Please review this small doc changes to more explicitly discuss the special > handling of enum types by serialization: > > JDK-8234381: API docs should mention special handling of enums in > serialization >

RE: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

Hi Alan, thanks for the review. I'll push it then after running through jdk-submit. /Christoph > -Original Message- > From: Alan Bateman > Sent: Donnerstag, 21. November 2019 09:51 > To: Langer, Christoph ; core-libs- > d...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net >

Re: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

On 14/11/2019 15:37, Langer, Christoph wrote: Hi, please review this cleanup change regarding function "canonicalize" of libjava. Bug: https://bugs.openjdk.java.net/browse/JDK-8234185 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8234185.0/ The goal is to cleanup how this function is

RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

Hello, gcc and ld can be instructed to work together to "garbage collect" unused input sections. This feature eliminates unused code from native libraries. As a prerequisite to take full advantage of the feature, the source files need to be compiled with "-ffunction-sections -fdata-sections".