Re: RFR 8234423 : Modifying ArrayList.subList().subList() resets modCount of subList

2019-11-22 Thread Ivan Gerasimov
Re-sending the request with the correct Subject line - the bug is not (only) about the iterator. On 11/20/19 10:11 PM, Ivan Gerasimov wrote: Hello! When a sublist of a sublist of an ArrayList is created, its modCount is initialized from the ArrayList root, and not from its immediate parent.

Re: Turkish Time Zone name string and translation

2019-11-22 Thread Yang, Letu
Hi Naoto, Added it in the new webrev https://cr.openjdk.java.net/~xliu/8234288/webrev.03/ . Thanks! Letu On Nov 22, 2019 4:40 PM, naoto.s...@oracle.com wrote: Hi Letu, You might want to add lines for "Turkey" zone as well in LocaleData? Naoto On 11/22/19 4:16 PM, Yang, Letu wrote: > Hi Naot

Re: 8179320: File.getUsableSpace() returns a negative number on very large file system

2019-11-22 Thread Weijun Wang
Just curious. Why is fs.getSpace() returning negative here? Naively, I would think it is truncating an int128 to int64. If so, if the value exceeds 2^64, will it be positive again? Thanks, Max > On Nov 23, 2019, at 1:40 AM, Brian Burkhalter > wrote: > > PING! > >> Begin forwarded message:

Re: Turkish Time Zone name string and translation

2019-11-22 Thread naoto . sato
Hi Letu, You might want to add lines for "Turkey" zone as well in LocaleData? Naoto On 11/22/19 4:16 PM, Yang, Letu wrote: Hi Naoto, Thank you for the advice! I've uploaded a new version: https://cr.openjdk.java.net/~xliu/8234288/webrev.02/webrev/ Letu On 11/21/19, 9:18 AM, "naoto.s...@or

Re: RFR(s): 8176894 Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute, merge in TreeMap

2019-11-22 Thread Sergey Kuksenko
Thanks! Looks good. The only I have comments for added microbenchmark: * Keys and values should be preallocated in setup. We want to measure TreeMap, not boxing. I'd prefer to see preallocated array of keys. * What is the reason to have "shuffled" parameter? Random keys distribution is more p

Re: Turkish Time Zone name string and translation

2019-11-22 Thread Yang, Letu
Hi Naoto, Thank you for the advice! I've uploaded a new version: https://cr.openjdk.java.net/~xliu/8234288/webrev.02/webrev/ Letu On 11/21/19, 9:18 AM, "naoto.s...@oracle.com" wrote: Hi Letu, The change in the resource bundle file looks good. As to the regression test,

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-22 Thread Mandy Chung
On 11/22/19 2:05 PM, Johannes Kuhn wrote: On 22.11.2019 22:41, Remi Forax wrote: i wonder if some codes in the wild rely on that ? I don't think some code does, but you never know. There is perhaps a better way, as part of the branch nestmates of valhalla, Mandy has added a way to transfer

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-22 Thread Johannes Kuhn
On 22.11.2019 22:41, Remi Forax wrote: i wonder if some codes in the wild rely on that ? I don't think some code does, but you never know. There is perhaps a better way, as part of the branch nestmates of valhalla, Mandy has added a way to transfer a live object to a Class when defining it, w

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-22 Thread Johannes Kuhn
Last mail got converted from HTML into plaintext, which dropped some significant whit espace. So, again, doing it by hand this time. On 22.11.2019 20:52, Brian Goetz wrote: > For those that are not intimately familiar with the mechanics of proxy class generation, it would be great to flesh this

Re: RFR: JEP 367: Remove the Pack200 Tools and API

2019-11-22 Thread Erik Joelsson
Hello, On 2019-11-22 13:30, Vicente Romero wrote: Hi all, On 11/22/19 3:21 AM, Alan Bateman wrote: On 21/11/2019 19:53, Vicente Romero wrote: Hi, I think I have covered all the proposed fixes so far. This is the last iteration of the webrev [1], all the current changes are in this one, t

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-22 Thread Remi Forax
- Mail original - > De: "Johannes Kuhn" > À: "core-libs-dev" > Envoyé: Vendredi 22 Novembre 2019 04:23:31 > Objet: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant > dynamic > Hi everyone, Hi Johannes, > > a few hours ago I signed the Oracle Contributor Agreement.

Re: RFR: JEP 367: Remove the Pack200 Tools and API

2019-11-22 Thread Vicente Romero
Hi all, On 11/22/19 3:21 AM, Alan Bateman wrote: On 21/11/2019 19:53, Vicente Romero wrote: Hi, I think I have covered all the proposed fixes so far. This is the last iteration of the webrev [1], all the current changes are in this one, the code hasn't been split into different webrevs. I'

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-22 Thread Johannes Kuhn
On 22.11.2019 20:52, Brian Goetz wrote: For those that are not intimately familiar with the mechanics of proxy class generation, it would be great to flesh this out with a code example, that shows the proposed old and new translation. This would make it easier for folks to evaluate the benefits

Re: 8179320: File.getUsableSpace() returns a negative number on very large file system

2019-11-22 Thread Roger Riggs
Hi Brian, The updated wording looks fine. Roger On 11/22/19 12:40 PM, Brian Burkhalter wrote: PING! Begin forwarded message: From: Brian Burkhalter Subject: Re: 8179320: File.getUsableSpace() returns a negative number on very large file system Date: November 15, 2019 at 2:40:06 PM PST To

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-22 Thread Brian Goetz
For those that are not intimately familiar with the mechanics of proxy class generation, it would be great to flesh this out with a code example, that shows the proposed old and new translation. This would make it easier for folks to evaluate the benefits and costs of the approach, and possibly

Re: Class-Path (in jar file) semantics different between Java 11 and 13 (on Windows)?

2019-11-22 Thread Brent Christian
Hi, Jaikiran On 11/18/2019 7:56 AM, Jaikiran Pai wrote: The actual code which does this construction, resides here[2] . I see at [3] that '/' is prepended to the path. As Alan suggested [4], prepending with "file:/" ought to get it working. -Brent 2. https://github.com/quarkusio/quarkus/b

Re: (XS) RFR JDK-8233956: MethodHandles.dropArguments javadoc lists parameters in wrong order

2019-11-22 Thread Mandy Chung
Thanks for the prompt review. Mandy On 11/22/19 11:26 AM, Jonathan Gibbons wrote: Looks good to me. -- Jon On 11/22/19 11:17 AM, Mandy Chung wrote: This patch reorders `@param pos` of MethodHandles.dropArguments matching the method signature. It'd be nice if javadoc generates with the orde

Re: (XS) RFR JDK-8233956: MethodHandles.dropArguments javadoc lists parameters in wrong order

2019-11-22 Thread Jonathan Gibbons
Looks good to me. -- Jon On 11/22/19 11:17 AM, Mandy Chung wrote: This patch reorders `@param pos` of MethodHandles.dropArguments matching the method signature. It'd be nice if javadoc generates with the ordered list of @params matching the method signature (I created JDK-8234682). diff --

(XS) RFR JDK-8233956: MethodHandles.dropArguments javadoc lists parameters in wrong order

2019-11-22 Thread Mandy Chung
This patch reorders `@param pos` of MethodHandles.dropArguments matching the method signature. It'd be nice if javadoc generates with the ordered list of @params matching the method signature (I created JDK-8234682). diff --git a/src/java.base/share/classes/java/lang/invoke/MethodHandles.jav

Re: 8179320: File.getUsableSpace() returns a negative number on very large file system

2019-11-22 Thread Brian Burkhalter
PING! > Begin forwarded message: > > From: Brian Burkhalter > Subject: Re: 8179320: File.getUsableSpace() returns a negative number on very > large file system > Date: November 15, 2019 at 2:40:06 PM PST > To: Alan Bateman > Cc: Core-Libs-Dev > > >> On Nov 15, 2019, at 2:59 AM, Alan Bateman

RE: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-11-22 Thread Baesken, Matthias
Hi Erik, yes it makes the build more chatty - our linux s390 product build log of jdk/jdk goes from ~ 60.000 lines to ~ 123.000 lines with the patch. However the change is linux s390 only so I guess it will not disturb other people ( in case we bring it to more platforms la

Re: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-11-22 Thread Erik Joelsson
Hello Matthias, This looks like an interesting change. If you want to enable this for s390x, I'm ok with it. If it works out well, perhaps we can find a way to expand this to other architectures. Do you really want to set --print-gc-sections by default? I would assume that makes the build qu

RE: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

2019-11-22 Thread Langer, Christoph
Hi, I'd like to push this change. However, running it through jdk-submit shows reproducible errors: Job: mach5-one-clanger-JDK-8234185-1-20191122-0927-6913189 BuildId: 2019-11-22-0926373.christoph.langer.source No failed tests Tasks Summary • NA: 0 • NOTHING_TO_RUN: 0 • K

RE: RFR [XS] : 8234339: replace JLI_StrTok in java_md_solinux.c

2019-11-22 Thread Baesken, Matthias
Hi Christoph / Roger , thanks for the reviews ! Best regards , Matthias > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 21. November 2019 23:13 > To: Roger Riggs ; core-libs- > d...@openjdk.java.net; Baesken, Matthias > Subject: RE: RFR [XS] : 8234339: replace JLI_Str

Re: RFR: JEP 367: Remove the Pack200 Tools and API

2019-11-22 Thread Alan Bateman
On 21/11/2019 19:53, Vicente Romero wrote: Hi, I think I have covered all the proposed fixes so far. This is the last iteration of the webrev [1], all the current changes are in this one, the code hasn't been split into different webrevs. I'm also forwarding to build-dev as there are some