Re: RFR: JDK-8235954: [dmg] Default DMG background tiff of jpackage not retina ready

2020-01-27 Thread Andy Herrick
looks good. /Andy On 1/27/2020 6:00 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. - Updated background image with one which supports retina display. [1] https://bugs.openjdk.java.net/browse/JDK-8235954 [2] http://cr.openjdk.java.net/~almatvee/8235954/webrev.

Re: RFR: JDK-8235954: [dmg] Default DMG background tiff of jpackage not retina ready

2020-01-27 Thread Alexey Semenyuk
Looks good. - Alexey On 1/27/2020 6:00 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. - Updated background image with one which supports retina display. [1] https://bugs.openjdk.java.net/browse/JDK-8235954 [2] http://cr.openjdk.java.net/~almatvee/8235954/webr

RFR: JDK-8235954: [dmg] Default DMG background tiff of jpackage not retina ready

2020-01-27 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. - Updated background image with one which supports retina display. [1] https://bugs.openjdk.java.net/browse/JDK-8235954 [2] http://cr.openjdk.java.net/~almatvee/8235954/webrev.00/ Thanks, Alexander

Re: [14] RFR (doc) 8237651 Clarify initialization of jdk.serialFilter

2020-01-27 Thread Sean Mullan
Hi Roger, Does setting jdk.serialFilter with Security.setProperty() work, or must it only be pre-configured in the java.security file? --Sean On 1/24/20 2:51 PM, Roger Riggs wrote: Please review a doc change in the description of the initialization of the jdk.serialFilter from a system prop

Re: New candidate JEP: 371: Hidden Classes

2020-01-27 Thread David Lloyd
On Mon, Jan 27, 2020 at 12:30 PM Mandy Chung wrote: > > > > On 1/27/20 6:31 AM, Remi Forax wrote: > > I'm a bit curious about this: > > To invoke private nestmate instance methods from code in the hidden class, use > invokevirtual or invokeinterface instead of invokespecial. Generated bytecode > t

Re: New candidate JEP: 371: Hidden Classes

2020-01-27 Thread Mandy Chung
On 1/27/20 6:31 AM, Remi Forax wrote: I'm a bit curious about this: To invoke private nestmate instance methods from code in the hidden class, use invokevirtual or invokeinterface instead of invokespecial. Generated bytecode that uses invokespecial to invoke a private nestmate instance metho

Re: [15] 8219567: One of the RandomAccessFile constructor's parameter is not properly named

2020-01-27 Thread naoto . sato
LGTM. Naoto On 1/24/20 6:49 PM, Brian Burkhalter wrote: Please review this minor change [1] to address [2]. If it looks worthwhile to address then a CSR will be filed. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/8219567/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-8219567

Re: New candidate JEP: 371: Hidden Classes

2020-01-27 Thread Remi Forax
- Mail original - > De: "David Lloyd" > À: "David Holmes" > Cc: "hotspot-dev" , "core-libs-dev" > > Envoyé: Lundi 27 Janvier 2020 14:56:57 > Objet: Re: New candidate JEP: 371: Hidden Classes > On Fri, Jan 24, 2020 at 4:56 PM David Holmes wrote: >> >> FYI. > > I'm a bit curious about

Re: New candidate JEP: 371: Hidden Classes

2020-01-27 Thread David Lloyd
On Fri, Jan 24, 2020 at 4:56 PM David Holmes wrote: > > FYI. I'm a bit curious about this: > To invoke private nestmate instance methods from code in the hidden class, > use invokevirtual or invokeinterface instead of invokespecial. Generated > bytecode that uses invokespecial to invoke a priv

Re: RFR: 8237521: Memory Access API fixes for 32-bit

2020-01-27 Thread Maurizio Cimadamore
On 27/01/2020 06:41, Nick Gasson wrote: Hi David, On 01/25/20 06:34 am, David Holmes wrote: I've done this here: http://cr.openjdk.java.net/~ngasson/8237521/webrev.02/ Need to check bytes >= 0 before aligning up so that allocateMemory(-1) still throws an IllegalArgumentException. That look

Re: New candidate JEP: 371: Hidden Classes

2020-01-27 Thread Claes Redestad
On 2020-01-26 13:18, Michael Paus wrote: Am 26.01.20 um 13:00 schrieb core-libs-dev-requ...@openjdk.java.net: Message: 1 Date: Sat, 25 Jan 2020 09:07:23 -0800 From: Mandy Chung This would help the reflective support for inline classes and new VM/language feature such that adding support in

Re: New candidate JEP: 371: Hidden Classes

2020-01-27 Thread Thomas Stüfe
On Sat, Jan 25, 2020 at 6:09 PM Mandy Chung wrote: > > > On 1/24/20 9:15 PM, Bernd Eckenfels wrote: > > Hello, > > > > I wonder will this (weak class) be useful for reflective method > > accessors and even be able to reduce/remove the need of > > jdk.internal.reflect.DelegatingClassLoaders? If so