Re: Review Request JDK-8228336: Refactor native library loading implementation

On 3/11/20 10:25 AM, Daniel Fuchs wrote: Hi Mandy, On 11/03/2020 16:10, Alan Bateman wrote: I'm open to other suggestion.  This helper method avoids the call to doPrivileged when security manager is enabled and I think it's okay to add this helper method in sun.security.action package. Boot

RFR 8240704: CheckHandles.java failed "AssertionError: Handle use increased by more than 10 percent."

Please review a test improvement to avoid counting unexpected handles. The test for 8239893[1]failed when non-test activities used handles. The test is modified to do a warmup phase spawning some processes and cleaning up. It then runs the test to create processes looking for no significant inc

Re: RFR(S): 8240734: ModuleHashes attribute not reproducible between builds

On 3/11/20 12:21 AM, Yangfei (Felix) wrote: -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Wednesday, March 11, 2020 3:03 PM To: Yangfei (Felix) ; core-libs-dev@openjdk.java.net Subject: Re: RFR(S): 8240734: ModuleHashes attribute not reproducible between

Re: Review Request JDK-8228336: Refactor native library loading implementation

Hi Mandy, On 11/03/2020 16:10, Alan Bateman wrote: I'm open to other suggestion.  This helper method avoids the call to doPrivileged when security manager is enabled and I think it's okay to add this helper method in sun.security.action package. BootLoader defines methods to correspond to the m

Re: 6202130: Need to handle UTF-8 values and break up lines longer than 72 bytes

Hi Phillip, Sure. Would you please file Grapheme related issues at bugs.java.com? This is the route for whom doesn't have JBS id to file bugs. Naoto On 3/10/20 11:27 PM, Philipp Kunz wrote: Hi Naoto, Thank you for your reply. I fully agree to your reluctance or inhibition to change the reg

Re: RFR: 8238665: Add JFR event for direct memory statistics

On 08/03/2020 15:42, Denghui Dong wrote: Hi Alan and Erik, Thanks for the review. Webrev has been updated in http://cr.openjdk.java.net/~ddong/8238665/webrev.02/ Can you trying moving JavaNioAccess.BufferPool to VM? I think that would help clean this up a bit and avoid having jdk.internal.acc

Re: Review Request JDK-8228336: Refactor native library loading implementation

On 10/03/2020 04:53, Mandy Chung wrote: Hi David, On 3/9/20 7:41 PM, David Holmes wrote: That's a core-libs decision but I'm not sure that's a namespace we want to increase usage of. I'm open to other suggestion.  This helper method avoids the call to doPrivileged when security manager is

Re: RFR: 8230117 removing dead code from jar tool

FYI I will be pushing today after one last Mach 5 run completes -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com > On Mar 11, 2020, at 8:16 AM, Langer, Christoph > wrote: > > 

RE: RFR: 8230117 removing dead code from jar tool

Hi Adam, thanks for opening up the bug and reposting. Looks good to me 😊 Cheers Christoph From: Adam Sotona Sent: Mittwoch, 11. März 2020 11:32 To: Langer, Christoph Cc: Lance Andersen ; Sean Mullan ; core-libs-dev@openjdk.java.net Subject: Re: RFR: 8230117 removing dead code from jar tool H

Re: RFR: 8230117 removing dead code from jar tool

Hi Christoph, thank you for clarification, here it is: JBS: https://bugs.openjdk.java.net/browse/JDK-8230117 webrev: http://cr.openjdk.java.net/~asotona/8230117/webrev.00/ Mach5 Tier1, T

RE: RFR(S): 8240734: ModuleHashes attribute not reproducible between builds

> -Original Message- > From: Alan Bateman [mailto:alan.bate...@oracle.com] > Sent: Wednesday, March 11, 2020 3:03 PM > To: Yangfei (Felix) ; core-libs-dev@openjdk.java.net > Subject: Re: RFR(S): 8240734: ModuleHashes attribute not reproducible > between builds > > On 11/03/2020 01:11, Yang

Re: RFR: 8238665: Add JFR event for direct memory statistics

Ping. Could you review this? Thanks, Denghui Dong -- From:董登辉(卓昂) Send Time:2020年3月8日(星期日) 23:42 To:Erik Gahlin ; Alan Bateman Cc:hotspot-jfr-dev ; core-libs-dev Subject:Re: RFR: 8238665: Add JFR event for direct memory statistics

Re: RFR(S): 8240734: ModuleHashes attribute not reproducible between builds

On 11/03/2020 01:11, Yangfei (Felix) wrote: Thanks for reviewing this. Pushed. Okay but I think we need to add a test for this. Can you look at JLinkReproducibleTest and see if it can be extended to use --keep-packaged-modules so that you have the JMOD files in the run-time image. -Alan