Re: JDK-8226810: An other case and a small change suggestion

On 10/05/2020 15:47, Johannes Kuhn wrote: : After the discussion with Naoto, I would like to change the one line to strcpy(ret + 2, "1252") diff --git a/src/java.base/windows/native/libjava/java_props_md.c b/src/java.base/windows/native/libjava/java_props_md.c --- a/src/java.base/windows

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

On 08/05/2020 18:19, Fernando Guallini wrote: Hi Daniel and Alan, @compile/module=java.xml was my first try, but for the nature of this test, it didn't work. The reason is that the original shell test does the following: - Compiles it’s own version of Node and Document interfaces - Compiles Do

[PING] RFR: JDK-8244288 Specialized implementations for putIfAbsent, merge, compute* methods in TreeMap derived maps

Hello! A gentle ping: please review https://bugs.openjdk.java.net/browse/JDK-8244288 http://cr.openjdk.java.net/~tvaleev/webrev/8244288/r1/ The details are listed below. With best regards, Tagir Valeev. On Sun, May 3, 2020 at 4:36 PM Tagir Valeev wrote: > > Hello! > > Please review the followin

RFR: 8193066: Avoid use of capturing lambdas in JarFile

Hi, lambdas used in the interaction between JarFile and ZipFile can be avoided by having ZipFile call a shared secret in JarFile to create a JarFileEntry when appropriate. This removes an allocation per lookup. Bug:https://bugs.openjdk.java.net/browse/JDK-8193066 Webrev: http://cr.openjdk.ja

RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

Hi, Please review the fix for the following issue. https://bugs.openjdk.java.net/browse/JDK-6470126 diff -r 53568400fec3 src/java.base/share/classes/java/util/jar/Attributes.java --- a/src/java.base/share/classes/java/util/jar/Attributes.java Thu Mar 26 15:26:51 2020 + +++ b/src/java.base/

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

Hi Vipin, making containsKey("key") return true without also ensuring the other Map operations like get, put, .. work consistently and transparently with String keys seem like a partial fix that will subtly break operations like getOrDefault. And why not "if (name instanceof String)"? Thanks!

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

On 11/05/2020 12:44, Claes Redestad wrote: Hi Vipin, making containsKey("key") return true without also ensuring the other Map operations like get, put, .. work consistently and transparently with String keys seem like a partial fix that will subtly break operations like getOrDefault. Yeah, I th

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

Hi Vipin, When you submit your revised patch addressing the input previously provided, please include a test case which exercises the various methods. Best Lance > On May 11, 2020, at 7:54 AM, Alan Bateman wrote: > > On 11/05/2020 12:44, Claes Redestad wrote: >> Hi Vipin, >> >> making cont

BigInteger.squareToLen() can be wrong (when called directly)

Hi. While trying to use BigInteger.squareToLen(x, len, z) directly (with reflection), I saw that its pure Java implementation computed wrong results when a 'z' is specified with (z.length > 2 * len). Ex.: x = {1, 2} len = 2 with z.length = 4: {0, 1, 4, 4} (as expected) with z.length = 5: {0, 1, 0,

Re: JDK-8226810: An other case and a small change suggestion

On 11-May-20 10:59, Alan Bateman wrote: On 10/05/2020 15:47, Johannes Kuhn wrote: : After the discussion with Naoto, I would like to change the one line to strcpy(ret + 2, "1252") diff --git a/src/java.base/windows/native/libjava/java_props_md.c b/src/java.base/windows/native/libjava/java

Re: RFR: 8193066: Avoid use of capturing lambdas in JarFile

Hi Claes, I think this looks good. Thank you for making JarFile zippier ;-) > On May 11, 2020, at 5:50 AM, Claes Redestad wrote: > > Hi, > > lambdas used in the interaction between JarFile and ZipFile can be > avoided by having ZipFile call a shared secret in JarFile to create a > JarFileEntr

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

On 5/11/2020 2:32 AM, Alan Bateman wrote: On 08/05/2020 18:19, Fernando Guallini wrote: Hi Daniel and Alan, @compile/module=java.xml was my first try, but for the nature of this test, it didn't work. The reason is that the original shell test does the following: - Compiles it’s own version

Re: RFR: 8193066: Avoid use of capturing lambdas in JarFile

Hi Lance, thank you for reviewing! /Claes On 2020-05-11 18:01, Lance Andersen wrote: Hi Claes, I think this looks good.  Thank you for making JarFile zippier ;-) On May 11, 2020, at 5:50 AM, Claes Redestad > wrote: Hi, lambdas used in the interaction betw

Re: RFR: JDK-8244620: test failure in WinUpgradeUUIDTest

+1 -phil. On 5/8/20, 4:34 PM, Andy Herrick wrote: Revised webrev at [3] - this fixes the test problem that was caused by the test assuming wix tools are on all systems. /Andy [3] - http://cr.openjdk.java.net/~herrick/8244620/webrev.02/ On 5/7/2020 4:23 PM, Andy Herrick wrote: please review

Re: [8u] RFR(S): 8244548: JDK 8u: sun.misc.Version.jdkUpdateVersion() returns wrong result

On Thu, May 7, 2020 at 8:18 AM Severin Gehwolf wrote: > Thus, the new upper bound for update > version number is 2^16-1 => 65535 which should be sufficient. I don't > think OpenJDK 8u will live that long ;-) Everyone expected 256 to be sufficient for update release numbering, before the gaps in t

Re: RFR: JDK-8244620: test failure in WinUpgradeUUIDTest

Looks good. - Alexey On 5/8/2020 7:34 PM, Andy Herrick wrote: Revised webrev at [3] - this fixes the test problem that was caused by the test assuming wix tools are on all systems. /Andy [3] - http://cr.openjdk.java.net/~herrick/8244620/webrev.02/ On 5/7/2020 4:23 PM, Andy Herrick wrote: p

RFR: (CSR) JDK-8236688 Clarify String::stripIndent javadoc when string ends with line terminator

Sponsoring for Andrew Leonard. Please review the following CSR. Hopefully this clarifies user's misunderstanding when a line seems to disappear when the string ends with a line terminator. CSR: https://bugs.openjdk.java.net/browse/JDK-8236688 JBS: https://bugs.openjdk.java.net/browse/JDK-82308

Re: RFR: 8244624: Improve handling of JarFile META-INF resources

Looks good, Claes. Just one small question: src/java.base/share/classes/java/util/jar/JarFile.java 759 } catch (IOException | IllegalArgumentException ex) { Why the addition of IllegalArgumentException ? -Brent On 5/10/20 2:07 PM, Claes Redestad wrote: Hi Martin, On 2020-05-10 21

Re: RFR(s): 8244659: Improve ZipFile.getInputStream

Hi Volker, Could you update your patch now that Claes’s changes are back as I think that would make it easier to review Thank you! > On May 8, 2020, at 11:36 AM, Volker Simonis wrote: > > Hi, > > can I please have a review for the following small enhancement which > improves the speed of re

RFR: 8244767 - Potential non-terminated string in getEncodingInternal() on Windows

Hi, Please review this small fix in Windows native code: Bug: https://bugs.openjdk.java.net/browse/JDK-8244767 Webrev: http://cr.openjdk.java.net/~bchristi/8244767/webrev-00/ As reported on this thread[1], the getEncodingInternal() function has a potential unterminated string in the case th

RFR: JDK-8244634:, LoadLibraryW failed from tools/jpackage tests after JDK-8242302

Please review fix [2] for jpackage bug [1]. Fix failure to load jli.dll from app launcher. The fix is to append path to directory with jli.dll to PATH env variable and load jli.dll with altered value of PATH if the first attempt to load jli.dll without altering PATH fails. - Alexey [1] http

Re: JDK-8226810: An other case and a small change suggestion

FYI, I've filed a new issue[1] for this fix, and requested a code review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-May/066384.html I don't believe I need anything else, Johannes. Thank you! -Brent 1. https://bugs.openjdk.java.net/browse/JDK-8244767 On 5/10/20 7:47 AM, Johann

Re: RFR: 8244767 - Potential non-terminated string in getEncodingInternal() on Windows

Hi Brent, It looks OK to me. Brian > On May 11, 2020, at 4:36 PM, Brent Christian > wrote: > > Please review this small fix in Windows native code: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8244767 > > Webrev: http://cr.openjdk.ja

Re: RFR: 8244767 - Potential non-terminated string in getEncodingInternal() on Windows

+1 Naoto On 5/11/20 5:25 PM, Brian Burkhalter wrote: Hi Brent, It looks OK to me. Brian On May 11, 2020, at 4:36 PM, Brent Christian wrote: Please review this small fix in Windows native code: Bug: https://bugs.openjdk.java.net/browse/JDK-8244767

Re: RFR: JDK-8244634:, LoadLibraryW failed from tools/jpackage tests after JDK-8242302

Hi Alexey, Updating PATH does not look like good solution to me. Did you try to load jli.dll by specifying full path to jli.dll when calling LoadLibary? If it does not work, then for AddDllDirectory() did you used LoadLibrary() or LoadLibraryEx() with LOAD_LIBRARY_SEARCH_USER_DIRS? According

RE: RFR: 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests

Ping.. -Original Message- From: Thejasvi Voniadka Sent: Friday, May 8, 2020 6:17 AM To: core-libs-dev@openjdk.java.net; jmx-...@openjdk.java.net; security-...@openjdk.java.net Subject: RFR: 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests Hi, May someone please sp