Re: RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

Hi Alexey, http://cr.openjdk.java.net/~almatvee/8248059/webrev.01/ - Removed getFilesSizeInFolder() method and size will be calculated as per your suggestion. Thanks, Alexander On 6/26/20 8:16 PM, Alexey Semenyuk wrote: Hi Alexander, MacDmgBundler.java: ---   94 } catch (IOException

Re: RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

Hi Alexander, MacDmgBundler.java: ---   94 } catch (IOException | PackagerException ex) {   95 Log.verbose(ex);   96 throw new PackagerException(ex);   97 } --- There is no need to add IOUtils.getFilesSizeInFolder() method. --- new PathGroup(Map.of(new Ob

RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

Please review the jpackage fix for bug [1] at [2]. Added fallback for creating DMG if original approach fails. In original approach DMG will be created by providing app image to hdiutil. It was noticed that helper sub-processes run by hdiutil to copy app image sometimes crashed or failed durin

Re: RFR: JDK-8248254: jpackage fails if app module is in external runtime

Hi Alexey, Looks good. Thanks, Alexander On 6/26/20 4:30 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Fix jpackage code to be able to locate app module if it is linked in external runtime. The suggested fix only verifies if app module exists in external runtime. It

Re: RFR: JDK-8248427: jpackage jtreg BasicTest.testTemp() test fails on Windows

Hi Alexey, Looks good. Thanks, Alexander On 6/26/20 2:02 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Makes value of `JpIcon` wix variable absolute path. This fixes a regression introduced by the fix of [3] issue. - Alexey [1] https://bugs.openjdk.java.net/browse

Re: RFR: JDK-8248264: WinUpgradeUUIDTest application is missing in downgrade scenario

Hi Alexey, Looks good. Thanks, Alexander On 6/26/20 9:48 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Put `RemoveExistingProducts` action before `CostInitialize` action in `InstallExecuteSequence` sequence to uninstall existing product(s) before installer makes cha

RFR: JDK-8248254: jpackage fails if app module is in external runtime

Please review fix [2] for jpackage bug [1]. Fix jpackage code to be able to locate app module if it is linked in external runtime. The suggested fix only verifies if app module exists in external runtime. It doesn't extract version and main class from modules in exetrnal runtime. To address th

Re: RFR: JDK-8248427: jpackage jtreg BasicTest.testTemp() test fails on Windows

looks yet /Andy On 6/26/2020 5:02 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Makes value of `JpIcon` wix variable absolute path. This fixes a regression introduced by the fix of [3] issue. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8248427 [2] http:/

RFR: JDK-8248427: jpackage jtreg BasicTest.testTemp() test fails on Windows

Please review fix [2] for jpackage bug [1]. Makes value of `JpIcon` wix variable absolute path. This fixes a regression introduced by the fix of [3] issue. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8248427 [2] http://cr.openjdk.java.net/~asemenyuk/8248427/webrev.00 [3] https://b

Re: RFR; [docs,15] JDK-8248060 small HTML issues in java.xml package-info.java files

Looks good to me. The upstream SAX hasn't evolved for a long time (and there's no plan to do so). I think we're okay to make small changes. For the 2nd case, I think it's good enough since there are links to the classes at the beginning of the sentence -- a minor inconvenience (vs a straight l

Re: RFR [16/java.xml] 8248348: Regression caused by the update to BCEL 6.0

On 6/25/20 4:53 PM, Joe Wang wrote: Please review a fix to a BCEL regression. At issue was the addition of hashCode() method to Instruction.java in BCEL 6.0. This hashCode() method was implemented to return the instruction's opcode that unfortunately is mutable. The problem hasn't showed up

Re: RFR: JDK-8248264: WinUpgradeUUIDTest application is missing in downgrade scenario

looks good. /Andy On 6/26/2020 12:48 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Put `RemoveExistingProducts` action before `CostInitialize` action in `InstallExecuteSequence` sequence to uninstall existing product(s) before installer makes changes to the file syst

Re: RFR [16/java.xml] 8248348: Regression caused by the update to BCEL 6.0

Hi Peter, Yes, they must agree: o1.equals(o2) => o1.hashCode() == o2.hashCode(). I think that was the original motivation in BCEL 6.0 to add the hashCode() method since before that, the Instruction class overrode equals() but not hashCode(), so two Instructions that were equal had different h

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

Hi, Thanks for the feedback so far. We'll get back on the suggested implementation and signature changes individually. Regarding the naming, Paul's suggestion mapAccept seems favorable. This being said, we'll pause the naming discussion for now and will resume it once all other questions hav

Re: RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

On 6/26/20 2:41 AM, Alan Bateman wrote: On 25/06/2020 22:45, Daniel D. Daugherty wrote: Here's the context diff: $ hg diff diff -r cf65909b98c5 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt    Thu Jun 25 15:00:59 2020 -0400 +++ b/test/jdk/ProblemList.txt    Thu Jun 25 17:39:01 2020

RFR: JDK-8248264: WinUpgradeUUIDTest application is missing in downgrade scenario

Please review fix [2] for jpackage bug [1]. Put `RemoveExistingProducts` action before `CostInitialize` action in `InstallExecuteSequence` sequence to uninstall existing product(s) before installer makes changes to the file system. Existing Wix `MajorUpgrade` elements in main.wxs implicitely ad

Re: RFR: JDK-8248239: jpackage adds some arguments twice in case it is re-executed by JLI

Hi Aleksei, I think the idea of partial reading data from cfg file when the launcher is restarted has a flaw. It would be better if app launcher can detect if it was restarted and if it was, not read cfg file at all, but pass command line arguments as is in JLI_Launch(). Let my think on ideas

Re: RFR 8248412: test/jdk/java/sql/testng/test/sql/DriverManagerPermissionsTests.java can fail

Looks good to me Lance. Thanks for fixing that! best regards, -- daniel On 26/06/2020 16:25, Lance Andersen wrote: Hi all, Please review this patch for https://bugs.openjdk.java.net/browse/JDK-8248412 where DriverManagerPermissionsTests.jav

Re: RFR 8248412: test/jdk/java/sql/testng/test/sql/DriverManagerPermissionsTests.java can fail

Hi Lance, The change looks good to me. Naoto On 6/26/20 8:25 AM, Lance Andersen wrote: Hi all, Please review this patch for https://bugs.openjdk.java.net/browse/JDK-8248412 where DriverManagerPermissionsTests.java can occasionally fail in a

Schubfach adoption + RFR CSR JDK-8202555: Double.toString(double) sometimes produces incorrect results

Hello, beside the usual request to this community to review the Schubfach algorithm and its efficient implementation [1, 2], I'm pleased to announce that they have been adopted resp. adapted as part of jsoniter-scala [3, 4], a project aiming to be the fastest JSON parsing/serialization Scal

RFR 8248412: test/jdk/java/sql/testng/test/sql/DriverManagerPermissionsTests.java can fail

Hi all, Please review this patch for https://bugs.openjdk.java.net/browse/JDK-8248412 where DriverManagerPermissionsTests.java can occasionally fail in a mach5 run specifying -test open/test/jdk/:jdk_core,closed/test/jdk/:jdk_core The webrev

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

Hi Rémi! On 26/06/2020 15:38, fo...@univ-mlv.fr wrote: for your first example, the only valid value for Consumer is null, so consumer.accept(null) should work. for the second example, Consumer accepts any subtypes of String, given that String is final, the only possible type is String, so con

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

- Mail original - > De: "Daniel Fuchs" > À: "Remi Forax" > Cc: "Patrick Concannon" , "core-libs-dev" > > Envoyé: Vendredi 26 Juin 2020 16:13:08 > Objet: Re: RFR[8238286]: 'Add new flatMap stream operation that is more > amenable to pushing’ > Hi Rémi, > > On 25/06/2020 23:12, Remi Fo

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

Hi Rémi, On 25/06/2020 23:12, Remi Forax wrote: if i have already have a BiConsumer, Object>, i would like to be able to call Stream.mapMulti() with that bi-consumer as argument. and obviously, i got it wrong, Consumer is not a super-type of Consumer, it should be a BiConsumer, Object> or a Bi

Re: Scalar replacement issue in JDK 14.0.1

Hi Sergie, This seems like a question for hotspot-compiler-dev rather than core-libs-dev. Thanks, David On 26/06/2020 10:06 pm, Сергей Цыпанов wrote: Hello, while looking into an issue I've found out that scalar replacement is not working in trivial case on JDK 14.0.1. This benchmark illu

Scalar replacement issue in JDK 14.0.1

Hello, while looking into an issue I've found out that scalar replacement is not working in trivial case on JDK 14.0.1. This benchmark illustrates the issue: @State(Scope.Thread) @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) @Fork(jvmArgsAppend = {"-Xms2g", "-Xmx2g"}) p

Re: RFR: JDK-8248239: jpackage adds some arguments twice in case it is re-executed by JLI

Hi Alexey, Thank you for looking into it. As far as using parent pid, it does not seem to work as example [1] demonstrates. The parent process remains the same after re-execution and does not become the current process. I checked passing arguments in the "ArgOption" section using several cases [2

Re: RFR [1]6 8248326 Add a minimal serialization test for local records

> On 25 Jun 2020, at 16:24, Daniel Fuchs wrote: > > Hi Chris, > > Looks good to me. Thanks for the review Daniel. > It might also be beneficial to double check > that the hash codes of the two objects are equal. Since no other tests in this area check the hash code, and this issue is narro