Re: RFR 8251989: Hex encoder and decoder utility

Hello! Great and long-awaited API, thanks! How about wither-style construction? Like Hex.encoder().upperCase().withDelimiter(":").wrappedIn("{", "}"). This allows modifying existing encoder (e.g. adding prefix and suffix, preserving delimiter and case). Also, you can specify only necessary parame

Re: Optimize sun.invoke.util.BytecodeDescriptor.unparse

Pushed as     8252127: Optimize sun.invoke.util.BytecodeDescriptor.unparse https://bugs.openjdk.java.net/browse/JDK-8252127 Thanks Christoph On 8/20/20 4:15 PM, Roger Riggs wrote: Hi Christoph, Looks good. Note that Claes added the cases for Object.class and int.class to maximize the perform

RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

Please review the addition of comments to classes and fields to resolve javadoc "no comment" warnings in the java.lang and java.io packages. The comments are derived from the existing behavior and context. Webrev:    http://cr.openjdk.java.net/~rriggs/webrev-nocomment-8251203-1/ CSR:     https:/

RFR 8251989: Hex encoder and decoder utility

Hi Roger, I'm only a contributor, not an official reviewer. Despite this, I would like to make some notes about the encoder part. (1) Comparing with other APIs that accept a range of a byte[], my understanding is that encode(byte[], int, int) should throw IOOE when index < 0 or too big, eve

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

On 21/08/2020 16:09, Roger Riggs wrote: Please review the addition of comments to classes and fields to resolve javadoc "no comment" warnings in the java.lang and java.io packages. The comments are derived from the existing behavior and context. Looks good to me Roger. I don't quite recall whe

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

Hi Roger, Looks good overall. Friendly reminder to update the copyright in the files such as File.java, UncheckedIOException.java, AbstractStringBuilder.java etc... > On Aug 21, 2020, at 11:09 AM, Roger Riggs wrote: > > Please review the addition of comments to classes and fields to resolv

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

Hi Roger, Changes look good to me. One question, do we need to update the copyright year for this change? Naoto On 8/21/20 8:09 AM, Roger Riggs wrote: Please review the addition of comments to classes and fields to resolve javadoc "no comment" warnings in the java.lang and java.io packages.

Re: RFR 8251989: Hex encoder and decoder utility

Hi Rafaello, On 8/21/20 11:44 AM, Raffaello Giulietti wrote: Hi Roger, I'm only a contributor, not an official reviewer. Despite this, I would like to make some notes about the encoder part. Reviews are always appreciated, whether Reviewer or not. (1) Comparing with other APIs that accept

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

Thanks for the reviews. The copyright dates are updated in the webrev:     http://cr.openjdk.java.net/~rriggs/webrev-nocomment-8251203-2/ The @serial javadoc tag is used on any serialization related field or method. Are there some missing? I expect javac would warn if they were missing. Thank

Re: RFR 8251989: Hex encoder and decoder utility

Hi Roger, On 2020-08-21 18:38, Roger Riggs wrote: Hi Rafaello, (It's Raffaello, with 2 effs.) I'll let some of the higher level API questions settle before updating the webrev. Thanks, Roger Sure. In the meantime I'll nevertheless take a look at the current implementation of the D

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

On 8/21/20 8:09 AM, Roger Riggs wrote: Please review the addition of comments to classes and fields to resolve javadoc "no comment" warnings in the java.lang and java.io packages. The comments are derived from the existing behavior and context. Webrev:    http://cr.openjdk.java.net/~rriggs/we

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

Hi Roger, On 21/08/2020 17:52, Roger Riggs wrote: The @serial javadoc tag is used on any serialization related field or method. Are there some missing? I expect javac would warn if they were missing. Well I was wondering whether an @serial tag would be appropriate in the documentation of thes

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

Hi Daniel, Re-reading the java.io.Serial javadoc, the annotation is only appropriate on the methods and fields specified as being part of the Serializalble mechanism. For example, readObject, writeObject, readResolve, wroteReplace, and readObjectNoData, and fields serialPersistentFields and se

Re: RFR 8251989: Hex encoder and decoder utility

Hi Tagir, On 8/21/20 6:15 AM, Tagir Valeev wrote: Hello! Great and long-awaited API, thanks! How about wither-style construction? Like Hex.encoder().upperCase().withDelimiter(":").wrappedIn("{", "}"). This allows modifying existing encoder (e.g. adding prefix and suffix, preserving delimiter a

RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

Pelase review a patch to add the missing @return, @throws, @param statements in the java.xml package (excluding the DOM component). JBS: https://bugs.openjdk.java.net/browse/JDK-8251561 CSR: https://bugs.openjdk.java.net/browse/JDK-8251995 webrev: http://cr.openjdk.java.net/~joehw/jdk16/8251561

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

Hi Joe, This looks OK. > On Aug 21, 2020, at 2:23 PM, Joe Wang wrote: > > Pelase review a patch to add the missing @return, @throws, @param statements > in the java.xml package (excluding the DOM component). > > JBS: https://bugs.openjdk.java.net/browse/JDK-8251561 > CSR: https://bugs.openj

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

+1 Naoto On 8/21/20 12:24 PM, Lance Andersen wrote: Hi Joe, This looks OK. On Aug 21, 2020, at 2:23 PM, Joe Wang wrote: Pelase review a patch to add the missing @return, @throws, @param statements in the java.xml package (excluding the DOM component). JBS: https://bugs.openjdk.java.net