Hi Andrew, thank you for taking the time to review this.
Since we have now moved to git, I have raised a new PR for this RFR:
https://github.com/openjdk/jdk/pull/71
https://bugs.openjdk.java.net/browse/JDK-8173585
I have improved the micro benchmark in the ways which you and others have
request
> On Sep 7, 2020, at 10:56 AM, Eric Liu wrote:
> I have tested 4 cases for those warnings:
> a) Without my patch, without asan, gcc-8 and gcc-10 are OK.
> b) Without my patch, with asan, gcc-8 has warned, gcc-10 is OK.
> c) With my patch, without asan, gcc-8 and gcc-10 are OK.
That’s *very* stran
> On Sep 7, 2020, at 5:55 AM, Florian Weimer wrote:
>
> * Kim Barrett:
>
>> And strlen is not even necessarily the best solution, as it likely
>> introduces an additional otherwise unnecessary string traversal. For
>> example, getFlags could be changed to reject an overly long ifname,
>> without
On Mon, 7 Sep 2020 11:23:28 GMT, Aleksei Voitylov wrote:
> continuing the review thread from here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html
>
>> The download side of using JNI in these tests is that it complicates the
>> setup a bit for those that run jt
Hi Jason,
With respect to the increased ns/op in the utf16_mixed_char benchmark,
how should we understand the lower performance?
Thanks, Roger
On 9/8/20 8:02 AM, Tatton, Jason wrote:
Hi Andrew, thank you for taking the time to review this.
Since we have now moved to git, I have raised a new
8252830: Added missing javadoc comments in java.rmi
-
Commit messages:
- Added missing comments in java.rmi
Changes: https://git.openjdk.java.net/jdk/pull/79/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=79&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-82
On Tue, 8 Sep 2020 15:19:40 GMT, Roger Riggs wrote:
> 8252830: Added missing javadoc comments in java.rmi
Add the missing comments where required by javadoc -Xdoclint to document public
and serializable classes, methods, and
fields.
-
PR: https://git.openjdk.java.net/jdk/pull/79
Since this change affects security code, please make sure you add
security-...@openjdk.java.net on any followup code reviews.
Thanks,
Sean
On 9/1/20 10:44 AM, Andrew Haley wrote:
On 01/09/2020 11:53, Yangfei (Felix) wrote:
Sure, I am happy if the original author of the assembly code or someon
This is the same patch as
[8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/)
published in
[hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html).
The rest of th
On Tue, 8 Sep 2020 15:19:40 GMT, Roger Riggs wrote:
> 8252830: Correct missing javadoc comments in java.rmi module
Changes requested by dfuchs (Reviewer).
src/java.rmi/share/classes/java/rmi/activation/ActivationGroupDesc.java line
321:
> 319: *
> 320: */
> 321: priv
On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote:
> This is the same patch as
> [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/)
> published in
> [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hot
Can you use StackWalker with StackWalker.Option::SHOW_HIDDEN_FRAMES to
programmatically find the appropriate frame as an interim solution?
ClassOption.SHOW_IN_STACKTRACE might be one possibility. IMO we should
take the time and consider together with JDK-8212620 what other options
could be e
> 8252830: Correct missing javadoc comments in java.rmi module
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Added @java.io.Serial annotation to serializable methods and fields
-
Changes:
- all: https://git.openjdk.ja
On Tue, 8 Sep 2020 18:55:40 GMT, Roger Riggs wrote:
>> 8252830: Correct missing javadoc comments in java.rmi module
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added @java.io.Serial annotation to serializable methods and
On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote:
> This is the same patch as
> [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/)
> published in
> [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hot
On Tue, 8 Sep 2020 18:55:40 GMT, Roger Riggs wrote:
>> 8252830: Correct missing javadoc comments in java.rmi module
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added @java.io.Serial annotation to serializable methods and
> 8252830: Correct missing javadoc comments in java.rmi module
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Added java.io.Serial to java.rmi.activation.ActivationID
-
Changes:
- all: https://git.openjdk.java.net/jdk/
On Tue, 8 Sep 2020 19:44:21 GMT, Roger Riggs wrote:
>> 8252830: Correct missing javadoc comments in java.rmi module
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added java.io.Serial to java.rmi.activation.ActivationID
Ma
On Tue, 8 Sep 2020 19:44:21 GMT, Roger Riggs wrote:
>> 8252830: Correct missing javadoc comments in java.rmi module
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added java.io.Serial to java.rmi.activation.ActivationID
Ma
On Sun, 6 Sep 2020 15:25:10 GMT, rgiulietti
wrote:
> This is a follow-up of the Mercurial-based workflow initiated on the
> core-lib-devs mailing list [0]. Not sure if this
> one is strictly necessary or if the patches sent on the list are sufficient.
> Anyway, I exploit this PR as a test ;-)
On Sun, 6 Sep 2020 15:25:10 GMT, rgiulietti
wrote:
> This is a follow-up of the Mercurial-based workflow initiated on the
> core-lib-devs mailing list [0]. Not sure if this
> one is strictly necessary or if the patches sent on the list are sufficient.
> Anyway, I exploit this PR as a test ;-)
On Tue, 8 Sep 2020 20:30:36 GMT, Éamonn McManus
wrote:
>> This is a follow-up of the Mercurial-based workflow initiated on the
>> core-lib-devs mailing list [0]. Not sure if this
>> one is strictly necessary or if the patches sent on the list are sufficient.
>> Anyway, I exploit this PR as a t
On Tue, 8 Sep 2020 19:44:21 GMT, Roger Riggs wrote:
>> 8252830: Correct missing javadoc comments in java.rmi module
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added java.io.Serial to java.rmi.activation.ActivationID
Ma
> This is a follow-up of the Mercurial-based workflow initiated on the
> core-lib-devs mailing list [0]. Not sure if this
> one is strictly necessary or if the patches sent on the list are sufficient.
> Anyway, I exploit this PR as a test ;-)
> [0]
> https://mail.openjdk.java.net/pipermail/core-
On Tue, 8 Sep 2020 20:42:41 GMT, rgiulietti
wrote:
>> src/java.base/share/classes/java/lang/Long.java line 1697:
>>
>>> 1695: final long q = (dividend >>> 1) / divisor << 1;
>>> 1696: final long r = dividend - q * divisor;
>>> 1697: return r - (~(r - divisor)
Add some generics and wrap in `{@code}` to protect angle brackets.
-
Commit messages:
- 8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types
Changes: https://git.openjdk.java.net/jdk/pull/87/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=87&rang
On Tue, 8 Sep 2020 22:47:40 GMT, Joe Darcy wrote:
>> Add some generics and wrap in `{@code}` to protect angle brackets.
>
> Marked as reviewed by darcy (Reviewer).
Looks good with the copyright year update.
-
PR: https://git.openjdk.java.net/jdk/pull/87
On Tue, 8 Sep 2020 22:32:47 GMT, Stuart Marks wrote:
> Add some generics and wrap in `{@code}` to protect angle brackets.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/87
On Tue, 8 Sep 2020 22:32:47 GMT, Stuart Marks wrote:
> Add some generics and wrap in `{@code}` to protect angle brackets.
Marked as reviewed by darcy (Reviewer).
Looks fine.
-
PR: https://git.openjdk.java.net/jdk/pull/87
On Tue, 8 Sep 2020 22:32:47 GMT, Stuart Marks wrote:
> Add some generics and wrap in `{@code}` to protect angle brackets.
Looks good
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/87
On Tue, 8 Sep 2020 22:58:58 GMT, Lance Andersen wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright years.
>
> Marked as reviewed by lancea (Reviewer).
Aha, I knew I forgot something! The copyright ye
> Add some generics and wrap in `{@code}` to protect angle brackets.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright years.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/87/files
- new: htt
On Tue, 8 Sep 2020 23:00:21 GMT, Stuart Marks wrote:
>> Add some generics and wrap in `{@code}` to protect angle brackets.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright years.
Marked as reviewed by lance
On Tue, 8 Sep 2020 23:03:25 GMT, Stuart Marks wrote:
>> Add some generics and wrap in `{@code}` to protect angle brackets.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright years.
All good.
-
M
On Mon, 7 Sep 2020 11:23:28 GMT, Aleksei Voitylov wrote:
> continuing the review thread from here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html
>
>> The download side of using JNI in these tests is that it complicates the
>> setup a bit for those that run jt
On Tue, 8 Sep 2020 22:32:47 GMT, Stuart Marks wrote:
> Add some generics and wrap in `{@code}` to protect angle brackets.
This pull request has now been integrated.
Changeset: 30fa8d5d
Author:Stuart Marks
URL: https://git.openjdk.java.net/jdk/commit/30fa8d5d
Stats: 10 lines in 2
Hi Kim,
> Kim Barrett on Sent: 08 September 2020 20:28
>> On Sep 7, 2020, at 10:56 AM, Eric Liu wrote:
>> I have tested 4 cases for those warnings:
>> a) Without my patch, without asan, gcc-8 and gcc-10 are OK.
>> b) Without my patch, with asan, gcc-8 has warned, gcc-10 is OK.
>> c) With my
On Tue, 8 Sep 2020 22:05:13 GMT, rgiulietti
wrote:
>> This is a follow-up of the Mercurial-based workflow initiated on the
>> core-lib-devs mailing list [0]. Not sure if this
>> one is strictly necessary or if the patches sent on the list are sufficient.
>> Anyway, I exploit this PR as a test
38 matches
Mail list logo
