Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-08 Thread Nick Gasson
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393 [

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-08 Thread David Holmes
On Fri, 6 Nov 2020 21:42:41 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v14]

2020-11-08 Thread David Holmes
On Fri, 30 Oct 2020 12:16:02 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-08 Thread David Holmes
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393 [

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-08 Thread David Holmes
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393 [

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod… [v2]

2020-11-08 Thread Hui Shi
On Fri, 6 Nov 2020 08:58:13 GMT, Joel Borggrén-Franck wrote: > Are there any benchmarks to compare this accessor with the previous version > in the presumably common case where there is no or very little contention? > Edit to clarify: it is stated as "trivial" is this also measured somewhere?

Re: RFR: 8247781: Day periods support [v10]

2020-11-08 Thread Naoto Sato
> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: 8247781: Day periods support [v10]

2020-11-08 Thread Naoto Sato
On Fri, 6 Nov 2020 23:59:36 GMT, Stephen Colebourne wrote: >> I find the whole "half way between the start and end" behaviour of day >> periods odd anyway, but if it is to be supported then it should be >> consistent as you've implemented. >> >> Another option I should have thought of earlie

Re: RFR: 8180352: Add Stream.toList() method

2020-11-08 Thread Alan Snyder
> On Nov 8, 2020, at 3:32 AM, fo...@univ-mlv.fr wrote: > > It's a strawman but the effect is real, the more interfaces you have the less > you can reuse code because the code is written with the wrong interface for > your use case. There are points of compromise. If someone can accept misbe

Re: RFR: 8066622 8066637: remove deprecated using java.io.File.toURL() in internal classes

2020-11-08 Thread Phil Race
On Sat, 7 Nov 2020 07:55:03 GMT, Sebastian Ritter wrote: > In result of Javadoc to do not use java.io.File.toURL() > Change use java.io.File.toURL().toURI() instead. You reference a desktop bug that discusses many, many deprecations and skara has identified https://bugs.openjdk.java.net/browse

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v22]

2020-11-08 Thread Alan Bateman
On Thu, 5 Nov 2020 17:14:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the third incubation round >> of the foreign memory access API incubation (see JEP 393 [1]). This >> iteration focus on improving the usability of the API in 3 main ways: >> >> * fi

Re: RFR: 8180352: Add Stream.toList() method [v2]

2020-11-08 Thread Peter Levart
On Sun, 8 Nov 2020 10:47:08 GMT, Peter Levart wrote: >>> Simon Roberts wrote: >> >>> This discussion of unmodifiable lists brings me back to the thought that >>> there would be good client-side reasons for inserting an UnmodifiableList >>> interface as a parent of LIst, not least because all our

Re: Class TreeMap | Lower and Upper Count Support

2020-11-08 Thread forax
> De: "mayank bansal" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Dimanche 8 Novembre 2020 12:55:09 > Objet: Re: Class TreeMap | Lower and Upper Count Support > Hi Remi, > Thank you for pointing that out. This is providing the same feature but it is > not the optimal approach for calculat

Re: Class TreeMap | Lower and Upper Count Support

2020-11-08 Thread mayank bansal
Hi Remi, Thank you for pointing that out. This is providing the same feature but it is not the optimal approach for calculating the size. AscendingSubMap().size() is actually iterating each and every element using Iterator to calculate the size resulting in the O(N) time complexity which can be r

Re: Filtered XMLStreamReader Exceptions (java.xml)

2020-11-08 Thread Michael Edgar
Hi Joe, This is the first issue I have worked on with openjdk so I assume I will need a sponsor (I do not have a JBS account). Regarding the PR, I am not familiar with the Skara process. Is there anything I need to know beyond the typical GitHub PR process? Thanks, Mike On Thu, Nov 5, 2020 at 8

Re: RFR: 8180352: Add Stream.toList() method

2020-11-08 Thread forax
> De: "Alan Snyder" > À: "Remi Forax" > Cc: "Simon Roberts" , "core-libs-dev" > > Envoyé: Vendredi 6 Novembre 2020 18:55:40 > Objet: Re: RFR: 8180352: Add Stream.toList() method Hi Alan, >>> This discussion of unmodifiable lists brings me back to the thought that >>> there would be good client

Re: RFR: 8180352: Add Stream.toList() method [v2]

2020-11-08 Thread Peter Levart
On Fri, 6 Nov 2020 03:05:45 GMT, Stuart Marks wrote: >> @ePaul wrote: >> >>> The Stream API works just as well with [third party] collection libraries >>> instead of the java.util ones, just using different collectors. Adding a >>> method which directly returns a java.util.List somewhat couple

Re: Class TreeMap | Lower and Upper Count Support

2020-11-08 Thread Remi Forax
Is it different from headMap(key, true).size() / tailMap(key, true).size() ? https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/util/NavigableMap.html#headMap(K,boolean) https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/util/NavigableMap.html#tailMap(K,boolean) che

Class TreeMap | Lower and Upper Count Support

2020-11-08 Thread mayank bansal
Hi Everyone, I would like to propose and work on a feature request of supporting the lower and higher count in java class TreeMap. "lower count" is the number of elements that are strictly less than the given value. "upper count" is the number of elements that are strictly greater than the given v

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

2020-11-08 Thread Alan Bateman
On Wed, 4 Nov 2020 07:45:09 GMT, Alan Bateman wrote: >>> The javadoc for copyFrom isn't changed in this update but I notice it >>> specifies IndexOutOfBoundException when the source segment is larger than >>> the receiver, have other exceptions been examined? >> >> This exception is consistent