Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod… [v5]

On Thu, 12 Nov 2020 12:23:36 GMT, Alan Bateman wrote: >> @AlanBateman >> >>> What is the reason for using an int? I remember there was a suggestion for >>> three states but two states seems okay so curious why it was changed from >>> boolean to int. >> >> shipilev suggested not to use

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod… [v6]

> …AccessorImpl object > > We met real problem when using protobuf with option optimized for code size, > detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883 > > Optimize solution is adding a new boolean field to detect concurrent method > accessor generation in same

Re: RFR: 8255947: [macos] Signed macOS jpackage app doesn't filter spurious '-psn' argument [v2]

> This is regression from JDK-8242302 and for some reason removing -psn > argument code was removed during refactoring. Fixed be adding removing -psn > argument back. Also, test was added to test this functionality. Alexander Matveev has updated the pull request incrementally with one

Integrated: 8256063: Module::getPackages on an unnamed module may return packages that are in a named module

On Wed, 11 Nov 2020 23:02:49 GMT, Mandy Chung wrote: > If `Module::getPackages` is invoked on the unnamed module of a class loader > then the set of packages returned will include the packages of any named > modules > that are defined to that class loader. This is a spec and implementation

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote: > JDK-8189198: Add "forRemoval = true" to Applet APIs @andyherrick can you enter the `/csr needed` command? I would, but it needs to be done by either the author of the PR or a Reviewer. - PR:

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs [v2]

On Thu, 12 Nov 2020 20:48:13 GMT, Andy Herrick wrote: >> JDK-8189198: Add "forRemoval = true" to Applet APIs > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the

Re: RFR: 8247781: Day periods support [v13]

On Thu, 12 Nov 2020 21:49:16 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed the following comments: >> - https://github.com/openjdk/jdk/pull/938#discussion_r522185469 >> -

Re: RFR: 8247781: Day periods support [v14]

> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: 8230501: Class data support for hidden classes [v2]

> Provide the `Lookup::defineHiddenClassWithClassData` API that allows live > objects > be shared between a hidden class and other classes. A hidden class can load > these live objects as dynamically-computed constants via this API. > > Specdiff >

Re: RFR: 8247781: Day periods support [v13]

On Thu, 12 Nov 2020 20:03:14 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs [v2]

> JDK-8189198: Add "forRemoval = true" to Applet APIs Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the

Re: RFR: 8247781: Day periods support [v12]

On Thu, 12 Nov 2020 15:21:52 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added a test case for user defined temporal field resolution with day >> period. > >

Re: RFR: 8247781: Day periods support [v12]

On Thu, 12 Nov 2020 15:41:56 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added a test case for user defined temporal field resolution with day >> period. > >

Re: RFR: 8247781: Day periods support [v11]

On Thu, 12 Nov 2020 15:18:44 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clarified 24:00 for "midnight" type in the spec. Some clean up. > >

Re: RFR: 8247781: Day periods support [v13]

> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: 8230501: Class data support for hidden classes

On Thu, 12 Nov 2020 14:18:17 GMT, Jorn Vernee wrote: >> Provide the `Lookup::defineHiddenClassWithClassData` API that allows live >> objects >> be shared between a hidden class and other classes. A hidden class can load >> these live objects as dynamically-computed constants via this API. >>

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v18]

On Wed, 11 Nov 2020 14:18:33 GMT, Vladimir Ivanov wrote: >> Maurizio Cimadamore has updated the pull request incrementally with 10 >> additional commits since the last revision: >> >> - Merge pull request #7 from JornVernee/Additional_Review_Comments >> >>Additional review comments >>

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v20]

> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v19]

> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this

Re: RFR: 8255947: [macos] Signed macOS jpackage app doesn't filter spurious '-psn' argument

On Wed, 11 Nov 2020 04:28:02 GMT, Alexander Matveev wrote: > This is regression from JDK-8242302 and for some reason removing -psn > argument code was removed during refactoring. Fixed be adding removing -psn > argument back. Also, test was added to test this functionality.

Integrated: 8256244: java/lang/ProcessHandle/PermissionTest.java fails with TestNG 7.1

On Thu, 12 Nov 2020 15:48:33 GMT, Roger Riggs wrote: > TestNG 7.1 changed/corrected the way that @BeforeGroups are selected at > runtime. > The test was depending on @BeforeGroups to initialize common security policy > for a number of tests. > The tests are modified to individually setup the

Re: RFR: 8247781: Day periods support [v12]

On Tue, 10 Nov 2020 19:52:14 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting

Re: RFR: 8256244: java/lang/ProcessHandle/PermissionTest.java fails with TestNG 7.1

On Thu, 12 Nov 2020 15:48:33 GMT, Roger Riggs wrote: > TestNG 7.1 changed/corrected the way that @BeforeGroups are selected at > runtime. > The test was depending on @BeforeGroups to initialize common security policy > for a number of tests. > The tests are modified to individually setup the

Integrated: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

On Wed, 7 Oct 2020 17:13:22 GMT, Maurizio Cimadamore wrote: > This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first,

Working on JDK-8072719

Hi! I think that JDK-8072719 , enhancing checked collections to accept a Predicate, can be a valuable addition to the JDK. I would like to start a discussion on whether this is a good fit for the Collections framework and the JDK. If it is decided

Re: RFR: 8256244: java/lang/ProcessHandle/PermissionTest.java fails with TestNG 7.1

On Thu, 12 Nov 2020 15:48:33 GMT, Roger Riggs wrote: > TestNG 7.1 changed/corrected the way that @BeforeGroups are selected at > runtime. > The test was depending on @BeforeGroups to initialize common security policy > for a number of tests. > The tests are modified to individually setup the

RFR: 8256244: java/lang/ProcessHandle/PermissionTest.java fails with TestNG 7.1

TestNG 7.1 changed/corrected the way that @BeforeGroups are selected at runtime. The test was depending on @BeforeGroups to initialize common security policy for a number of tests. The tests are modified to individually setup the needed security manager and policy. - Commit

Re: RFR: 8247781: Day periods support [v12]

On Tue, 10 Nov 2020 19:52:14 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting

Re: RFR: 8247781: Day periods support [v11]

On Tue, 10 Nov 2020 00:07:16 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting

Re: RFR: 8247781: Day periods support [v12]

On Tue, 10 Nov 2020 19:52:14 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting

Re: RFR: 8230501: Class data support for hidden classes

On Thu, 12 Nov 2020 15:11:03 GMT, Jorn Vernee wrote: >> Provide the `Lookup::defineHiddenClassWithClassData` API that allows live >> objects >> be shared between a hidden class and other classes. A hidden class can load >> these live objects as dynamically-computed constants via this API. >>

Re: RFR: 8230501: Class data support for hidden classes

On Wed, 11 Nov 2020 18:52:10 GMT, Mandy Chung wrote: > Provide the `Lookup::defineHiddenClassWithClassData` API that allows live > objects > be shared between a hidden class and other classes. A hidden class can load > these live objects as dynamically-computed constants via this API. > >

Re: RFR: 8255787: Tag container tests that use cGroups with cgroups keyword

On Wed, 11 Nov 2020 00:27:59 GMT, Serguei Spitsyn wrote: >> Please review this small change to add a cgroups keyword to tests that use >> cgroups. The fix was tested by running Mach5 container tests. > > Hi Harold, > > The fix looks good. > > Thanks, > Serguei Thanks Serguei! Harold

Integrated: 8255787: Tag container tests that use cGroups with cgroups keyword

On Tue, 10 Nov 2020 21:24:25 GMT, Harold Seigel wrote: > Please review this small change to add a cgroups keyword to tests that use > cgroups. The fix was tested by running Mach5 container tests. This pull request has now been integrated. Changeset: 4df8abc2 Author:Harold Seigel URL:

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod… [v5]

On Thu, 12 Nov 2020 04:23:37 GMT, Hui Shi wrote: >> src/java.base/share/classes/jdk/internal/reflect/NativeConstructorAccessorImpl.java >> line 44: >> >>> 42: private DelegatingConstructorAccessorImpl parent; >>> 43: private int numInvocations; >>> 44: private int generated; >> >>

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v29]

> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which

Re: RFR: 8256063: Module::getPackages on an unnamed module may return packages that are in a named module

On Wed, 11 Nov 2020 23:02:49 GMT, Mandy Chung wrote: > If `Module::getPackages` is invoked on the unnamed module of a class loader > then the set of packages returned will include the packages of any named > modules > that are defined to that class loader. This is a spec and implementation